[Compatibility] Adding RENAMENX command #661
Open
+541
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is there a way to check the existence of the object without calling |
TalZaccai
requested changes
Sep 19, 2024
|
|
||
| var oldKeySlice = parseState.GetArgSliceByRef(0); | ||
| var newKeySlice = parseState.GetArgSliceByRef(1); | ||
| var status = storageApi.RENAMENX(oldKeySlice, newKeySlice); |
There was a problem hiding this comment.
GarnetStatus is not meant to be interpreted this way, you should pass an output parameter to this method and write the appropriate output to it.
| @@ -620,6 +621,7 @@ private RespCommand FastParseCommand(out int count) | |||
| (2 << 4) | 6 when lastWord == MemoryMarshal.Read<ulong>("INCRBY\r\n"u8) => RespCommand.INCRBY, | |||
| (2 << 4) | 6 when lastWord == MemoryMarshal.Read<ulong>("DECRBY\r\n"u8) => RespCommand.DECRBY, | |||
| (2 << 4) | 6 when lastWord == MemoryMarshal.Read<ulong>("RENAME\r\n"u8) => RespCommand.RENAME, | |||
| (2 << 4) | 8 when lastWord == MemoryMarshal.Read<ulong>("NAMENX\r\n"u8) => RespCommand.RENAMENX, | |||
There was a problem hiding this comment.
You need to read the 'RE' prefix as well
| /// GarnetStatus NOTFOUND means old key does not exists | ||
| /// GarnetStatus MOVED means new key already exists | ||
| /// </returns> | ||
| public unsafe GarnetStatus RENAMENX(ArgSlice oldKeySlice, ArgSlice newKeySlice, StoreType storeType) |
There was a problem hiding this comment.
Since this is majorly similar to RENAME, I would suggest adding a bool parameter to the RENAME method to specify if rename should happen only if key doesn't exist, instead of copying all this code (as any future change to this would need to happen in multiple locations).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding support for RENAMENX command in Garnet