Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements in command handling #5 #631

Open
wants to merge 144 commits into
base: main
Choose a base branch
from

Conversation

TalZaccai
Copy link
Contributor

@TalZaccai TalZaccai commented Sep 3, 2024

  • Introducing RawStringInput struct to simplify main store command processing
    • BasicCommands
    • ArrayCommands
    • MainStoreOps
    • AdvancedOps
    • BitmapCommands
    • BitmapOps
    • HyperLogLogCommands
    • HyperLogLogOps
    • KeyAdminCommands
    • CustomRawStringFunctions
  • Supporting RawStringInput serialization/deserialization for AOF recovery
  • Relaying parse state to custom commands / transactions
  • Fixing bug in PFCOUNT logic

Benchmarking results:
main:

Method Mean Error StdDev Allocated
InlinePing 1.493 us 0.0225 us 0.0188 us -
Set 8.963 us 0.1783 us 0.1751 us -
SetEx 13.153 us 0.2306 us 0.4388 us -
Get 5.804 us 0.0819 us 0.0726 us -
ZAddRem 73.947 us 1.1658 us 1.0334 us 23552 B
LPushPop 80.001 us 1.5987 us 3.0801 us 30721 B
SAddRem 64.207 us 1.2544 us 2.3560 us 16384 B
HSetDel 79.286 us 1.0700 us 1.0009 us 55297 B
MyDictSetGet 116.929 us 1.1018 us 0.9200 us 30720 B

current branch:

Method Mean Error StdDev Allocated
InlinePing 1.492 us 0.0185 us 0.0173 us -
Set 8.841 us 0.1280 us 0.1198 us -
SetEx 13.146 us 0.1434 us 0.1341 us -
Get 6.049 us 0.0763 us 0.0714 us -
ZAddRem 71.771 us 1.2070 us 1.1291 us 23552 B
LPushPop 71.520 us 1.2398 us 1.1597 us 30721 B
SAddRem 59.022 us 0.7709 us 0.7211 us 16384 B
HSetDel 76.690 us 1.2125 us 1.0748 us 55297 B
MyDictSetGet 114.768 us 1.0504 us 0.9825 us 30720 B

@TalZaccai TalZaccai marked this pull request as ready for review September 5, 2024 02:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants