Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Menu): Do not rely on tabster restorer for focus restore #32840

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

ling1726
Copy link
Member

Previous Behavior

New Behavior

Related Issue(s)

  • Fixes #

@fabricteam
Copy link
Collaborator

fabricteam commented Sep 16, 2024

📊 Bundle size report

Package & Exports Baseline (minified/GZIP) PR Change
react-components
react-components: Accordion, Button, FluentProvider, Image, Menu, Popover
218.197 kB
63.203 kB
218.317 kB
63.258 kB
120 B
55 B
react-components
react-components: entire library
1.1 MB
271.983 kB
1.1 MB
272.008 kB
164 B
25 B
react-menu
Menu (including children components)
151.856 kB
45.848 kB
152.025 kB
45.914 kB
169 B
66 B
react-menu
Menu (including selectable components)
154.537 kB
46.326 kB
154.706 kB
46.397 kB
169 B
71 B
Unchanged fixtures
Package & Exports Size (minified/GZIP)
react-avatar
Avatar
49.303 kB
15.815 kB
react-avatar
AvatarGroup
20.106 kB
7.968 kB
react-avatar
AvatarGroupItem
63.447 kB
20.034 kB
react-breadcrumb
@fluentui/react-breadcrumb - package
113.699 kB
31.498 kB
react-components
react-components: Button, FluentProvider & webLightTheme
69.14 kB
20.137 kB
react-components
react-components: FluentProvider & webLightTheme
44.447 kB
14.59 kB
react-datepicker-compat
DatePicker Compat
223.64 kB
63.299 kB
react-dialog
Dialog (including children components)
99.724 kB
29.912 kB
react-overflow
hooks only
12.808 kB
4.819 kB
react-persona
Persona
56.194 kB
17.695 kB
react-popover
Popover
128.329 kB
40.143 kB
react-portal-compat
PortalCompatProvider
8.39 kB
2.64 kB
react-table
DataGrid
160.471 kB
45.539 kB
react-table
Table (Primitives only)
42.643 kB
13.82 kB
react-table
Table as DataGrid
131.325 kB
36.373 kB
react-table
Table (Selection only)
70.512 kB
19.965 kB
react-table
Table (Sort only)
69.155 kB
19.576 kB
react-tag-picker
@fluentui/react-tag-picker - package
183.584 kB
55.264 kB
react-tags
InteractionTag
15.199 kB
6.157 kB
react-tags
Tag
29.016 kB
9.524 kB
react-tags
TagGroup
82.197 kB
24.362 kB
react-timepicker-compat
TimePicker
107.387 kB
35.758 kB
🤖 This report was generated against de8118d071983fdc372b1ea24535c38f85e474b9

@fabricteam
Copy link
Collaborator

Perf Analysis (@fluentui/react-components)

Scenario Render type Master Ticks PR Ticks Iterations Status
FluentProviderWithTheme virtual-rerender-with-unmount 78 72 10 Possible regression
All results

Scenario Render type Master Ticks PR Ticks Iterations Status
Avatar mount 649 641 5000
Button mount 305 303 5000
Field mount 1153 1146 5000
FluentProvider mount 716 709 5000
FluentProviderWithTheme mount 77 80 10
FluentProviderWithTheme virtual-rerender 32 36 10
FluentProviderWithTheme virtual-rerender-with-unmount 78 72 10 Possible regression
MakeStyles mount 875 868 50000
Persona mount 1791 1730 5000
SpinButton mount 1396 1428 5000
SwatchPicker mount 1691 1622 5000

@@ -0,0 +1,7 @@
{
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🕵🏾‍♀️ visual regressions to review in the fluentuiv9 Visual Regression Report

Avatar Converged 2 screenshots
Image Name Diff(in Pixels) Image Type
Avatar Converged.badgeMask.chromium.png 8 Changed
Avatar Converged.Badge Mask RTL.chromium.png 6 Changed
Drawer 1 screenshots
Image Name Diff(in Pixels) Image Type
Drawer.Full Overlay Dark Mode.chromium.png 996 Changed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants