fix(v8 DetailsList): Stories and doc update for onItemInvoked prop, remove unnecessary instances
#32421
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📊 Bundle size report✅ No changes found |
smhigley
reviewed
Aug 29, 2024
packages/react-examples/src/react/DetailsList/DetailsList.Documents.Example.tsx
Outdated
Show resolved
Hide resolved
packages/react-examples/src/react/DetailsList/docs/DetailsListBestPractices.md
Outdated
Show resolved
Hide resolved
…BestPractices.md Co-authored-by: Sarah Higley <smhigley@users.noreply.github.com>
…ments.Example.tsx Co-authored-by: Sarah Higley <smhigley@users.noreply.github.com>
smhigley
approved these changes
Aug 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous Behavior
Voice control had no way of accessing the
onItemInvokedbehavior of DetailsList.New Behavior
In the default DetailsList story, a clickable link was added for the file to allow voice control users to access the
onItemInvokedbehavior.A documentation update was added for guidance on using
onItemInvokedwith a clickable element like button or link so that voice control users are also able to access it.I removed the
onItemInvokedbehavior from stories that do not explicitly need it.Related Issue(s)