Skip to content
This repository has been archived by the owner on Mar 4, 2020. It is now read-only.

feat(prototypes): mention scenario with dropdown #931

Merged
merged 11 commits into from
Feb 22, 2019

Conversation

bmdalex
Copy link
Collaborator

@bmdalex bmdalex commented Feb 19, 2019

feat(prototypes): mention scenario with dropdown

Description

This PR attempts to create a prototype to show users how they can mention people using @ key in a rich text editor.

I am using a contentEditable div as rich text input and the Dropdown component to leverage the list of users and filtering through them. The rest of the functionality is in the prototype section

Screenshot

screen recording 2019-02-14 at 16 51 35

Issues:

Later edit:

all issues and blocking items for this PR are fixed

@codecov
Copy link

codecov bot commented Feb 19, 2019

Codecov Report

Merging #931 into master will increase coverage by <.01%.
The diff coverage is 22.22%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #931      +/-   ##
==========================================
+ Coverage   80.38%   80.39%   +<.01%     
==========================================
  Files         657      657              
  Lines        8398     8396       -2     
  Branches     1488     1488              
==========================================
- Hits         6751     6750       -1     
+ Misses       1632     1631       -1     
  Partials       15       15
Impacted Files Coverage Δ
...s/components/Dropdown/dropdownSearchInputStyles.ts 40% <ø> (ø) ⬆️
...ct/src/components/Dropdown/DropdownSearchInput.tsx 48.14% <ø> (ø) ⬆️
packages/react/src/components/Input/Input.tsx 100% <ø> (ø) ⬆️
...themes/teams/components/Dropdown/dropdownStyles.ts 24.13% <0%> (ø) ⬆️
...ackages/react/src/components/Dropdown/Dropdown.tsx 33.96% <24%> (+0.09%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b0dd20c...6340697. Read the comment docs.

@codecov
Copy link

codecov bot commented Feb 19, 2019

Codecov Report

Merging #931 into master will increase coverage by 0.01%.
The diff coverage is 25.92%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #931      +/-   ##
==========================================
+ Coverage   80.42%   80.43%   +0.01%     
==========================================
  Files         659      659              
  Lines        8412     8412              
  Branches     1488     1424      -64     
==========================================
+ Hits         6765     6766       +1     
+ Misses       1632     1631       -1     
  Partials       15       15
Impacted Files Coverage Δ
...themes/teams/components/Dropdown/dropdownStyles.ts 24.13% <0%> (ø) ⬆️
...ackages/react/src/components/Dropdown/Dropdown.tsx 34.13% <26.92%> (+0.26%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ec4827b...27e2526. Read the comment docs.

@bmdalex bmdalex force-pushed the proto/dropdown-with-atmentions-simple branch 3 times, most recently from f75d795 to 27e2526 Compare February 20, 2019 14:19
@codecov
Copy link

codecov bot commented Feb 20, 2019

Codecov Report

Merging #931 into master will decrease coverage by <.01%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #931      +/-   ##
==========================================
- Coverage   80.51%   80.51%   -0.01%     
==========================================
  Files         659      659              
  Lines        8448     8447       -1     
  Branches     1492     1428      -64     
==========================================
- Hits         6802     6801       -1     
  Misses       1631     1631              
  Partials       15       15
Impacted Files Coverage Δ
...s/components/Dropdown/dropdownSearchInputStyles.ts 40% <ø> (ø) ⬆️
...ackages/react/src/components/Dropdown/Dropdown.tsx 34.13% <ø> (ø) ⬆️
packages/react/src/components/Input/Input.tsx 100% <ø> (ø) ⬆️
...ct/src/components/Dropdown/DropdownSearchInput.tsx 48.14% <ø> (ø) ⬆️
...themes/teams/components/Dropdown/dropdownStyles.ts 24.13% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ccc755b...a57f371. Read the comment docs.

@bmdalex bmdalex force-pushed the proto/dropdown-with-atmentions-simple branch from 27e2526 to 7b055c8 Compare February 20, 2019 14:45
@DustyTheBot
Copy link
Collaborator

DustyTheBot commented Feb 20, 2019

Fails
🚫 All of your entries in CHANGELOG.md should be in the **Unreleased** section!

Generated by 🚫 dangerJS

@bmdalex bmdalex force-pushed the proto/dropdown-with-atmentions-simple branch from 7b055c8 to edc801c Compare February 21, 2019 08:47
@bmdalex bmdalex changed the title proto(dropdown): @mention scenario Prototype: @mention scenario with Dropdown Feb 21, 2019
@bmdalex bmdalex changed the title Prototype: @mention scenario with Dropdown feat(prototypes): mention scenario with Dropdown Feb 21, 2019
@bmdalex bmdalex changed the title feat(prototypes): mention scenario with Dropdown feat(prototypes): mention scenario with dropdown Feb 21, 2019
@bmdalex bmdalex force-pushed the proto/dropdown-with-atmentions-simple branch from de6bc33 to 160a298 Compare February 21, 2019 16:28
@bmdalex bmdalex force-pushed the proto/dropdown-with-atmentions-simple branch from 160a298 to 8ab6fa2 Compare February 21, 2019 17:52
Copy link
Contributor

@kuzhelov kuzhelov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice work 👍 just couple of things that I would like to be addressed before merge (apart from minor comments:

@bmdalex
Copy link
Collaborator Author

bmdalex commented Feb 22, 2019

thanks @kuzhelov , here are my responses:

see: #931 (comment)

fixed

Copy link
Contributor

@kuzhelov kuzhelov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please, just introduce changelog entry before merging 👍

@bmdalex bmdalex merged commit 5d930fa into master Feb 22, 2019
@delete-merged-branch delete-merged-branch bot deleted the proto/dropdown-with-atmentions-simple branch February 22, 2019 15:09
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants