This repository has been archived by the owner on Mar 4, 2020. It is now read-only.
fix(Popup): opened popup causes infinite rendering loop #705
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #706.
TODO
The problem was introduced by #678 - essentially, the root cause is the side effect of
scheduleUpdate()
function that causes React to rerender components tree - and given that each rendering ends up in another render being immediately scheduled, the whole story ends up in an infinite loop. infinite loop.Provided fix introduces ability to the client to explicitly tell when this popup position update should happen. Please, note that this scenario is fairly rare, so that normally
content
prop of thePopup
will be used, as it was before. However, in cases where fine control is necessary over the moment of popup position update, the introduced approach now can be used:This will prevent us from implicit scheduling of render updates and, thus, remove probability of falling into infinite render loops altogether. At the same time, all the user scenarios mentioned in the following issue (#641) will be covered.