Skip to content
This repository has been archived by the owner on Mar 4, 2020. It is now read-only.

feat(Input): base theme light teams #53

Merged
merged 7 commits into from
Aug 7, 2018

Conversation

alinais
Copy link
Contributor

@alinais alinais commented Aug 7, 2018

Input

Updating the default classes for the input to match the light view of the Teams UI.

TODO

  • Conformance test
  • Minimal doc site example
  • Stardust base theme
  • Teams Light theme
  • Teams Dark theme
  • Teams Contrast theme
  • Confirm RTL usage
  • W3 accessibility check
  • Stardust accessibility check
  • Update glossary props table
  • Update the CHANGELOG.md

UI Update

Simple input
image

Simple input focused
image

Input variation with icon
image

@alinais alinais changed the title Feature/input component base theme light teams feat(Input): base theme light teams Aug 7, 2018
@alinais alinais force-pushed the feature/input-component-base-theme-light-teams branch from 598c63e to 45929f1 Compare August 7, 2018 11:59
@codecov
Copy link

codecov bot commented Aug 7, 2018

Codecov Report

Merging #53 into master will decrease coverage by 0.25%.
The diff coverage is 74.07%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #53      +/-   ##
==========================================
- Coverage   87.64%   87.39%   -0.26%     
==========================================
  Files          74       74              
  Lines        1133     1150      +17     
  Branches      213      215       +2     
==========================================
+ Hits          993     1005      +12     
- Misses        136      141       +5     
  Partials        4        4
Impacted Files Coverage Δ
src/themes/teams/siteVariables.ts 100% <100%> (ø) ⬆️
src/components/Input/inputRules.ts 100% <100%> (ø) ⬆️
src/components/Input/inputVariables.ts 100% <100%> (ø) ⬆️
src/components/Input/Input.tsx 78% <46.15%> (-7.72%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4d55443...45929f1. Read the comment docs.

@alinais alinais merged commit 56c0891 into master Aug 7, 2018
@alinais alinais deleted the feature/input-component-base-theme-light-teams branch August 8, 2018 10:56
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants