This repository has been archived by the owner on Mar 4, 2020. It is now read-only.
chore(Chat): move to functional component #2366
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
layershifter
requested review from
dvdzkwsk,
dzearing,
ecraig12345,
JasonGore,
jdhuntington,
kenotron,
levithomason,
miroslavstastny and
mnajdova
as code owners
Perf comparison
Potential regressions comparing to master
Perf tests with no regressions
Generated by 🚫 dangerJS |
mnajdova
reviewed
Feb 18, 2020
| } | ||
|
|
||
| menuRef = React.createRef<HTMLElement>() | ||
| export type ChatMessageStylesProps = Pick< |
There was a problem hiding this comment.
It's good that we have these typings now on the component level, but let's make sure that we move the others too :)
mnajdova
reviewed
Feb 18, 2020
| handleFocus = (e: React.SyntheticEvent) => { | ||
| this.updateActionsMenuPosition() | ||
| const handleFocus = (e: React.SyntheticEvent) => { | ||
| if (updateActionsMenuPosition.current) updateActionsMenuPosition.current() |
There was a problem hiding this comment.
_.invoke(updateActionsMenuPosition, 'current')?
mnajdova
reviewed
Feb 18, 2020
| } | ||
|
|
||
| handleMessageRef = (node: HTMLElement) => this.setState({ messageNode: node }) | ||
| const handleMouseEnter = (e: React.SyntheticEvent) => { | ||
| if (updateActionsMenuPosition.current) updateActionsMenuPosition.current() |
mnajdova
reviewed
Feb 18, 2020
mnajdova
reviewed
Feb 18, 2020
mnajdova
reviewed
Feb 18, 2020
|
|
||
| /** Shorthand array of the items inside the chat. */ | ||
| items?: ShorthandCollection<ChatItemProps> | ||
| } | ||
|
|
||
| class Chat extends UIComponent<WithAsProp<ChatProps>, any> { | ||
| static displayName = 'Chat' | ||
| export type ChatStylesProps = {} |
mnajdova
reviewed
Feb 18, 2020
| ? children | ||
| : _.map(items, item => | ||
| ChatItem.create(item, { | ||
| defaultProps: () => ({ className: Chat.slotClassNames.item }), |
There was a problem hiding this comment.
Shouldn't we by convention send here resolvedStyles.item? I hope not, but still, thought I'd ask
There was a problem hiding this comment.
Discussed offline: let's avoid changes there and keep previous behavior.
Co-Authored-By: Marija Najdova <mnajdova@gmail.com>
…om/stardust-ui/react into chore/chat-to-hooks
Co-Authored-By: Marija Najdova <mnajdova@gmail.com>
…react into chore/chat-to-hooks
mnajdova
reviewed
Feb 18, 2020
| const ElementType = getElementType(props) | ||
| const unhandledProps = getUnhandledProps(ChatMessage.handledProps, props) | ||
|
|
||
| const badgeElement = Label.create(badge, { |
There was a problem hiding this comment.
Another example that we were missing getA11Props :(
mnajdova
approved these changes
Feb 18, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGES
As in other components that are moved functional we limited sets of props that are passed to styles functions.
ChatChatItemattachedcontentPositionChatMessageattachedbadgePositionminefocusedhasBadge(replacement forbadge)hasReactionGroup(replacement forreactionGroup)