This repository has been archived by the owner on Mar 4, 2020. It is now read-only.
prototype(chat pane): accessibility fix attachment in chat #2204
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kolaps33
requested review from
dvdzkwsk,
dzearing,
ecraig12345,
JasonGore,
jdhuntington,
kenotron,
layershifter,
levithomason,
miroslavstastny and
mnajdova
as code owners
kolaps33
changed the title
Perf comparision
Generated by 🚫 dangerJS |
|
Code looks fine, but I can't understand what is fixed, what is broken etc. A bug link would be useful, or at least a description of what the bug was and why this PR fixes it. |
jurokapsiar
approved these changes
Jan 3, 2020
|
@silviuavram improved description of the PR. Thanks for point it out, I forgot did it. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was the bug in attachment for chat prototype, that we had "button" trigger element for popup in another "button" element.
Issue was that "action" slot was not replaced by trigger button but was inserted into slot. And it cause "button" in another "button".
Issue coming from the change done in the PR:
#1513