This repository has been archived by the owner on Mar 4, 2020. It is now read-only.
fix(Popup): filter out NaN values from Popper's styles #1365
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The problem is Popper's calculation logic outputs NaN values for the cases where height (or width) of reference element is
0
. However, this is pretty common case for test environments, where styles may not be rendered/applied toPopup
'strigger
- and, as a result, it will have height of0
.This, in its turn, results in invalid styles being applied to rendered
div
element, as calculated by Popper styles are just passed to slot'sdiv
component, with NaN values being there:Resolution strategy
This PR provides fix that will guarantee that simple mount of
Popup
component in client's tests won't result in console errors - by removing style props that hasNaN
as value.