Fixing link being cut off form small cards on What's new page #2691
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krschau
approved these changes
Apr 18, 2024
dhoehna
approved these changes
Apr 19, 2024
vineeththomasalex
approved these changes
Apr 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the pull request
Removed the vertical orientation from the wrapper control which was creating another vertical column due the lack of vertical space in the stack panel, and changed this control back to stack pannel, as wrapping is no more needed with the scroll enabled.
References and relevant issues
#2093
Detailed description of the pull request / Additional comments
When the big card was first added, design team decided it should have the text wrapped if there was not enough size for it, but this was later changed to a scroll view for accessibility reasons, so a regular StackPanel is now enough for it.
Validation steps performed
PR checklist