Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing graph from small sized widgets and other tweaks #2472

Merged
merged 1 commit into from
Mar 27, 2024

Conversation

guimafelipe
Copy link
Contributor

@guimafelipe guimafelipe commented Mar 26, 2024

Summary of the pull request

When in small size, the widgets have very limited space to show meaningful information. The graph ends up occupying most of the space and make it impossible to see the actual data without scrolling. This change disables the graph from when the widgets are in small size and also adds some small changes to better use the space available.

References and relevant issues

https://microsoft.visualstudio.com/OS/_workitems/edit/49359135/

Detailed description of the pull request / Additional comments

On every core widget, the small size now does not show the generated graph.

For the CPU widget, the small size also does not show the list of most expensive proccess.
image

For the Memory widget, the paged memory will only be shown on the large size and the percentage of memory used only on medium and large size. Also, it uses an smaller font size when the widget size is small to avoid scrolling.
image
image

The GPU and Network widgets are still the same on all sizes, with further design changes needed as it still have the scroll enabled.

Validation steps performed

PR checklist

Copy link
Collaborator

@krschau krschau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These look so good!

@krschau krschau added the Needs-Second Pull request that needs another approval label Mar 27, 2024
@guimafelipe guimafelipe merged commit 43adc94 into main Mar 27, 2024
4 checks passed
@krschau krschau removed the Needs-Second Pull request that needs another approval label Mar 27, 2024
@Pdawg-bytes
Copy link

These look great! Nice job.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants