Activate application from .winget files
#2379
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AmelBawa-msft
commented
Mar 8, 2024
AmelBawa-msft
commented
Mar 8, 2024
| else | ||
| { | ||
| NavigationService.NavigateTo(typeof(WhatsNewViewModel).FullName!); | ||
| case ExtendedActivationKind.File: |
There was a problem hiding this comment.
Create an issue to consider moving this methods logic to an activation handler instead
AmelBawa-msft
commented
Mar 8, 2024
AmelBawa-msft
commented
Mar 8, 2024
tools/SetupFlow/DevHome.SetupFlow/ViewModels/ConfigurationFileViewModel.cs
Outdated
Show resolved
Hide resolved
AmelBawa-msft
commented
Mar 8, 2024
tools/SetupFlow/DevHome.SetupFlow/ViewModels/ConfigurationFileViewModel.cs
Show resolved
Hide resolved
|
@RDMacLachlan -- for visibility. This PR is finally ready to be merged shortly. |
AmelBawa-msft
commented
Mar 8, 2024
| try | ||
| { | ||
| // Don't interrupt the user if the machine configuration is in progress | ||
| if (_setupFlowOrchestrator.FlowPages.Count > 1) |
There was a problem hiding this comment.
Add telemetry (issue)
AmelBawa-msft
requested review from
manodasanW,
dhoehna,
vineeththomasalex,
krschau,
EricJohnson327 and
bbonaby
AmelBawa-msft
commented
Mar 11, 2024
dhoehna
approved these changes
Mar 15, 2024
krschau
approved these changes
Mar 25, 2024
…/joadoumie/file-activation
|
let's go @joadoumie that's my teammate! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the pull request
DSCFileActivationHandlerwas added to handle:.wingetfile when the app is not running.wingetfile when the app is already runningReferences and relevant issues
Detailed description of the pull request / Additional comments
Validation steps performed
File with
*.wingetcan activate the DSC flow in Dev Home:Show message when the DSC configuration feature is disabled
Show message when the user already started the machine configuration flow
PR checklist