Pin default widgets #2233
Merged
Pin default widgets #2233
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krschau
requested review from
dhoehna,
dkbennett,
EricJohnson327 and
AmelBawa-msft
AmelBawa-msft
approved these changes
Feb 8, 2024
EricJohnson327
approved these changes
Feb 9, 2024
This was referenced Feb 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the pull request
On the very first time Dev Home is run, automatically pin three of the core widgets the PM team has picked.
References and relevant issues
Detailed description of the pull request / Additional comments
For first run, the different build channels of Dev Home are considered separately (ie. you could have and use Preview, but then if you install and run Dev for the first time, it will be considered the first run). Also, uninstalling and reinstalling will result in a "first run" (and always has).
Since from the widget service's point of view, all channels of Dev Home are considered the same app, the same widgets are considered pinned in (for example) Preview and Dev. If Dev Home is run for the first time but widgets have already been pinned in another channel by the user, the default widgets will not be pinned so as to not override the existing widgets. This is the improvement over the first version of this feature that was checked in and reverted.
Validation steps performed
PR checklist