[DO NOT MERGE] Enterprise Template TelemetryClient/AppInsights conversation analytics capabilities #425

ryanisgrig · 2018-12-10T21:48:25Z

Description

Updated ET to work with new 4.2 SDK which will support more App Insights telemetry out-of-the-box.
OnboardingDialog is a sample of how the WaterfallDialog telemetry works by passing ITelemetryClient from parent->child dialog.
Refactored Middleware properties to all use camelCasing standard.

Related Issue

#134
#354
https://github.com/daveta/analytics/blob/master/va_reports.md

Testing Steps

Build VSIX project and get .vsix from /bin/debug folder. Install the new template and have a working bot.

Checklist

I have commented my code, particularly in hard-to-understand areas
I have added or updated the appropriate unit tests
I have updated related documentation

If this contains changes that needs to be replicated between the Enterprise Template <-> Virtual Assistant

A duplicate issue is filed to track future work. Port new Conversation Analytics capabilities to Customer Support Template and VA Solution #135

Pointing to daily build 78

…irectory where this will be hosted now.

ryanisgrig · 2018-12-10T21:49:13Z

...csharp/EnterpriseBotTemplate/Bot Framework/Middleware/Telemetry/TelemetryLoggerMiddleware.cs

-                    { TelemetryConstants.ActivityIDProperty, activity.ReplyToId },
-                    { TelemetryConstants.ReplyActivityIDProperty, activity.Id },
-                    { TelemetryConstants.ChannelProperty, activity.ChannelId },
+                    { TelemetryConstants.ChannelIdProperty, activity.ChannelId },


@daveta FYI: I have not seen the channel id populate in SDK telemetry, so I'm providing in the BotReceived/Send events.

lzc850612

We should apply the changes here to VA as needed.

templates/Enterprise-Template/src/csharp/EnterpriseBotTemplate/Bot Framework/BotServices.cs

...mplate/src/csharp/EnterpriseBotTemplate/Bot Framework/Dialogs/Onboarding/OnboardingDialog.cs

...csharp/EnterpriseBotTemplate/Bot Framework/Middleware/Telemetry/TelemetryLoggerMiddleware.cs

...c/csharp/EnterpriseBotTemplate/Bot Framework/Middleware/Telemetry/TelemetryLuisRecognizer.cs

templates/Enterprise-Template/src/csharp/EnterpriseBotTemplate/Bot Framework/Program.cs

templates/Enterprise-Template/src/csharp/EnterpriseBotTemplate/Bot Framework/Startup.cs

templates/Enterprise-Template/src/csharp/EnterpriseBotTemplate/Bot Framework/readme.md

* fix for teams auth * removed dev exception page * updated teams auth middleware * fixed

daveta · 2018-12-13T15:44:27Z

templates/Enterprise-Template/src/csharp/EnterpriseBotTemplate/Bot Framework/BotServices.cs

-                            LuisServices.Add(service.Id, new TelemetryLuisRecognizer(luisApp));
-                            break;
+                            InstrumentationKey = appInsights.InstrumentationKey,
+                        };


In samples, I was removing this - actually wasn't referencing. So I kept the validation checks, but didn't actually create the TelemetryClient since that is effectively done by the extension methods in startup (and registered in DI) as BotTelemetryClient.

daveta · 2018-12-13T15:46:37Z

templates/Enterprise-Template/src/csharp/EnterpriseBotTemplate/Bot Framework/Program.cs

@@ -16,7 +16,6 @@ public static void Main(string[] args)

        public static IWebHost BuildWebHost(string[] args) =>
            WebHost.CreateDefaultBuilder(args)
-                .UseApplicationInsights()


Yeah, what this method does is already being done in other methods subsumed by our overrides so we get the sequencing right.

daveta · 2018-12-13T15:54:06Z

Nice work Ryan!
FYI: (low priority) For your VSIX build, @cleemullins (and I think @darrenj) cooked up some steps where you don't have to check in the zip file. Check out the bot builder vsix csproj.. They add a PreBuildEvent..

Pointing to daily build 78

…irectory where this will be hosted now.

…sation analytics capabilities (#425) * Introduced all 4.2 telemetry changes Pointing to daily build 78 * Removed .pbit and updated README to point to AI/solutions/analytics directory where this will be hosted now. * Fixed formatting * Fixed typo in telemetryclient variable. * Addressed PR comments * Updated to version 4.2.0 * fix for teams auth (#410) * fix for teams auth * removed dev exception page * updated teams auth middleware * fixed * Update readme.md * Introduced all 4.2 telemetry changes Pointing to daily build 78 * Removed .pbit and updated README to point to AI/solutions/analytics directory where this will be hosted now. * Fixed formatting * Fixed typo in telemetryclient variable. * Addressed PR comments * Updated to version 4.2.0

ryanisgrig added 4 commits December 10, 2018 12:44

Introduced all 4.2 telemetry changes

dac6f7a

Pointing to daily build 78

Removed .pbit and updated README to point to AI/solutions/analytics d…

d5dc655

…irectory where this will be hosted now.

Fixed formatting

8098cea

Fixed typo in telemetryclient variable.

43642dc

ryanisgrig added the ET label Dec 10, 2018

ryanisgrig requested review from lzc850612, daveta, lauren-mills and darrenj December 10, 2018 21:48

ryanisgrig commented Dec 10, 2018

View reviewed changes

lzc850612 suggested changes Dec 10, 2018

View reviewed changes

ryanisgrig and others added 4 commits December 10, 2018 18:11

Addressed PR comments

a47c79a

Updated to version 4.2.0

6ef0ae6

fix for teams auth (#410)

3be1160

* fix for teams auth * removed dev exception page * updated teams auth middleware * fixed

Update readme.md

05ccf9c

daveta approved these changes Dec 13, 2018

View reviewed changes

daveta reviewed Dec 13, 2018

View reviewed changes

lzc850612 approved these changes Dec 13, 2018

View reviewed changes

ryanisgrig added 7 commits December 13, 2018 10:33

Introduced all 4.2 telemetry changes

2cf39bc

Pointing to daily build 78

Removed .pbit and updated README to point to AI/solutions/analytics d…

5acd2bc

…irectory where this will be hosted now.

Fixed formatting

2fa8a6d

Fixed typo in telemetryclient variable.

22619c0

Addressed PR comments

8bcecb9

Updated to version 4.2.0

e4aa6dd

Using remote readme

d78f4ce

ryanisgrig merged commit c633739 into master Dec 13, 2018

lauren-mills deleted the ryanlengel/235_enterprisetemplate branch December 17, 2018 16:30

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[DO NOT MERGE] Enterprise Template TelemetryClient/AppInsights conversation analytics capabilities #425

[DO NOT MERGE] Enterprise Template TelemetryClient/AppInsights conversation analytics capabilities #425

ryanisgrig commented Dec 10, 2018 •

edited

Loading

ryanisgrig Dec 10, 2018 •

edited

Loading

lzc850612 left a comment

daveta Dec 13, 2018

daveta Dec 13, 2018

daveta commented Dec 13, 2018

[DO NOT MERGE] Enterprise Template TelemetryClient/AppInsights conversation analytics capabilities #425

[DO NOT MERGE] Enterprise Template TelemetryClient/AppInsights conversation analytics capabilities #425

Conversation

ryanisgrig commented Dec 10, 2018 • edited Loading

Description

Related Issue

Testing Steps

Checklist

ryanisgrig Dec 10, 2018 • edited Loading

Choose a reason for hiding this comment

lzc850612 left a comment

Choose a reason for hiding this comment

daveta Dec 13, 2018

Choose a reason for hiding this comment

daveta Dec 13, 2018

Choose a reason for hiding this comment

daveta commented Dec 13, 2018

ryanisgrig commented Dec 10, 2018 •

edited

Loading

ryanisgrig Dec 10, 2018 •

edited

Loading