This repository has been archived by the owner on Jun 30, 2022. It is now read-only.
[TypeScript][Virtual Assistant & Skill] Fix duplicated messages when communicating through DirectLine #3732
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
lauren-mills
approved these changes
Jun 2, 2021
Batta32
deleted the
feature/southworks/typescript/bots-membersadded-parity
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3731
Purpose
What is the context of this pull request? Why is it being done?
An issue was found where duplicated messages would arrive when contacting the TypeScript V.A. or Skill throught Direct Line. To fix this we implemented a validation taking as a reference the behavior in the sample bots.
Changes
Are there any changes that need to be called out as significant or particularly difficult to grasp? (Include illustrative screenshots for context if applicable.)
We added a validation to the membersAdded method in both the Virtual Assistant and Skill to only deliver the message when it's due to the user.
Tests
Is this covered by existing tests or new ones? If no, why not?
Tests have been adapted and are passing in both the V.A. and Skill
Feature Plan
Are there any remaining steps or dependencies before this issue can be fully resolved? If so, describe and link to any relevant pull requests or issues.
Checklist
General