This repository has been archived by the owner on Jun 30, 2022. It is now read-only.
[C#][Bot-Solutions] Ignore NU5048 warning #3687
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #3688
Purpose
What is the context of this pull request? Why is it being done?
The NU5048 stops the compilation of C# Bot-Solutions in Azure Pipeline.
Changes
Are there any changes that need to be called out as significant or particularly difficult to grasp? (Include illustrative screenshots for context if applicable.)
Skip
NU5048
warning during compilationTests
Is this covered by existing tests or new ones? If no, why not?
Yes, it was tested manually and in a pipeline
Feature Plan
Are there any remaining steps or dependencies before this issue can be fully resolved? If so, describe and link to any relevant pull requests or issues.
This solution is the short-term workaround, however, the long-term approach will be to follow the Dotnet SDK specifying
PackageIcon
andPackageIconUrl
to maintain backward compatibility.Checklist
General