Skip to content
This repository has been archived by the owner on Jun 30, 2022. It is now read-only.

[C#][Bot-Solutions] Ignore NU5048 warning #3687

Conversation

Batta32
Copy link
Collaborator

@Batta32 Batta32 commented Oct 20, 2020

Fix #3688

Purpose

What is the context of this pull request? Why is it being done?
The NU5048 stops the compilation of C# Bot-Solutions in Azure Pipeline.

Changes

Are there any changes that need to be called out as significant or particularly difficult to grasp? (Include illustrative screenshots for context if applicable.)
Skip NU5048 warning during compilation

Tests

Is this covered by existing tests or new ones? If no, why not?
Yes, it was tested manually and in a pipeline

Feature Plan

Are there any remaining steps or dependencies before this issue can be fully resolved? If so, describe and link to any relevant pull requests or issues.
This solution is the short-term workaround, however, the long-term approach will be to follow the Dotnet SDK specifying PackageIcon and PackageIconUrl to maintain backward compatibility.

Checklist

General

  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated the appropriate tests
  • I have updated related documentation

@pr-triage pr-triage bot added the PR: draft label Oct 20, 2020
@Batta32 Batta32 marked this pull request as ready for review October 20, 2020 20:36
@lzc850612 lzc850612 merged commit 4d23f88 into microsoft:master Oct 29, 2020
@Batta32 Batta32 deleted the feature/southworks/bot-solutions/skip-warning branch June 2, 2021 22:17
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[C#][Bot-Solutions] Error NU5048: The 'PackageIconUrl'/'iconUrl' element is deprecated
2 participants