This repository has been archived by the owner on Jun 30, 2022. It is now read-only.
[Documentation] Fix ambiguities of TypeScript and C# documentation for manifests #3643
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
auto-assign
bot
requested review from
darrenj,
lauren-mills,
lzc850612,
pavolum,
peterinnesmsft,
ryanisgrig,
sidmore and
taicchoumsft
peterinnesmsft
added
the
Area: Docs
lauren-mills
approved these changes
Sep 1, 2020
| ``` | ||
|
|
||
| > **Note**: `{YOUR_SKILL_URL}` is the endpoint URL where the Skill will receive the messages (e.g. `http://localhost:3979/api/messages`). Also, `{YOUR_SKILL_APPID}` is the `microsoftAppIp` value, the `{YOUR_SKILL_BOTWEBAPP_NAME}` is the `botWebAppName` and the `{YOUR_RESOURCEGROUP_NAME}` is the `resourceGroupName` that you can find in the `appsettings.json` file populated after the deployment of the Skill. |
There was a problem hiding this comment.
Small typo here. Should be 'microsoftAppId'
There was a problem hiding this comment.
Thanks @lauren-mills, we already fixed the typo!
There was a problem hiding this comment.
Nice. I think the Note makes it a lot easier to understand.
There was a problem hiding this comment.
If you deploy to Azure the Skill URL is also the name of the resource from Type "Web App-Bot", should we add this to the note?
bhdzllr
reviewed
Sep 3, 2020
|
Thanks @bhdzllr for the feedback! We already updated the docs with the information you have provided. |
peterinnesmsft
approved these changes
Oct 16, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #3638
Purpose
What is the context of this pull request? Why is it being done?
The documentation TypeScript Update your Skill Manifest, C# Update your Skill Manifest and TypeScript Add your skill to a Virtual Assistant presents ambiguities described in the issue #3638.
Changes
Are there any changes that need to be called out as significant or particularly difficult to grasp? (Include illustrative screenshots for context if applicable.)
publish.ps1exampleTests
Is this covered by existing tests or new ones? If no, why not?
-
Feature Plan
Are there any remaining steps or dependencies before this issue can be fully resolved? If so, describe and link to any relevant pull requests or issues.
-
Checklist
General