This repository has been archived by the owner on Jun 30, 2022. It is now read-only.
[Botskills] Sanitize appSettings properties for all the commands #3604
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
auto-assign
bot
requested review from
darrenj,
lauren-mills,
lzc850612,
pavolum,
peterinnesmsft,
ryanisgrig,
sidmore and
taicchoumsft
lzc850612
approved these changes
Aug 12, 2020
peterinnesmsft
approved these changes
Aug 12, 2020
Batta32
force-pushed
the
feature/southworks/botskills-sanitize-appsettings
branch
from
7809c2f
to
51e8940
Compare
peterinnesmsft
added
PR: reviewed-approved
Language: Typescript
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on PR #3596.
Related to issue #3588.
Purpose
Botskills@1.0.16 doesn't work if there is an appsettings with connected Skill as it's case sensitive now and the casing of those properties were updated in the last version of the tool.
What is the context of this pull request? Why is it being done?
Botskills is running into retrocompatibility issues as the earlier versions was using the property
BotFrameworkSkillswith it properties inside, in uppercase. Now Botskills usesbotFrameworkSkillsin lowercase.Changes
Are there any changes that need to be called out as significant or particularly difficult to grasp? (Include illustrative screenshots for context if applicable.)
We are using the method
sanitizeAppSettingsPropertiesfor every time the AppSettings file is read. This method takes theBotFrameworkSkillsproperty with it properties inside and change them to lowercase.Tests
Is this covered by existing tests or new ones? If no, why not?
We tested it manually and worked as expected. We added a unit test to check the
sanitizeAppSettingsPropertiesmethod.BotFrameworkSkills in uppert case along with its properties
botFrameworkSkills after update using the sanitizeAppSettingsProperties method
Feature Plan
Are there any remaining steps or dependencies before this issue can be fully resolved? If so, describe and link to any relevant pull requests or issues.
-
Checklist
General