This repository has been archived by the owner on Jun 30, 2022. It is now read-only.
[Typescript] Store the locale in the Activity #3411
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
darrenj
approved these changes
May 28, 2020
auto-assign
bot
requested review from
darrenj,
lauren-mills,
lzc850612,
pavolum,
peterinnesmsft,
ryanisgrig,
sidmore and
taicchoumsft
delete-merged-branch
bot
deleted the
feature/southworks/fix-race-condition-issue
branch
3 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #3177
Purpose
What is the context of this pull request? Why is it being done?
Remove i18next dependency, and store and access locales on the
Activityclass.Changes
Are there any changes that need to be called out as significant or particularly difficult to grasp? (Include illustrative screenshots for context if applicable.)
i18nextActivityclassTests
Is this covered by existing tests or new ones? If no, why not?
We tested the race condition issue by connecting a Virtual Assistant Sample with a Skill Sample deployed in
en-usandes-es, and running them at the same timeVirtual Assistant Sample tests
Feature Plan
Are there any remaining steps or dependencies before this issue can be fully resolved? If so, describe and link to any relevant pull requests or issues.
Checklist
General