This repository has been archived by the owner on Jun 30, 2022. It is now read-only.
Implement Sharded version of ProactiveState #3240
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
auto-assign
bot
requested review from
darrenj,
lauren-mills,
lzc850612,
pavolum,
peterinnesmsft,
ryanisgrig and
taicchoumsft
|
I'll take a look. let's hold off on this PR for now as we don't want to get this into 1.0 release |
ryanisgrig
reviewed
Mar 26, 2020
sdk/csharp/tests/microsoft.bot.solutions.tests/Proactive/ProactiveShardedTest.cs
Outdated
Show resolved
Hide resolved
sdk/csharp/tests/microsoft.bot.solutions.tests/Proactive/ProactiveShardedTest.cs
Outdated
Show resolved
Hide resolved
xieofxie
reviewed
Mar 27, 2020
...sharp/libraries/microsoft.bot.solutions/Proactive/Sharded/ProactiveStateMiddlewareSharded.cs
Outdated
Show resolved
Hide resolved
xieofxie
reviewed
Mar 30, 2020
| { | ||
| public static class ProactiveTestConstants | ||
| { | ||
| public const string User1 = "user1"; |
There was a problem hiding this comment.
How about use conversation.User.Id after TestAdapter.CreateConversation?
Or we pass it to the parameter of TestAdapter.CreateConversation.
Currently, we just assume the default value of user parameter is user1.
lzc850612
approved these changes
May 15, 2020
pavolum
approved these changes
Jun 17, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.