Skip to content
This repository has been archived by the owner on Jun 30, 2022. It is now read-only.

[ITSM] update lu, show ticket flow #2300

Merged
merged 2 commits into from
Sep 12, 2019
Merged

[ITSM] update lu, show ticket flow #2300

merged 2 commits into from
Sep 12, 2019

Conversation

xieofxie
Copy link
Contributor

@xieofxie xieofxie commented Sep 5, 2019

Purpose

What is the context of this pull request? Why is it being done?

Close #2295 Close #2296

Changes

Are there any changes that need to be called out as significant or particularly difficult to grasp? (Include illustrative screenshots for context if applicable.)

  • use Phrase list to enrich utterances in lu
  • update ShowTicketDialog to show tickets first, then prompt to set constraints etc.
  • comment ShowConstraintNone, ShowUpdateNone

Issues related to number of result will be resolved in #2298

e0
e1

Tests

Is this covered by existing tests or new ones? If no, why not?

Feature Plan

Are there any remaining steps or dependencies before this issue can be fully resolved? If so, describe and link to any relevant pull requests or issues.

Checklist

General

  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated the appropriate tests
  • I have updated related documentation

Bots

  • I have validated that new and updated responses use appropriate Speak and InputHint properties to ensure a high-quality speech-first experience
  • I have replicated language model changes across the English, French, Italian, German, Spanish, and Chinese .lu files and validated that deployment is successful

Deployment Scripts

  • I have replicated my changes in the Virtual Assistant Template and Sample projects
  • I have replicated my changes in the Skill Template and Sample projects

Hualiang Xie added 2 commits September 5, 2019 18:03
* use Phrase list
* comment ShowConstraintNone, ShowUpdateNone
@KayMKM KayMKM added this to the Vibranium 0.6 Release milestone Sep 6, 2019
@bobokids bobokids modified the milestones: Vibranium 0.6 Release, Vibranium Sep 10, 2019
@xieofxie xieofxie merged commit 11671c1 into next Sep 12, 2019
@delete-merged-branch delete-merged-branch bot deleted the hualxie/itsm_update branch September 12, 2019 11:53
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants