This repository has been archived by the owner on Jun 30, 2022. It is now read-only.
[TypeScript][Skill Sample/Template] Update casing for name property #2275
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
What is the context of this pull request? Why is it being done?
Running a skill with a different culture to
en
, the skill doesn't replace the placeholder of{name}
due to TypeScript is case sensitive.Changes
Are there any changes that need to be called out as significant or particularly difficult to grasp? (Include illustrative screenshots for context if applicable.)
For the
SampleResponses
we updated the casing for the name property:{Name}
->{name}
Tests
Is this covered by existing tests or new ones? If no, why not?
-
Testing Steps
.\templates\Virtual-Assistant-Template\typescript\samples\sample-skill
npm install
es
culturenpm run start
Test
message¿Cómo te llamas?
Hola <PLACEHOLDER_REPLACED>
replacing the placeholder with the correct oneFeature Plan
Are there any remaining steps or dependencies before this issue can be fully resolved? If so, describe and link to any relevant pull requests or issues.
-
Checklist
General
Bots
.lu
files and validated that deployment is successfulDeployment Scripts