Skip to content
This repository has been archived by the owner on Jun 30, 2022. It is now read-only.

[TypeScript][Skill Sample/Template] Update casing for name property #2275

Merged
merged 1 commit into from
Sep 3, 2019

Conversation

Batta32
Copy link
Collaborator

@Batta32 Batta32 commented Sep 3, 2019

Purpose

What is the context of this pull request? Why is it being done?
Running a skill with a different culture to en, the skill doesn't replace the placeholder of {name} due to TypeScript is case sensitive.

Changes

Are there any changes that need to be called out as significant or particularly difficult to grasp? (Include illustrative screenshots for context if applicable.)
For the SampleResponses we updated the casing for the name property:

  • {Name} -> {name}

image

Tests

Is this covered by existing tests or new ones? If no, why not?
-

Testing Steps

  1. Go to .\templates\Virtual-Assistant-Template\typescript\samples\sample-skill
  2. Execute npm install
  3. Deploy a Skill in es culture
  4. Execute npm run start
  5. Run the Sample dialog sending a Test message
  6. Send your name once the Skill has answered with ¿Cómo te llamas?
  7. Check that the Skill is answering Hola <PLACEHOLDER_REPLACED> replacing the placeholder with the correct one

Feature Plan

Are there any remaining steps or dependencies before this issue can be fully resolved? If so, describe and link to any relevant pull requests or issues.
-

Checklist

General

  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated the appropriate tests
  • I have updated related documentation

Bots

  • I have validated that new and updated responses use appropriate Speak and InputHint properties to ensure a high-quality speech-first experience
  • I have replicated language model changes across the English, French, Italian, German, Spanish, and Chinese .lu files and validated that deployment is successful

Deployment Scripts

  • I have replicated my changes in the Virtual Assistant Template and Sample projects
  • I have replicated my changes in the Skill Template and Sample projects

@darrenj darrenj merged commit c2193b9 into master Sep 3, 2019
@delete-merged-branch delete-merged-branch bot deleted the feature/southworks/fix-casing-properties branch September 3, 2019 17:41
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants