Skip to content
This repository has been archived by the owner on Jun 30, 2022. It is now read-only.

Hospitality sample and skill changes #2236

Merged
merged 40 commits into from
Aug 28, 2019
Merged

Hospitality sample and skill changes #2236

merged 40 commits into from
Aug 28, 2019

Conversation

litofish
Copy link
Contributor

Purpose

To make a bunch of small changes to the hospitality sample and skills connected.

Changes

  1. Create Adaptive Cards that work on version 1.0 so they render in Teams
  2. Create Hero Card buttons when suggested actions are not supported, like on Teams.
  3. Have Event, Weather, and News skills populate location state from semantic action.
  4. Customize start card for hospitality.
  5. Make changes to Hospitality skill based on comments from demos.

Checklist

General

  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated the appropriate tests
  • I have updated related documentation

Bots

  • I have validated that new and updated responses use appropriate Speak and InputHint properties to ensure a high-quality speech-first experience
  • I have replicated language model changes across the English, French, Italian, German, Spanish, and Chinese .lu files and validated that deployment is successful

@litofish litofish merged commit dd78bde into next Aug 28, 2019
@delete-merged-branch delete-merged-branch bot deleted the luna/hospitalityVA branch August 28, 2019 19:09
@@ -365,6 +365,101 @@
}
}
]
},
{
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Replace this files contents with just {}
The CLI tools will expect an empty file in order to build dispatch and update the apps - it's not smart enough to recognize that we just need to replace app id and endpoints here.
Documentation should explain the skills that would be added using botskills connect

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made fix in #2241

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants