This repository has been archived by the owner on Jun 30, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 528
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tions into luna/requestitem
…ive card for showing item requests
…mework-solutions into luna/hospitalityVA
…tions into luna/eventskill
…tions into luna/eventskill
…tions into luna/hospitalityVA
…framework-solutions into luna/hospitalityVA
auto-assign
bot
requested review from
darrenj,
lauren-mills,
lzc850612 and
ryanisgrig
August 27, 2019 22:03
ryanisgrig
approved these changes
Aug 28, 2019
lauren-mills
approved these changes
Aug 28, 2019
ryanisgrig
reviewed
Aug 28, 2019
@@ -365,6 +365,101 @@ | |||
} | |||
} | |||
] | |||
}, | |||
{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Replace this files contents with just {}
The CLI tools will expect an empty file in order to build dispatch and update the apps - it's not smart enough to recognize that we just need to replace app id and endpoints here.
Documentation should explain the skills that would be added using botskills connect
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Made fix in #2241
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
To make a bunch of small changes to the hospitality sample and skills connected.
Changes
Checklist
General
Bots
.lu
files and validated that deployment is successful