Skip to content
This repository has been archived by the owner on Jun 30, 2022. It is now read-only.

[Botskills] Add msaAppId property to skillManifest model #2187

Merged
merged 2 commits into from
Aug 28, 2019

Conversation

Batta32
Copy link
Collaborator

@Batta32 Batta32 commented Aug 22, 2019

Cherry pick of #1983 to master

Purpose

What is the context of this pull request? Why is it being done?

When making the connection between the VA and the Skill, we realized that a property from the manifest was missing.

Changes

Are there any changes that need to be called out as significant or particularly difficult to grasp? (Include illustrative screenshots for context if applicable.)

  • Add the msaAppId property to Botskills CLI skillManifest model
  • Fix broken tests

Testing Steps

  1. Go to .\tools\botskills.
  2. Open a terminal in that location.
  3. Execute npm link to install the library locally.
  4. Go to .\templates\Virtual-Assistant-Template\typescript\samples\sample-assistant\ and .\templates\Virtual-Assistant-Template\typescript\samples\sample-skill\.
  5. Open a terminal in both location.
  6. Connect the sample-assistant with the sample-skill.
  7. Execute npm install to install dependencies.
  8. Execute npm run build to build the project.
  9. Execute npm run start to start the bots.

Feature Plan

Are there any remaining steps or dependencies before this issue can be fully resolved? If so, describe and link to any relevant pull requests or issues.

This property is the one that was added to botskills in the SkillManifest so that you can make the connection between the Skill and the Virtual Assistant.

@lauren-mills lauren-mills merged commit 8b15cf2 into master Aug 28, 2019
@delete-merged-branch delete-merged-branch bot deleted the feature/southworks/botskills/add-msaAppId branch August 28, 2019 19:46
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants