This repository has been archived by the owner on Jun 30, 2022. It is now read-only.
[Botskills] Update the output format for az commands #2186
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
What is the context of this pull request? Why is it being done?
Solve the issue that the user had when the
az cli
default output is set to a different format to json, the connect command fails on theaz commands
during the authentication process.Fix #2107
Changes
Are there any changes that need to be called out as significant or particularly difficult to grasp? (Include illustrative screenshots for context if applicable.)
Add the argument
--output json
for some commands like:az bot authsetting list
az bot authsetting show
az bot authsetting delete
az bot authsetting create
az ad app show
az ad app update
Tests
Is this covered by existing tests or new ones? If no, why not?
Yes, we updated
authentication
testsTesting Steps
az configure
to set the output to a different format to json following this steps..\tools\botskills
npm install
to install the dependencies.Virtual Assistant
andSkill
withauthentication connections
Feature Plan
Are there any remaining steps or dependencies before this issue can be fully resolved? If so, describe and link to any relevant pull requests or issues.
-
Checklist
General
Bots
.lu
files and validated that deployment is successfulDeployment Scripts