Skip to content
This repository has been archived by the owner on Jun 30, 2022. It is now read-only.

[Botskills] Update the output format for az commands #2186

Merged

Conversation

Batta32
Copy link
Collaborator

@Batta32 Batta32 commented Aug 22, 2019

Purpose

What is the context of this pull request? Why is it being done?
Solve the issue that the user had when the az cli default output is set to a different format to json, the connect command fails on the az commands during the authentication process.

Fix #2107

Changes

Are there any changes that need to be called out as significant or particularly difficult to grasp? (Include illustrative screenshots for context if applicable.)

Add the argument --output json for some commands like:

  • az bot authsetting list
  • az bot authsetting show
  • az bot authsetting delete
  • az bot authsetting create
  • az ad app show
  • az ad app update

image

Tests

Is this covered by existing tests or new ones? If no, why not?
Yes, we updated authentication tests

Testing Steps

  1. Execute az configure to set the output to a different format to json following this steps.
  2. Open a terminal in .\tools\botskills
  3. Execute npm install to install the dependencies.
  4. Execute `npm run build
  5. Connect a Virtual Assistant and Skill with authentication connections
  6. Verify that the authentication process finished successfully

Feature Plan

Are there any remaining steps or dependencies before this issue can be fully resolved? If so, describe and link to any relevant pull requests or issues.
-

Checklist

General

  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated the appropriate tests
  • I have updated related documentation

Bots

  • I have validated that new and updated responses use appropriate Speak and InputHint properties to ensure a high-quality speech-first experience
  • I have replicated language model changes across the English, French, Italian, German, Spanish, and Chinese .lu files and validated that deployment is successful

Deployment Scripts

  • I have replicated my changes in the Virtual Assistant Template and Sample projects
  • I have replicated my changes in the Skill Template and Sample projects

@lauren-mills lauren-mills merged commit 0d71c97 into master Aug 28, 2019
@delete-merged-branch delete-merged-branch bot deleted the feature/southworks/cli/botskills/update-az-commands branch August 28, 2019 18:05
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[botskills] az output type "table" breaks auth configuration steps
5 participants