Skip to content
This repository has been archived by the owner on Jun 30, 2022. It is now read-only.

[POI] fix localization issue #2115

Merged
merged 1 commit into from
Aug 19, 2019
Merged

[POI] fix localization issue #2115

merged 1 commit into from
Aug 19, 2019

Conversation

xieofxie
Copy link
Contributor

Purpose

What is the context of this pull request? Why is it being done?

Close #2114

Changes

Are there any changes that need to be called out as significant or particularly difficult to grasp? (Include illustrative screenshots for context if applicable.)

  • Use PointOfInterestSharedStrings.CARD_TITLE for CardTitle
  • Remove unused codes in skill template

Tests

Is this covered by existing tests or new ones? If no, why not?

Feature Plan

Are there any remaining steps or dependencies before this issue can be fully resolved? If so, describe and link to any relevant pull requests or issues.

Checklist

General

  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated the appropriate tests
  • I have updated related documentation

Bots

  • I have validated that new and updated responses use appropriate Speak and InputHint properties to ensure a high-quality speech-first experience
  • I have replicated language model changes across the English, French, Italian, German, Spanish, and Chinese .lu files and validated that deployment is successful

Deployment Scripts

  • I have replicated my changes in the Virtual Assistant Template and Sample projects
  • I have replicated my changes in the Skill Template and Sample projects

@bobokids bobokids merged commit 747fec4 into microsoft:next Aug 19, 2019
@xieofxie xieofxie deleted the fixes branch August 19, 2019 06:16
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants