Skip to content
This repository has been archived by the owner on Jun 30, 2022. It is now read-only.

update GeographyV2 (#1995) #1996

Merged
merged 1 commit into from
Aug 1, 2019
Merged

update GeographyV2 (#1995) #1996

merged 1 commit into from
Aug 1, 2019

Conversation

xieofxie
Copy link
Contributor

Purpose

What is the context of this pull request? Why is it being done?

Close #1995

Changes

Are there any changes that need to be called out as significant or particularly difficult to grasp? (Include illustrative screenshots for context if applicable.)

Change string[] geographyV2_* to GeographyV2[] geographyV2.

Tests

Is this covered by existing tests or new ones? If no, why not?

Yes.

Feature Plan

Are there any remaining steps or dependencies before this issue can be fully resolved? If so, describe and link to any relevant pull requests or issues.

Checklist

General

  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated the appropriate tests
  • I have updated related documentation

Bots

  • I have validated that new and updated responses use appropriate Speak and InputHint properties to ensure a high-quality speech-first experience
  • I have replicated language model changes across the English, French, Italian, German, Spanish, and Chinese .lu files and validated that deployment is successful

Deployment Scripts

  • I have replicated my changes in the Virtual Assistant Template and Sample projects
  • I have replicated my changes in the Skill Template and Sample projects

@ryanisgrig
Copy link
Collaborator

Can you PR against the next branch?

@darrenj darrenj changed the base branch from master to next July 31, 2019 18:36
@xieofxie
Copy link
Contributor Author

xieofxie commented Aug 1, 2019

OK, changed

Copy link
Contributor

@lauren-mills lauren-mills left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to make an issue to track the needed luisgen change we need before we include this in the next release. Otherwise, the skills will break if anyone runs the update_cognitive_models script.

Looks like this PR on botbuilder-tools should have added this functionality: microsoft/botbuilder-tools#1190

@ryanisgrig ryanisgrig merged commit 0c3aa86 into microsoft:next Aug 1, 2019
@xieofxie xieofxie deleted the geography branch August 2, 2019 02:19
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants