Skip to content
This repository has been archived by the owner on Jun 30, 2022. It is now read-only.

Various release fixes (update script, capitalization) #1967

Merged
merged 8 commits into from
Jul 26, 2019

Conversation

lauren-mills
Copy link
Contributor

@lauren-mills lauren-mills commented Jul 26, 2019

Purpose

What is the context of this pull request? Why is it being done?

Changes

Are there any changes that need to be called out as significant or particularly difficult to grasp? (Include illustrative screenshots for context if applicable.)

  • Changed capitalization throughout va template and sample
  • Added luisgen call to all update cognitive models files
  • Fixed package reference in skill template tests project

Tests

Is this covered by existing tests or new ones? If no, why not?

Feature Plan

Are there any remaining steps or dependencies before this issue can be fully resolved? If so, describe and link to any relevant pull requests or issues.

Checklist

General

  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated the appropriate tests
  • I have updated related documentation

Bots

  • I have validated that new and updated responses use appropriate Speak and InputHint properties to ensure a high-quality speech-first experience
  • I have replicated language model changes across the English, French, Italian, German, Spanish, and Chinese .lu files and validated that deployment is successful

Deployment Scripts

  • I have replicated my changes in the Virtual Assistant Template and Sample projects
  • I have replicated my changes in the Skill Template and Sample projects

@lauren-mills lauren-mills changed the title Various release fixes (update script, capitalization) [Do Not Merge] Various release fixes (update script, capitalization) Jul 26, 2019
@lauren-mills lauren-mills changed the title [Do Not Merge] Various release fixes (update script, capitalization) Various release fixes (update script, capitalization) Jul 26, 2019
@lauren-mills lauren-mills merged commit bf53c3b into master Jul 26, 2019
@delete-merged-branch delete-merged-branch bot deleted the lamil/release_fixes2 branch July 26, 2019 21:47
lzc850612 pushed a commit that referenced this pull request Jul 31, 2019
* removed lowercase resource files

* added uppercase resource files

* updated capitalization in va template

* updated skill test proj bot.builder version

* updated update_cog_models script to include luisgen

* updated lu files

* updated va and skills samples/templates

* updated skills package versions
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants