Skip to content
This repository has been archived by the owner on Jun 30, 2022. It is now read-only.

[Botskills] Handle the version of Azure CLI during the execution of the tool #1965

Merged
merged 3 commits into from
Jul 29, 2019

Conversation

Batta32
Copy link
Collaborator

@Batta32 Batta32 commented Jul 26, 2019

Close #1863

Purpose

What is the context of this pull request? Why is it being done?
Using an az version greater than 2.0.67, the authentication process throws an error in the botskills cli tool

Changes

Are there any changes that need to be called out as significant or particularly difficult to grasp? (Include illustrative screenshots for context if applicable.)

  • Add a warning validating the az version of the user
  • Update Prerequisites section
  • Update authentication tests

Tests

Is this covered by existing tests or new ones? If no, why not?
Yes, we updated authentication test

Feature Plan

Are there any remaining steps or dependencies before this issue can be fully resolved? If so, describe and link to any relevant pull requests or issues.
We will take into account the az releases with the preview tag in internal commands.

Checklist

General

  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated the appropriate tests
  • I have updated related documentation

Bots

  • I have validated that new and updated responses use appropriate Speak and InputHint properties to ensure a high-quality speech-first experience
  • I have replicated language model changes across the English, French, Italian, German, Spanish, and Chinese .lu files and validated that deployment is successful

Deployment Scripts

  • I have replicated my changes in the Virtual Assistant Template and Sample projects
  • I have replicated my changes in the Skill Template and Sample projects

@lauren-mills lauren-mills merged commit 86889ef into master Jul 29, 2019
@delete-merged-branch delete-merged-branch bot deleted the feature/southworks/cli/fix-version branch July 29, 2019 21:10
lzc850612 pushed a commit that referenced this pull request Jul 31, 2019
…he tool (#1965)

* Add az installation for botskill prerequisites

* Add warning and validation for user az version (preview issue)

* Fix authentication tests
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Botskill CLI] botskill connect fails for released version 2.0.67 of Azure CLI
3 participants