-
Notifications
You must be signed in to change notification settings - Fork 528
Use consistent header name for authorization header #1948
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @henryjenkins, thanks for contributing!
This change looks good, however, we discussed with the SDK Team and they are removing the @azure/ms-rest-js
dependency from the SDK, as this library is causing some issues. Here you can see the ongoing work:
- [Botbuilder-AI] Remove @azure-ms-rest dependency botbuilder-js#1071
- [BF-Connector] Remove @azure/ms-rest-js dependency botbuilder-js#1072
Because of this, we are planning to remove this dependency as soon as they finish doing so in the SDK.
If you take a look at the botFrameworkAdapter
class, which the skillHttpAdapter
inherits from, this problem is solved doing this:
const authHeader: string = req.headers.authorization || req.headers.Authorization || '';
In this way, both lower case and upper case are being considered, so the best approach would be to replicate the botFrameworkAdapter
implementation.
Hi @dfavretto - thanks for the quick feedback. |
* Added doc on skill responses (#2019) * added doc on skill responses * Update responses.md * correct link and move to aka.ms (#2015) * Use consistent header name for authorization header (#1948) * Use consistent header name for authorization header * Remove dependency on @azure/ms-rest-js * chery pick fix for bug fix (#2038) * Updated templates to apply bot service tag (#2039) * change exising to existing (#2043) * Change sample from Skills to Virtual Assistant (#2066) * [TypeScript][Template/Sample] Migrate latest functionalities (#1943) * Update assistant template * Update skill template * Update sample assistant * Update sample skill * Fix some issues * Fix connected Skill not waiting for response * Rename msAppId for consistency with C# * Add special character notification (#2033) * Cherry pick Power BI sample for next branch (#2048) * change tabs to spaces so markdown renders correctly (#2100) the original text uses tabs which do not render as a markdown list in Github. Changing these to spaces renders as a list and is more readable * [TypeScript][BotBuilder Libs] Update SDK dependencies versions (#2085) * Update SDK dependencies versions * Rename property msAppId to msaAppId (#2000) * [TypeScript][DevOps] Update deployment scripts and migrate new ARM templates (#1982) * Update Skill and Assistant templates * Update Sample Assistant * Update Sample Skill * Update README.md * Added new GitHub Pages docs site (#2071) * added jekyll files * docs updates * updates * updates * site updates * removed sample docs site * updated docs * moved docs * updated deploy docs * fixed broken links * update * updates * fixed merge conflicts and updated readme * Update _howto.md * Update _reference.md * updated known issues * updated telemetry links * updated to do name * fixed broken image links * Updated gitignore to allow docs site packages (#2126) * added jekyll files * docs updates * updates * updates * site updates * removed sample docs site * updated docs * moved docs * updated deploy docs * fixed broken links * update * updates * fixed merge conflicts and updated readme * Update _howto.md * Update _reference.md * updated known issues * updated telemetry links * updated to do name * fixed broken image links * Updated gitignore for docs packages * Update README.md * Update bug_report.md * Update feature_request.md * [TypeScript][Samples/Template] Add UTF8 default encoding for deployment scripts (#2130) * Add UTF-8 * change from uppercase to lowercase * changes a lowcase and add 'enconding utf8' to sample assistant * Move the location of the encoding argument * Update deploymentscripts.md * Update experimental.md (#2146) Add music skill documentation * [TypeScript][Generator] Update the replacement of template's files (#2111) * Update replacement of template's files * Apply feedback * remove event triggering for action from documentation (#2150) * initial version of event companion app (#2156) * Update _config.yml * Update header.html * Update default.html * Update default.html * Update productivity-calendar.md * Update 4_provision_your_azure_resources.md * Update 4_provision_your_azure_resources.md * Update 4_provision_your_azure_resources.md * Update 4_provision_your_azure_resources.md * Update 4_provision_your_azure_resources.md * Update experimental.md * Update ettovamigration.md * Update testing.md * Update botskills.md * Update productivity-email.md * Update addingskills.md * Update 1_intro.md * Update 1_intro.md * Update 1_intro.md * Update 1_intro.md * Update testing.md * Update automotive.md * Update 1_intro.md * Update 1_intro.md * Update skillenablingav4bot.md * Update productivity-todo.md * Update 4_provision_your_azure_resources.md * Update 4_provision_your_azure_resources.md * Update 4_provision_your_azure_resources.md * Update 4_provision_your_azure_resources.md * Create managemodels.md * Add files via upload * Update issue templates * Update footer.html * Update footer.html * Update footer.html
…2258) * Added doc on skill responses (#2019) * added doc on skill responses * Update responses.md * correct link and move to aka.ms (#2015) * Use consistent header name for authorization header (#1948) * Use consistent header name for authorization header * Remove dependency on @azure/ms-rest-js * chery pick fix for bug fix (#2038) * Updated templates to apply bot service tag (#2039) * change exising to existing (#2043) * Change sample from Skills to Virtual Assistant (#2066) * [TypeScript][Template/Sample] Migrate latest functionalities (#1943) * Update assistant template * Update skill template * Update sample assistant * Update sample skill * Fix some issues * Fix connected Skill not waiting for response * Rename msAppId for consistency with C# * Add special character notification (#2033) * Cherry pick Power BI sample for next branch (#2048) * change tabs to spaces so markdown renders correctly (#2100) the original text uses tabs which do not render as a markdown list in Github. Changing these to spaces renders as a list and is more readable * [TypeScript][BotBuilder Libs] Update SDK dependencies versions (#2085) * Update SDK dependencies versions * Rename property msAppId to msaAppId (#2000) * [TypeScript][DevOps] Update deployment scripts and migrate new ARM templates (#1982) * Update Skill and Assistant templates * Update Sample Assistant * Update Sample Skill * Update README.md * Added new GitHub Pages docs site (#2071) * added jekyll files * docs updates * updates * updates * site updates * removed sample docs site * updated docs * moved docs * updated deploy docs * fixed broken links * update * updates * fixed merge conflicts and updated readme * Update _howto.md * Update _reference.md * updated known issues * updated telemetry links * updated to do name * fixed broken image links * Updated gitignore to allow docs site packages (#2126) * added jekyll files * docs updates * updates * updates * site updates * removed sample docs site * updated docs * moved docs * updated deploy docs * fixed broken links * update * updates * fixed merge conflicts and updated readme * Update _howto.md * Update _reference.md * updated known issues * updated telemetry links * updated to do name * fixed broken image links * Updated gitignore for docs packages * Update README.md * Update bug_report.md * Update feature_request.md * [TypeScript][Samples/Template] Add UTF8 default encoding for deployment scripts (#2130) * Add UTF-8 * change from uppercase to lowercase * changes a lowcase and add 'enconding utf8' to sample assistant * Move the location of the encoding argument * Update deploymentscripts.md * Update experimental.md (#2146) Add music skill documentation * [TypeScript][Generator] Update the replacement of template's files (#2111) * Update replacement of template's files * Apply feedback * remove event triggering for action from documentation (#2150) * initial version of event companion app (#2156) * Update _config.yml * Update header.html * Update default.html * Update default.html * Update productivity-calendar.md * Update 4_provision_your_azure_resources.md * Update 4_provision_your_azure_resources.md * Update 4_provision_your_azure_resources.md * Update 4_provision_your_azure_resources.md * Update 4_provision_your_azure_resources.md * Update experimental.md * Update ettovamigration.md * Update testing.md * Update botskills.md * Update productivity-email.md * Update addingskills.md * Update 1_intro.md * Update 1_intro.md * Update 1_intro.md * Update 1_intro.md * Update testing.md * Update automotive.md * Update 1_intro.md * Update 1_intro.md * Update skillenablingav4bot.md * Update productivity-todo.md * Update 4_provision_your_azure_resources.md * Update 4_provision_your_azure_resources.md * Update 4_provision_your_azure_resources.md * Update 4_provision_your_azure_resources.md * Create managemodels.md * Add files via upload * Update issue templates * Update footer.html * Update footer.html * Update footer.html * Incorporate Virtual Assistant Client (Android) docs FIx some references to DLS channel * Updated prereq * Update toc.yml to reference Sample submenus * Add Enterprise Notifications documentation
* Move to new samples format: analytics assistants clients (split by language) utilities * [Script] cognitive model args should be camelCased (#2141) * update skill script case * fix template * update template for naming and DialogState (#2168) * Add FeedbackMiddleware to Solutions lib (#2226) * Adding feedback middleware and classes to solutions lib * Add localization * stylecop * updated middleware to log more consistent values * added feedback documentation * Added pbit with feedback dashboard * Update feedback.md * [C#][DevOps] Spike for CD in Virtual Assistant Sample (#2210) * Update YAML files * Add documentation and images * [TypeScript][BotBuilder-Skills] Use Handoff Activity to manage the signal completion of skill dialog (#2253) * Update EndOfConversation to HandOff type once skill completes the dialog * Get the HandOff activity once the skill dialog has finished * Update the remaining EndOfConversation in MainDialog * [Docs] Enterprise Notifications & Virtual Assistant Client (Android) (#2258) * Added doc on skill responses (#2019) * added doc on skill responses * Update responses.md * correct link and move to aka.ms (#2015) * Use consistent header name for authorization header (#1948) * Use consistent header name for authorization header * Remove dependency on @azure/ms-rest-js * chery pick fix for bug fix (#2038) * Updated templates to apply bot service tag (#2039) * change exising to existing (#2043) * Change sample from Skills to Virtual Assistant (#2066) * [TypeScript][Template/Sample] Migrate latest functionalities (#1943) * Update assistant template * Update skill template * Update sample assistant * Update sample skill * Fix some issues * Fix connected Skill not waiting for response * Rename msAppId for consistency with C# * Add special character notification (#2033) * Cherry pick Power BI sample for next branch (#2048) * change tabs to spaces so markdown renders correctly (#2100) the original text uses tabs which do not render as a markdown list in Github. Changing these to spaces renders as a list and is more readable * [TypeScript][BotBuilder Libs] Update SDK dependencies versions (#2085) * Update SDK dependencies versions * Rename property msAppId to msaAppId (#2000) * [TypeScript][DevOps] Update deployment scripts and migrate new ARM templates (#1982) * Update Skill and Assistant templates * Update Sample Assistant * Update Sample Skill * Update README.md * Added new GitHub Pages docs site (#2071) * added jekyll files * docs updates * updates * updates * site updates * removed sample docs site * updated docs * moved docs * updated deploy docs * fixed broken links * update * updates * fixed merge conflicts and updated readme * Update _howto.md * Update _reference.md * updated known issues * updated telemetry links * updated to do name * fixed broken image links * Updated gitignore to allow docs site packages (#2126) * added jekyll files * docs updates * updates * updates * site updates * removed sample docs site * updated docs * moved docs * updated deploy docs * fixed broken links * update * updates * fixed merge conflicts and updated readme * Update _howto.md * Update _reference.md * updated known issues * updated telemetry links * updated to do name * fixed broken image links * Updated gitignore for docs packages * Update README.md * Update bug_report.md * Update feature_request.md * [TypeScript][Samples/Template] Add UTF8 default encoding for deployment scripts (#2130) * Add UTF-8 * change from uppercase to lowercase * changes a lowcase and add 'enconding utf8' to sample assistant * Move the location of the encoding argument * Update deploymentscripts.md * Update experimental.md (#2146) Add music skill documentation * [TypeScript][Generator] Update the replacement of template's files (#2111) * Update replacement of template's files * Apply feedback * remove event triggering for action from documentation (#2150) * initial version of event companion app (#2156) * Update _config.yml * Update header.html * Update default.html * Update default.html * Update productivity-calendar.md * Update 4_provision_your_azure_resources.md * Update 4_provision_your_azure_resources.md * Update 4_provision_your_azure_resources.md * Update 4_provision_your_azure_resources.md * Update 4_provision_your_azure_resources.md * Update experimental.md * Update ettovamigration.md * Update testing.md * Update botskills.md * Update productivity-email.md * Update addingskills.md * Update 1_intro.md * Update 1_intro.md * Update 1_intro.md * Update 1_intro.md * Update testing.md * Update automotive.md * Update 1_intro.md * Update 1_intro.md * Update skillenablingav4bot.md * Update productivity-todo.md * Update 4_provision_your_azure_resources.md * Update 4_provision_your_azure_resources.md * Update 4_provision_your_azure_resources.md * Update 4_provision_your_azure_resources.md * Create managemodels.md * Add files via upload * Update issue templates * Update footer.html * Update footer.html * Update footer.html * Incorporate Virtual Assistant Client (Android) docs FIx some references to DLS channel * Updated prereq * Update toc.yml to reference Sample submenus * Add Enterprise Notifications documentation * use Handoff instead of EndOfConversation for SkillTemplate (#2257) * [Calendar] calendar refactoring part 2 (#2185) * refactor summary dialog and connect to meeting dialog * rename summary dialog and connect to meeting dialog * add try catch for steps * add join event test cases * refactor update and change statuts dialog * refactor create event dialog * rename some steps * add paging in choose event logic * fix test * fix get event logic * clean code and fix find event logic in update * update ut * clean code and add some test cases * add valid check in join dialog * move first find contact state * [Docs] Update hospitality related docs (#2256) * Add room service dialog files * Add room service luis model * Complete most of room service dialog * update menu card * improve luis model * final changes * Move requested item availability check to hotel service and add adaptive card for showing item requests * update manifest * Adding updated hospitality skill * small changes to sample * restaurant booking fixes * weather skill .lu file update * Update skill manifests * skills updates * Add files for event skill from skill template * remove other languages * Add files for basic find events dialog * Add Eventbrite service to get event information * Update Luis model and create adaptive card for events * Implement populating location state from semantic action * fix bugs * Add event skill to sample * room service dialog bug fix * for event, news, and weather skills populate location state from semantic action * customize VA start card * Add available items and room service menu item * Hospitality skill available items updates * Sample small updates and add Bing Search skill * Support adaptive cards being used in Teams for Hospitality and Event skills * fixes for better funcitonality in Teams * Update experimental.md docs with event and hospitality skills * Update hospitality related docs * Revert visual studio version * update sample description * fix to using {{site.repo}} * move hospitalitysample.md into reference/samples and update links * Update readme.md * Update readme.md * [POI] add details card with actions, remove cancel & events, redsign flows (#2250) * [POI] add details card with actions, remove cancel & events, redsign flows * Events.ActiveLocation and Events.ActiveRoute are removed * RouteDialog is a sub routine now * Add GetDirectionsDialog * "size": "stretch" is added to jsons * Update tests * Add tests GetDirections(ToNearest)Test, RouteToPointOfInterestThen(Call/StartNavigation)Test * [POI] no Phone, no Call; remove some messages; add start to route * Use a confirm prompt for detecting start (no is preserved) * Update tests to check attachments * Remove "size":"stretch" on images * [POI] fix displayin teams * update lib (#2283) * Add IT Service Management skill (#2078) * add itsm skill with create ticket action * [ITSM] add update ticket action * [ITSM] add show ticket action * [ITSM] add close ticket action * [ITSM] add show knowledge action * [ITSM] update update ticket action redesign AttributePrompt & enum to string * [ITSM] add next/prev * add class GeneralPrompt for next/prev navigation * add next/prev to show knowledge base and ticket * show knowledge invoke create ticket if required * replace wrong EndDialogAsync to CancelAllDialogsAsync * [ITSM] update for IWhitelistAuthenticationProvider, manifestTemplate, docs * [ITSM] add top login prompt, additional sources, TicketState * additional sources should be removed when published * add TicketState list entity and related updates * [ITSM] use ticket number instead of id * add TicketNumber entity * add TicketNumberPrompt * update card jsons * update routines of UpdateTicketDialog & CloseTicketDialog * [ITSM] add url and number to knowledge base * [ITSM] separate SimpleWhitelistAuthenticationProvider, add License statement * [ITSM] update json and doc * [ITSM] update GUID * [ITSM] change to handoff as others * Remove callerId in Auth flow as callerId shouldn't be transferred over the wire (#2291) * remove callerId setting and verification * update comment * Move to new samples format: analytics assistants clients (split by language) utilities * Move latest power bi templatet to samples Update hospitality assistant readme
Purpose
Close #1947: Use the same capitalisation for authorization header to ensure that the VA can talk to an authenticated TypeScript skill