Skip to content
This repository has been archived by the owner on Jun 30, 2022. It is now read-only.

[TypeScript][BotBuilder Solutions] Use of pathToResource property in AuthenticationResponses #1939

Conversation

Batta32
Copy link
Collaborator

@Batta32 Batta32 commented Jul 24, 2019

Fix #1932

Purpose

What is the context of this pull request? Why is it being done?
Having an authentication connection (between Skill and Virtual Assistant), an error occurred that indicates that the AuthenticationResponses resources were not find.

Changes

Are there any changes that need to be called out as significant or particularly difficult to grasp? (Include illustrative screenshots for context if applicable.)

  • Allow to the AuthenticationResponses to use pathToResource, and get the respectively responses.

Tests

Is this covered by existing tests or new ones? If no, why not?
-

Feature Plan

Are there any remaining steps or dependencies before this issue can be fully resolved? If so, describe and link to any relevant pull requests or issues.
-

Checklist

General

  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated the appropriate tests
  • I have updated related documentation

Bots

  • I have validated that new and updated responses use appropriate Speak and InputHint properties to ensure a high-quality speech-first experience
  • I have replicated language model changes across the English, French, Italian, German, Spanish, and Chinese .lu files and validated that deployment is successful

Deployment Scripts

  • I have replicated my changes in the Virtual Assistant Template and Sample projects
  • I have replicated my changes in the Skill Template and Sample projects

@lauren-mills lauren-mills merged commit 4253ffd into master Jul 29, 2019
@delete-merged-branch delete-merged-branch bot deleted the feature/southworks/botbuilder-solutions/fix-pathtoresource branch July 29, 2019 18:37
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to find 'AuthenticationResponses' in '...\bot\node_modules\botbuilder-solutions\lib\resources'
4 participants