Skip to content
This repository has been archived by the owner on Jun 30, 2022. It is now read-only.

use ShortTimePattern instead of hardcoded ones #1898

Merged
merged 1 commit into from
Jul 22, 2019

Conversation

xieofxie
Copy link
Contributor

Purpose

What is the context of this pull request? Why is it being done?

Close #1728

Closed issues are good issues.

Changes

Are there any changes that need to be called out as significant or particularly difficult to grasp? (Include illustrative screenshots for context if applicable.)

Use ShortTimePattern of related CultureInfo instead of hardcoded ones.

Tests

Is this covered by existing tests or new ones? If no, why not?

Tested on related 'Regional format' in Settings -> Time & Language -> Region

Feature Plan

Are there any remaining steps or dependencies before this issue can be fully resolved? If so, describe and link to any relevant pull requests or issues.

Checklist

General

  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated the appropriate tests
  • I have updated related documentation

Bots

  • I have validated that new and updated responses use appropriate Speak and InputHint properties to ensure a high-quality speech-first experience
  • I have replicated language model changes across the English, French, Italian, German, Spanish, and Chinese .lu files and validated that deployment is successful

Deployment Scripts

  • I have replicated my changes in the Virtual Assistant Template and Sample projects
  • I have replicated my changes in the Skill Template and Sample projects

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DateTimeExTests depends on local time formats
5 participants