Skip to content
This repository has been archived by the owner on Jun 30, 2022. It is now read-only.

Skills - Updated to sdk 4.5.1 #1859

Merged
merged 7 commits into from
Jul 18, 2019
Merged

Skills - Updated to sdk 4.5.1 #1859

merged 7 commits into from
Jul 18, 2019

Conversation

lauren-mills
Copy link
Contributor

Adds to #1856

Purpose

What is the context of this pull request? Why is it being done?

Changes

Are there any changes that need to be called out as significant or particularly difficult to grasp? (Include illustrative screenshots for context if applicable.)

Tests

Is this covered by existing tests or new ones? If no, why not?

Feature Plan

Are there any remaining steps or dependencies before this issue can be fully resolved? If so, describe and link to any relevant pull requests or issues.

Checklist

General

  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated the appropriate tests
  • I have updated related documentation

Bots

  • I have validated that new and updated responses use appropriate Speak and InputHint properties to ensure a high-quality speech-first experience
  • I have replicated language model changes across the English, French, Italian, German, Spanish, and Chinese .lu files and validated that deployment is successful

Deployment Scripts

  • I have replicated my changes in the Virtual Assistant Template and Sample projects
  • I have replicated my changes in the Skill Template and Sample projects

@lauren-mills lauren-mills added the Status: Blocked Current progress is blocked label Jul 16, 2019
@lauren-mills lauren-mills marked this pull request as ready for review July 18, 2019 17:20
@lauren-mills lauren-mills changed the title Skills - Updated to sdk 4.5.0 Skills - Updated to sdk 4.5.1 Jul 18, 2019
@lauren-mills lauren-mills merged commit 28c083e into master Jul 18, 2019
@pr-triage pr-triage bot added the merged label Jul 18, 2019
@delete-merged-branch delete-merged-branch bot deleted the lamil/skills_sdk_updates branch July 18, 2019 20:12
lzc850612 pushed a commit that referenced this pull request Jul 31, 2019
* updated skills to sdk 4.5.0

* updated to lib 4.5.0

* updated to sdk 4.5.1

* updated to lib 4.5.1

* Update CalendarBotTestBase.cs

* Update CalendarBotTestBase.cs
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants