Skip to content
This repository has been archived by the owner on Jun 30, 2022. It is now read-only.

Skill template bug fixes #1855

Merged
merged 3 commits into from
Jul 16, 2019
Merged

Skill template bug fixes #1855

merged 3 commits into from
Jul 16, 2019

Conversation

lauren-mills
Copy link
Contributor

@lauren-mills lauren-mills commented Jul 15, 2019

Closes #1602

Purpose

What is the context of this pull request? Why is it being done?

  • Fixes skill template bugs found in hackathon

Changes

Are there any changes that need to be called out as significant or particularly difficult to grasp? (Include illustrative screenshots for context if applicable.)

  • fixes broken state caused by "internal set"
  • fixes syntax issues with commented auth code

Tests

Is this covered by existing tests or new ones? If no, why not?

Feature Plan

Are there any remaining steps or dependencies before this issue can be fully resolved? If so, describe and link to any relevant pull requests or issues.

Checklist

Deployment Scripts

  • I have replicated my changes in the Skill Template and Sample projects

@lauren-mills lauren-mills merged commit d794d2c into master Jul 16, 2019
@delete-merged-branch delete-merged-branch bot deleted the lamil/skill_template_update branch July 16, 2019 17:50
lzc850612 pushed a commit that referenced this pull request Jul 31, 2019
* removed internal set from skill state

* fixed auth syntax issues when uncommented

* updated template with changes
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Skill Template Bugs
4 participants