Skip to content
This repository has been archived by the owner on Jun 30, 2022. It is now read-only.

Add SetSpeakMiddleware to apply an SSML-formatted voice font to bots Activity.Speak properties #1462

Merged
merged 3 commits into from
Jun 1, 2019
Merged

Add SetSpeakMiddleware to apply an SSML-formatted voice font to bots Activity.Speak properties #1462

merged 3 commits into from
Jun 1, 2019

Conversation

ryanisgrig
Copy link
Collaborator

@ryanisgrig ryanisgrig commented May 31, 2019 •
edited
Loading

Description

Conversational Experience

Middleware updates speak property to use SSML tags with a voice font
#ssml

Testing Steps

Validate with Direct Line Speech client

Checklist

  • I have commented my code, particularly in hard-to-understand areas
  • I have tested any new/updated dialogs using Speech in the emulator to ensure the Speak property is set to enable a high quality speech-first experience and the appropriate InputHints are set correctly.

@ryanisgrig
Add SetSpeakMiddleware that will format an activity's speak property …
256abba 
…to be SSML enabled with locale and voice font.

Add voicefont property to BotSettingsBase.
@ryanisgrig ryanisgrig added the Language: C# This issue is specifically related to C# implementations. label May 31, 2019
@ryanisgrig ryanisgrig marked this pull request as ready for review May 31, 2019 22:26
@darrenj darrenj merged commit b538a11 into master Jun 1, 2019
@ryanisgrig ryanisgrig deleted the ryanlengel/1142_speakmiddleware branch June 2, 2019 22:40
veluhariharan added a commit to veluhariharan/AI that referenced this pull request Jul 12, 2019
@veluhariharan
Merging to my repo (#1)
aa90a8b 
* [BotBuilder Solutions][TypeScript] Implement tests (microsoft#1436)

* Replace dateformat with dayjs library, update npm shrinkwrap

* Add testResponses in helpers

* Update locales

* Fixes in extensions and utility

* Implement speechUtilityTest

* Implement responseGenerationTest

* Add someComplexType class, implement listExtensionsTest

* Add dateTimeTestData class, create customizeLocale (zh), implement dateTimeExtensionsTest

* [Virtual Assistant Template][TypeScript] Refactor test structure, run build after installation (microsoft#1446)

* Run build after dependencies installation

* Refactor test structure

* Update sample

* Update gitignore and npmignore

* Defensive MultiProviderAuthDialog, Docs for manual skill auth creation (microsoft#1433)

* Defensive for oauthprompt bug

* doc updates for local model deployment, extra trace for misconfigured scenario

* capitalisation

* update to docs

* update to 4.4.3.2 skills/solutions

* Update customizedeployment.md

* Update assistantandskilldeploymentsteps.md

* [Skill Template][TypeScript] Refactor test structure, run build after installation (microsoft#1450)

* Run build after installation

* Refactor test structure

* Update sample

* Update virtualassistant.md

* Update virtualassistant.md

* [Generator][TypeScript] Update tests execution (microsoft#1451)

* Add sinon dependencie, remove unnecesary dependencies

* Ignore build execution for generator tests, add new tests

* updated to 4.4.3.2 (microsoft#1452)

* Sync dispatch model with new services (microsoft#1431) (microsoft#1432)

* Fixes broken link to editing cognitive models area (microsoft#1455)

* [DevOps][TypeScript] Create yaml file with Pipeline configuration to setup CI (microsoft#1457)

* Add yaml files

* Update botbuilder-solutions.yml

* Add images and readme.md

* Update README.md

* [Typescript]Normalize use of asserts in tests  (microsoft#1458)

* Normalize asserts in botbuilder-skills

* Normalize asserts in botbuilder-solutions

* Normalize asserts in generator-botbuilder-assistant

* Normalize asserts in sample-assistant

* Normalize asserts in sample-skill

* Support for silent retrieval of tokens from Token Store in Direct Line Speech scenarios (microsoft#1459)

* first pass of directlinespeech special handling

* Support for silent retrieval of tokens from Token Store in Direct Line Speech scenarios

* Add SetSpeakMiddleware to apply an SSML-formatted voice font to bots Activity.Speak properties (microsoft#1462)

* Add SetSpeakMiddleware that will format an activity's speak property to be SSML enabled with locale and voice font.
Add voicefont property to BotSettingsBase.

* Add the locale when instantiating setspeakmiddleware

* change default locale

* Remove dependency on ConnectorClient which isn't present unless you use BotFrameworkAdapter (microsoft#1468)

* Update knownissues.md

* Update knownissues.md

* Provide custom implementation of GetTokenStatusAsync which will look for _appCredentials rather than ConnectorClient provided by BotFrameworkAdapter (microsoft#1471)

* Fix vulnerability with axios dependency (microsoft#1470)

* [Botskills] Add --noTrain flag for connect/disconnect commands (microsoft#1469)

* Add noTrain parameter

* Avoid training if the flag comes true, for connect/disconnect command

* Update README

* bot skills doc change (microsoft#1461)

* [Skill Template][TypeScript] Add manifestTemplate file (microsoft#1478)

* Add manifestTemplate file in the generator and sample

* Update generator version to 1.0.5

* Update package-lock file

* Deployment Fixes: QnAMaker non-westus region workaround, path with spaces fix, update cogntive model change (microsoft#1476)

* qnamaker fix, path issue fix, updatecogmodels ts

* Update updatedeploymentscripts.md

* add url into exception (microsoft#1472)

* Update LinkedAccounts with latest Bot.Builder packages (microsoft#1481)

* Update to latest Bot.Builder packages

* Update HomeController.cs

* Update linkedaccounts.md

* [TypeScript][BotBuilder-Skills] Add SkillManifestGenerator (microsoft#1483)

* Add manifest generator

* Add manifest generator tests

* Update dependencies

* Fix TSLint issues

* Update dependencies

* [Botskills] Implement tests for connect functionality (microsoft#1488)

* Refactor connectSkill functionality to export Class instead of functions

* Continue implementing connect tests

* Add tests for connectSkill functionality, update validations, remove 'process.exit(1)'

* Refactor authenticationUtils to export class instead of function for ease to mock it

* Add more tests for connect command

* Add reporters for publishing test and coverage results

* Update to make qna steps clearer for Customize tutotrial (microsoft#1487)

* update to make qna steps clearer

* Update customizeassistant.md

* Virtual Assistant Client for Android - initial public commit

* updated .gitignore to ensure the /src/debug folder is not ignored

* Updated LinkedAccounts with Microsoft.Identity.Web package that contains helper methods to enable users to authenticate with Azure AD & personal Microsoft accounts. (microsoft#1490)

Updated to .Net Core 2.2 framework.
Addressing some stylecop issues with comments

* upgrade protocol assemblies (microsoft#1494)

* [DevOps][TypeScript] Update YAML file in Botskills (microsoft#1491)

* Update botskills yaml

* Update package-lock.json and package.json

* Update deployment docs to add languages parameter (microsoft#1495)

* document language parameter

* csv update

* addressing entity mapping issue

* Virtual Assistant Client for Android - initial public commit (microsoft#1493)

* Virtual Assistant Client for Android - initial public commit

* updated .gitignore to ensure the /src/debug folder is not ignored

* Fixing issue with hardcoding adapter and few minor changes to get rid of redundant else and sending cancellation token (microsoft#1489)

* implemented feedback from PR 1493

* Update @azure/ms-rest-js dependency to fix an issue with axios (microsoft#1498)

* code cleanup after merge

* Updates from previous PR feedback (microsoft#1499)

* Virtual Assistant Client for Android - initial public commit

* updated .gitignore to ensure the /src/debug folder is not ignored

* implemented feedback from PR 1493

* code cleanup after merge

* Fixes path issue with dispatch sync (microsoft#1501)

* Fix pathing to update dispatch file in correct dir

As it stands the current script would create/update a .dispatch file in `Deployment\Resources\Dispatch` rather than `Deployment\Resources\Dispatch\locale-folder` which means that when the dispatch refresh command is run (and looks for a dispatch file inside the locale-folder) it won't be the file that was just updated. This change update the behaviour so that we are both writing to, and reading from the locale-folder.

* Fixes incorrect pathing

* Fixes pathing

* Fixes pathing

* remove skill begin event (microsoft#1485)

* remove skill begin event

* fix tests

* Update botskill prerequisites and installation (microsoft#1505)

* Update virtualassistant.md

* Fix language argument missing in disconnect (microsoft#1510)

* fixes possible exception due to race condition

* fix: release created and stopped audio records

* [TypeScript][Skill Sample] Add manifest endpoint (microsoft#1511)

* Add manifest endpoint

* Update template with manifest endpoint

* fix chitchat (microsoft#1516)

* Fix null reference exception (microsoft#1523)

* Fix NullReference exception when MembersAdded is null

* Fix NullReference exception with correct version

* added timeout event so that client app can notify user

* set default dialog result to be waiting instead of empty (microsoft#1526)

* WIP adaptive card click events

* WIP adaptive card clicking

* finished implementation of adaptive card clicking

* [DevOps][C#] Create C# YAML file with Pipeline configuration to setup CI (microsoft#1525)

* Add typescript folder

* Add coverlet package

* Add csharp folder with YAML files

* Add images and readme

* Minor changes

* [Calendar] Update calendar document (microsoft#1527)

* update calendar doc

* tune doc format

* [Botskills] Implement refresh command (microsoft#1480)

* Refactor connectSkill functionality to export Class instead of functions

* Add train functionality

* Use train functionality in connect/disconnect command

* Mock train command for disconnect tests

* Implement train tests

* Add/update documentation

* Adapt connect tests for train command, fix some train tests

* Update refresh documentation

* Rename noTrain flag to noRefresh

* Update all train references to refresh

* Change stub for replace for external call test

* Add missing warning message with its test, update mocked file, replace require with readFileSync

* Update addingskills.md

* Home page redirects to Linked Accounts page with optional boolean query parameter "companionApp." If true, it will show a new "Complete and return to app" button that opens the deep link "microsoft://virtualassistant/user/{userId}. (microsoft#1529)

* Update virtualassistant.md

* [Skills] fix the issue where in webchat skill responses are not sent back to user properly (microsoft#1540)

* set recipient id back to original after message sent to skill

* fix indentation

* If a token is missing for a user using the direct line speech channel, their client will receive an event named "RequestOAuthFlow" (microsoft#1539)

It's up to the client to configure this with their sign-in scenario

* Update knownissues.md

* [Botskills] Implement update command (microsoft#1524)

* Fix SkillFile classname

* Implement update command

* Add documentation

* Add update command tests

* Update README

* Fix rebase issues

* Fix readme

* [BotBuilder Libs] Test structure refactor (microsoft#1535)

* Botbuilder-solutions test structure refactor

* Botbuilder-skills test structure refactor

* Fix resources path

* Include master and feature branches (microsoft#1536)

* [DevOps][TypeScript] Implement different test/coverage script for dev and CI (microsoft#1538)

* Add dev-scripts to sample-assistant

* Add dev-scripts to sample-skill

* Add dev-scripts to botskills

* Add dev-scripts to botbuilder-libs

* Add dev-scripts to generator-botbuilder-assistant

* Update templates

* Update pipelines

* Fix botbuilder-libs scripts

* Update readme.md

* Update readme.md

* Update readme.md

* Update readme.md

* Update readme.md

* [Skills] Add error handling for skills websocket transport (microsoft#1518)

* complete failure handling for websocket transport

* remove redundant code

* fix bug

* fix indentation

* [Generator][TypeScript] - Improvements and new folders (microsoft#1547)

* Add pipeline folder for each template, and tests

* Change customAssistant to sample-assistant

* Change customSkill to sample-skill

* Change customSkillAdapter to sampleSkillAdapter

* Fix merge issues

* Update sample assistant

* Update samples

* Add deployment messages

* Update YAML files (microsoft#1545)

* Update Bing Search Skill with client-agnostic Adaptive Cards (microsoft#1544)

* Updated Bing Search Skill with cleaned up cards

* Update PersonCard.json

* Shzhen/customizedlisttype (#1521)

* Enable developers to add their own customized list types.
* Add documents about how to do this.

* Skills lib and VATemplate change to enable speech by default (microsoft#1548)

* fix auth issue by removing explicit call to token service

* add more validation

* fix build issue

* pull in VA template changes

* revert MultiProviderAuthDialog change

* fix warning

* fix indentation

* fix indentation

* added missing code back

* final fix for indentation

* correct comment

* remove assembly files

* remove empty folder from csproj file

* update doc to add instruction for adding experimental myget feed

* updates for project source resolution and ensure templates compile

* Updated cards to address 1.2 validation issues (microsoft#1557)

* add exception handling for auth for speech (microsoft#1558)

* Changes to VATemplate, SkillTemplate and skills to use the new skills lib (microsoft#1553)

* remove continue dialog call on skill

* add event handling in VA as well as skills using semanticAction

* fix indentation

* fix comment

* final indentation

* update skills, skill template

* hopefully last piece of change

* test fix

* Lamil/telemetry (microsoft#1560)

* Telemetry fix

* added telemetry changed to va and skill samples and templates

* fixed di

* fix VA Template main dialog compile error (microsoft#1562)

* Fix MultiProviderAuthDialog in a better way (microsoft#1563)

* fix tiny issue in doc (microsoft#1564)

* Updated VSIXs for new nuget versions (microsoft#1567)

* update to pass invoke event through for teams (microsoft#1568)

* Docs - Add link to sample project for mac users (microsoft#1569)

* link to sample project

* Update skill.md

* Update virtualassistant.md

* Update skillscli link on docs readme (microsoft#1576)

* Update skillscli link on main readme

* fix link

* update luis (microsoft#1574)

* Fix project folder parameter in bot deploy script (microsoft#1571)

* Fix project folder parameter in bot deploy script

* Updated deploy script to use escaped double quotes for consistency

* Update sample project with projDir script fixes

* Updated skill template with new script fix

* Updated Location event so that the data is consumed properly

* additional IPA -> VA changes

* logcat logging of complete JSON data

* Delete speechenablement.md

Speech is enabled out of the box and this is an empty file

* Delete projectstructure.md

Deleting empty file

* Delete dispatcher.md

Deleting empty file

* Delete adaptivecardstyling.md

Delete empty file

* Delete skillcli.md

Delete empty ifle

* using suggested actions for adaptive card click

* undo incorrect commit

* added suggested actions feature

* remove break string because it's not really needed (microsoft#1597)

* remove break string because it's not really needed

* fix test

* Update known issue around Teams and VA change for existing projects using skills (microsoft#1577)

* doc update following teams fixes

* maindialog change

* Update knownissues.md

* Create stale.yml

* Update stale.yml

* Set theme jekyll-theme-minimal

* Set theme jekyll-theme-minimal

* Only add the Accept header to HttpClient if it's missing (microsoft#1605)

* [Speech]set ssml to neural (microsoft#1606)

* set ssml to neural

* revert prior change

* Fix ESLint issues (microsoft#1607)

* update luis model to v1.4.2 (microsoft#1601)

* [Todo] Fix todo scope issue (microsoft#1600)

* update luis

* fix todo scope issue

* Implement call to getTokenStatus (microsoft#1559)

* [Botskills] Test structure refactor (microsoft#1534)

* Update test structure

* Require join and resolve instead of the whole library

* Change double to single quotes, update way to test breaklines

* Fix rebase issues

* Clean tests

* Remove unnecessary folder

* [C#] Add YAML files in VSIX Generators (microsoft#1610)

* Add Pipeline folder in VA template

* Add Pipeline folder in Skill template

* Add Pipeline folder in VA and Skill sample

* Rename template YAML files

* Update template files

* Proposal for new pull request template (microsoft#1594)

* Added new template for draft

* Update launch plan

* change changes text

* change launch plan to feature plan

* Set up CI with Azure Pipelines

[skip ci]

* Create comment.md

* Improve Speak for POI (microsoft#1608)

* add AddressForSpeak property to provide customized speech response

* set AddressForSpeak to be the same as Address for azure maps by default

* fix test

* Rename comment.md to comment.txt

* updates to allow the service to receive connections from other apps

* Add templates for automatic pull request comments (microsoft#1619)

* Added comment scripts for default checklist, bot projects checklist, and deployment scripts checklist.

* Added checkbox for language model changes in bots

* Fix grammar and rename bot to bots file

* Ryanlengel/pullrequest comments (microsoft#1624)

* Added comment scripts for default checklist, bot projects checklist, and deployment scripts checklist.

* Added checkbox for language model changes in bots

* Fix grammar and rename bot to bots file

* Fix directories for comment scripts

* Updates to Virtual Assistant Android app (microsoft#1596)

* Virtual Assistant Client for Android - initial public commit

* updated .gitignore to ensure the /src/debug folder is not ignored

* implemented feedback from PR 1493

* code cleanup after merge

* fixes possible exception due to race condition

* fix: release created and stopped audio records

* added timeout event so that client app can notify user

* WIP adaptive card click events

* WIP adaptive card clicking

* finished implementation of adaptive card clicking

* Updated Location event so that the data is consumed properly

* additional IPA -> VA changes

* logcat logging of complete JSON data

* using suggested actions for adaptive card click

* undo incorrect commit

* added suggested actions feature

* Update App Insights Telemetry usage in all Skills (microsoft#1611)

* fix telemetry

* update new script

* small code updates + locationProvider threading fix

* Update known issues and emphasize commonly missed steps (microsoft#1636)

* update known issues

* emphasising common overlooked steps

* webchat

* webchat

* luis update

* [BotBuilder Solutions][TypeScript] Fix 'import-name' rule issue (microsoft#1638)

* Fix TSLint issue

* Import dynamics locales

* Improve logic

* Add error message if import fails

* Replace requires for reading json files (microsoft#1641)

* [TypeScript][Virtual Assistant/Skill samples] Remove unused dependencies (microsoft#1642)

* Check dependencies in sample-assistant

* Check dependencies in sample-skill

* Remove unused dependencies in botbuilder-libs (microsoft#1643)

* Update manualauthsteps.md

* finished feature to broadcast data to other apps

* Assistant Android app -  (microsoft#1649)

* Virtual Assistant Client for Android - initial public commit

* updated .gitignore to ensure the /src/debug folder is not ignored

* implemented feedback from PR 1493

* code cleanup after merge

* fixes possible exception due to race condition

* fix: release created and stopped audio records

* added timeout event so that client app can notify user

* WIP adaptive card click events

* WIP adaptive card clicking

* finished implementation of adaptive card clicking

* Updated Location event so that the data is consumed properly

* additional IPA -> VA changes

* logcat logging of complete JSON data

* using suggested actions for adaptive card click

* undo incorrect commit

* added suggested actions feature

* updates to allow the service to receive connections from other apps

* small code updates + locationProvider threading fix

* finished feature to broadcast data to other apps

* Delete azure-pipelines.yml

* Introduce Speech Enablement Docs and General Doc Changes (microsoft#1644)

* docs update and speech capabilities

* updates after testing

* Update parentchildpattern.md

Updated Overview, Parent-Child pattern and example sections with similar language

* feedback from ryan

* further comment updates

* alignment

* dotnet new templates (VSCode) for Virtual Assistant and Skills (microsoft#1580)

* va tempate for dotnet new/vscode

* skill template

* update to sln

* update skill documents (microsoft#1612)

* [Generator][TypeScript] Fix the variable cases (microsoft#1651)

* Fix cases on manifestTemplate, add tests

* Remove unused dependencies

* Update samples

* [DevOps][TypeScript] Add YAML file for generator-botbuilder-assistant (microsoft#1652)

* Update generator-botbuilder-assistant and skill test files

* Add YAML file

* Update YAML file

* Update template.json

* Update template.json

* Update botbuilder-skills version in package.json file (microsoft#1658)

* Update skills to render in Teams (microsoft#1394) (microsoft#1646)

* update package version

* provide v1.0 json of adaptive cards for Teams

* skip certain responses that Teams could not handle

* separate certain prompts that Teams could not handle

* use svg in weather and todo skills for Teams

* update related tests

* update md and some htmls

* [Luisgen Model] Update all IRecognizerConvert model to latest with luisgen (microsoft#1657)

* fix telemetry

* update new script

* fix luisgen models

* fix ut

* fix geographyV2 issue

* [Email] Add config for slot filling attribute skip (microsoft#1631)

* remove read me

* add config for slot filling

* fix ut

* remove useless code

* move default value to resource

* add doc support

* added initial readme for Android app

* Update readme.md

* Added initial readme for Android Assistant app (microsoft#1667)

* Virtual Assistant Client for Android - initial public commit

* updated .gitignore to ensure the /src/debug folder is not ignored

* implemented feedback from PR 1493

* code cleanup after merge

* fixes possible exception due to race condition

* fix: release created and stopped audio records

* added timeout event so that client app can notify user

* WIP adaptive card click events

* WIP adaptive card clicking

* finished implementation of adaptive card clicking

* Updated Location event so that the data is consumed properly

* additional IPA -> VA changes

* logcat logging of complete JSON data

* using suggested actions for adaptive card click

* undo incorrect commit

* added suggested actions feature

* updates to allow the service to receive connections from other apps

* small code updates + locationProvider threading fix

* finished feature to broadcast data to other apps

* added initial readme for Android app

* Update readme.md

* [Botskills] Add a new Known Issue of the CLI tool (microsoft#1665)

* Adapt luisgen commands to trailing backslashs

* Add issue in KnownIssues doc

* Add an example of the issue

* [DevOps] Disable builds in pull-request by default (microsoft#1661)

* Update YAML files in TypeScript and Csharp

* Update readme in both versions

* Minor changes in YAML files

* Minor changes in readme files

* Updated default comment with sections for bots/deployment scripts (microsoft#1669)

* News skill: adding trending articles, favorite topics, searching by market, searching by website  (microsoft#1660)

* Added trending articles, changing search market, search specific sites, choosing favorite topics

* Changes from comments

* fis newsLuis

* update publish scripts to fix skill deployment filenotfound issues with kudu (microsoft#1668)

* Create release-drafter.yml

* [TypeScript][Virtual Assistant/Skill samples] Migrate from TSLint to ESLint (microsoft#1673)

* Add ESLint to sample assistant

* Fix ESLint issues in sample-assistant

* Add ESLint to sample skill

* Fix ESLint issues in sample-skill

* Update dependencies

* Update templates

* Update generator

* added feature to show full conversation

* latest upstream changes (microsoft#8)

* Added initial readme for Android Assistant app (microsoft#1667)

* Virtual Assistant Client for Android - initial public commit

* updated .gitignore to ensure the /src/debug folder is not ignored

* implemented feedback from PR 1493

* code cleanup after merge

* fixes possible exception due to race condition

* fix: release created and stopped audio records

* added timeout event so that client app can notify user

* WIP adaptive card click events

* WIP adaptive card clicking

* finished implementation of adaptive card clicking

* Updated Location event so that the data is consumed properly

* additional IPA -> VA changes

* logcat logging of complete JSON data

* using suggested actions for adaptive card click

* undo incorrect commit

* added suggested actions feature

* updates to allow the service to receive connections from other apps

* small code updates + locationProvider threading fix

* finished feature to broadcast data to other apps

* added initial readme for Android app

* Update readme.md

* [Botskills] Add a new Known Issue of the CLI tool (microsoft#1665)

* Adapt luisgen commands to trailing backslashs

* Add issue in KnownIssues doc

* Add an example of the issue

* [DevOps] Disable builds in pull-request by default (microsoft#1661)

* Update YAML files in TypeScript and Csharp

* Update readme in both versions

* Minor changes in YAML files

* Minor changes in readme files

* Updated default comment with sections for bots/deployment scripts (microsoft#1669)

* News skill: adding trending articles, favorite topics, searching by market, searching by website  (microsoft#1660)

* Added trending articles, changing search market, search specific sites, choosing favorite topics

* Changes from comments

* fis newsLuis

* update publish scripts to fix skill deployment filenotfound issues with kudu (microsoft#1668)

* Create release-drafter.yml

* [TypeScript][Virtual Assistant/Skill samples] Migrate from TSLint to ESLint (microsoft#1673)

* Add ESLint to sample assistant

* Fix ESLint issues in sample-assistant

* Add ESLint to sample skill

* Fix ESLint issues in sample-skill

* Update dependencies

* Update templates

* Update generator

* [SkillsLib]remove http transport and related (microsoft#1676)

* remove http transport and related

* try to get RestoreAddtionalProjectSources working

* trigger build

* add package source for Skills test project

* Android app update: Ability to change view between Full Conversation and Conversation (microsoft#1681)

* Virtual Assistant Client for Android - initial public commit

* updated .gitignore to ensure the /src/debug folder is not ignored

* implemented feedback from PR 1493

* code cleanup after merge

* fixes possible exception due to race condition

* fix: release created and stopped audio records

* added timeout event so that client app can notify user

* WIP adaptive card click events

* WIP adaptive card clicking

* finished implementation of adaptive card clicking

* Updated Location event so that the data is consumed properly

* additional IPA -> VA changes

* logcat logging of complete JSON data

* using suggested actions for adaptive card click

* undo incorrect commit

* added suggested actions feature

* updates to allow the service to receive connections from other apps

* small code updates + locationProvider threading fix

* finished feature to broadcast data to other apps

* added initial readme for Android app

* Update readme.md

* added feature to show full conversation

* latest upstream changes (microsoft#8)

* Added initial readme for Android Assistant app (microsoft#1667)

* Virtual Assistant Client for Android - initial public commit

* updated .gitignore to ensure the /src/debug folder is not ignored

* implemented feedback from PR 1493

* code cleanup after merge

* fixes possible exception due to race condition

* fix: release created and stopped audio records

* added timeout event so that client app can notify user

* WIP adaptive card click events

* WIP adaptive card clicking

* finished implementation of adaptive card clicking

* Updated Location event so that the data is consumed properly

* additional IPA -> VA changes

* logcat logging of complete JSON data

* using suggested actions for adaptive card click

* undo incorrect commit

* added suggested actions feature

* updates to allow the service to receive connections from other apps

* small code updates + locationProvider threading fix

* finished feature to broadcast data to other apps

* added initial readme for Android app

* Update readme.md

* [Botskills] Add a new Known Issue of the CLI tool (microsoft#1665)

* Adapt luisgen commands to trailing backslashs

* Add issue in KnownIssues doc

* Add an example of the issue

* [DevOps] Disable builds in pull-request by default (microsoft#1661)

* Update YAML files in TypeScript and Csharp

* Update readme in both versions

* Minor changes in YAML files

* Minor changes in readme files

* Updated default comment with sections for bots/deployment scripts (microsoft#1669)

* News skill: adding trending articles, favorite topics, searching by market, searching by website  (microsoft#1660)

* Added trending articles, changing search market, search specific sites, choosing favorite topics

* Changes from comments

* fis newsLuis

* update publish scripts to fix skill deployment filenotfound issues with kudu (microsoft#1668)

* Create release-drafter.yml

* [TypeScript][Virtual Assistant/Skill samples] Migrate from TSLint to ESLint (microsoft#1673)

* Add ESLint to sample assistant

* Fix ESLint issues in sample-assistant

* Add ESLint to sample skill

* Fix ESLint issues in sample-skill

* Update dependencies

* Update templates

* Update generator

* implements microsoft#1497 "react to additional received activity types"

* [Botskills] Improve error messages (microsoft#1683)

* Improve error messages for more verbosity

* Continue improving error messages

* Finish improving error messages

* Improve error handling for authenticationUtils

* Revert changes to arguments arrays

* Add link to documentation when auth fails

* Allow ITriggers with nullable properties (microsoft#1685)

* [Botskills] Move location to tools folder (microsoft#1666)

* Move botskills cli tool to the tools root folder

* Update doc references

* Update yaml files

* Update package-lock file

* Update build.botskills.ts.ps1

* Update speechenablement.md

* added sound effects, fixes microsoft#1684

* [Botskills] Add re-publish warning (microsoft#1686)

* Add warning to republish VA after refresh

* Fix tests

* add flag to include nuget pkgs so nuspec can pick up packages needed (microsoft#1690)

* add flag to include nuget pkgs so nuspec can pick up packages needed

* force trigger build

* remove redundant space

* [VA] Updated deployment scripts to assign luis subscription key automatically (microsoft#1693)

* add luis sub key

* add azure account

* deploy updates

* deploy fix

* [Botskills] Update documentation (microsoft#1688)

* Update botskills documentation

* Remove style of botskills word

* Fix link reference

* Fix references to botskills documentation

* Fix typos

* Apply suggestions from code review

Co-Authored-By: David Favretto <david.favretto@southworks.com>

* Apply suggestions from code review

* upgrade versions of skills and solutions for templates (microsoft#1695)

* [TypeScript][BotBuilder-Libs] Migrate from TSLint to ESLint (microsoft#1696)

* Add ESLint to botbuilder-solutions

* Add ESLint to botbuilder-skills

* Update dependencies

* Fix ESLint issues in botbuilder-solutions

* Fix ESLint issues in botbuilder-skills

* upgrade skills to latest lib version (microsoft#1698)

* [Calendar] Add config for slot filling attribute skip (microsoft#1647)

* add slot filling default value config

* fix test cases

* add default value config of start date and duration

* add default content and location in common string

* update doc

* Update productivity-calendar.md

* Update productivity-email.md

* Update knownissues.md

* removing template projects from sln as msbuild on devops can't skip certain projects. (microsoft#1703)

* VA Deployment Updates (microsoft#1694)

* write full validation result to log

* handle spaces in path

* fixed publish with different bot name

* added luis region to all commands

* removed extra registration from skill (microsoft#1702)

* Fix broken link to botskills cli (microsoft#1708)

* move backgroundImage into column (microsoft#1711) (microsoft#1712)

They are used in ResponseManager.GetCardResponse as containerItems, so
backgroundImage should be kept in Column.

* [TypeScript][Botskills] Refactor in Mocks folder (microsoft#1706)

* Fix typos for errors

* Refactor mocks folder

* Remove unused dependencies in generator-botbuilder-assistant (microsoft#1707)

* Update README.md

* Update CODEOWNERS (microsoft#1709)

* add teams docs (microsoft#1716)

* Updates skill deployment scripts with latest fixes from VA template (microsoft#1722)

* write full validation result to log

* handle spaces in path

* fixed publish with different bot name

* added luis region to all commands

* updated skill scripts

* updated skill arm template

* updated va deployment scripts

* [Linked Accounts] Fix sign-in/sign-out flow (microsoft#1723)

* Clean up appsettings values to fix builds

* Resolved some simple formatting errors across the project
Fixed sign-out & sign-in by passing AzureAD as asp-area. Web app will now ask user to sign-in and can sign-out successfully.

* Update linked accounts doc with app settings comments

* Update Microsoft.Identity.Web with latest references

* Fix broken links (microsoft#1725)

* Update knownissues.md

* Update virtualassistant.md

* [TypeScript][Botskills] Implement sanitization path (microsoft#1731)

* Implement sanitization path as an util

* Export the sanitization util

* Path sanitization for commands in the cli

* Add tests for the sanitization

* Remove line break

* restaurant booking's lu file has entity attendees (microsoft#1654) (microsoft#1727)

* Update POI deployment scripts (microsoft#1726)

* updated poi skill deployment

* updated poi luisgen file

* fixed luisgen casing errors

* updates to use luis get app for culture

* Fix misspellings in comments (microsoft#1741)

* Fix datetime to string conversion (microsoft#1742)

* Remove a possible recursive property call (microsoft#1736)

* Danalb/doc fix (microsoft#1749)

* Update virtualassistant.md

Add missing required parameter.

* Update assistantandskilldeploymentsteps.md

This one too.

* use say-as in GetPointOfInterestPrompt (microsoft#1720) (microsoft#1746)

Has limited multiple language support and pay attention to special characters in html

* Updated Calendar deployment scripts (microsoft#1756)

* updated deployment scripts

* updated luisgen and capitalization

* updated appsettings sample

* moved config out of properties

* updated tests

* updated properties

* Skill EN response refinement (microsoft#1761)

* calendar skill EN refinement

* email response refinement

* todo EN response refinement

* poi en refinement

* Add eslintignore file, and ignore the auto-generated files (microsoft#1732)

* Latest Android Assistant updates (microsoft#1771)

* blue background for users' requests in chat

* added demo feature to update widgets of 3rd party app

* added ISO 8601 timestamps to generated activity events

* pull from upstream (microsoft#11)

* Added initial readme for Android Assistant app (microsoft#1667)

* Virtual Assistant Client for Android - initial public commit

* updated .gitignore to ensure the /src/debug folder is not ignored

* implemented feedback from PR 1493

* code cleanup after merge

* fixes possible exception due to race condition

* fix: release created and stopped audio records

* added timeout event so that client app can notify user

* WIP adaptive card click events

* WIP adaptive card clicking

* finished implementation of adaptive card clicking

* Updated Location event so that the data is consumed properly

* additional IPA -> VA changes

* logcat logging of complete JSON data

* using suggested actions for adaptive card click

* undo incorrect commit

* added suggested actions feature

* updates to allow the service to receive connections from other apps

* small code updates + locationProvider threading fix

* finished feature to broadcast data to other apps

* added initial readme for Android app

* Update readme.md

* [Botskills] Add a new Known Issue of the CLI tool (microsoft#1665)

* Adapt luisgen commands to trailing backslashs

* Add issue in KnownIssues doc

* Add an example of the issue

* [DevOps] Disable builds in pull-request by default (microsoft#1661)

* Update YAML files in TypeScript and Csharp

* Update readme in both versions

* Minor changes in YAML files

* Minor changes in readme files

* Updated default comment with sections for bots/deployment scripts (microsoft#1669)

* News skill: adding trending articles, favorite topics, searching by market, searching by website  (microsoft#1660)

* Added trending articles, changing search market, search specific sites, choosing favorite topics

* Changes from comments

* fis newsLuis

* update publish scripts to fix skill deployment filenotfound issues with kudu (microsoft#1668)

* Create release-drafter.yml

* [TypeScript][Virtual Assistant/Skill samples] Migrate from TSLint to ESLint (microsoft#1673)

* Add ESLint to sample assistant

* Fix ESLint issues in sample-assistant

* Add ESLint to sample skill

* Fix ESLint issues in sample-skill

* Update dependencies

* Update templates

* Update generator

* [SkillsLib]remove http transport and related (microsoft#1676)

* remove http transport and related

* try to get RestoreAddtionalProjectSources working

* trigger build

* add package source for Skills test project

* Android app update: Ability to change view between Full Conversation and Conversation (microsoft#1681)

* Virtual Assistant Client for Android - initial public commit

* updated .gitignore to ensure the /src/debug folder is not ignored

* implemented feedback from PR 1493

* code cleanup after merge

* fixes possible exception due to race condition

* fix: release created and stopped audio records

* added timeout event so that client app can notify user

* WIP adaptive card click events

* WIP adaptive card clicking

* finished implementation of adaptive card clicking

* Updated Location event so that the data is consumed properly

* additional IPA -> VA changes

* logcat logging of complete JSON data

* using suggested actions for adaptive card click

* undo incorrect commit

* added suggested actions feature

* updates to allow the service to receive connections from other apps

* small code updates + locationProvider threading fix

* finished feature to broadcast data to other apps

* added initial readme for Android app

* Update readme.md

* added feature to show full conversation

* latest upstream changes (microsoft#8)

* Added initial readme for Android Assistant app (microsoft#1667)

* Virtual Assistant Client for Android - initial public commit

* updated .gitignore to ensure the /src/debug folder is not ignored

* implemented feedback from PR 1493

* code cleanup after merge

* fixes possible exception due to race condition

* fix: release created and stopped audio records

* added timeout event so that client app can notify user

* WIP adaptive card click events

* WIP adaptive card clicking

* finished implementation of adaptive card clicking

* Updated Location event so that the data is consumed properly

* additional IPA -> VA changes

* logcat logging of complete JSON data

* using suggested actions for adaptive card click

* undo incorrect commit

* added suggested actions feature

* updates to allow the service to receive connections from other apps

* small code updates + locationProvider threading fix

* finished feature to broadcast data to other apps

* added initial readme for Android app

* Update readme.md

* [Botskills] Add a new Known Issue of the CLI tool (microsoft#1665)

* Adapt luisgen commands to trailing backslashs

* Add issue in KnownIssues doc

* Add an example of the issue

* [DevOps] Disable builds in pull-request by default (microsoft#1661)

* Update YAML files in TypeScript and Csharp

* Update readme in both versions

* Minor changes in YAML files

* Minor changes in readme files

* Updated default comment with sections for bots/deployment scripts (microsoft#1669)

* News skill: adding trending articles, favorite topics, searching by market, searching by website  (microsoft#1660)

* Added trending articles, changing search market, search specific sites, choosing favorite topics

* Changes from comments

* fis newsLuis

* update publish scripts to fix skill deployment filenotfound issues with kudu (microsoft#1668)

* Create release-drafter.yml

* [TypeScript][Virtual Assistant/Skill samples] Migrate from TSLint to ESLint (microsoft#1673)

* Add ESLint to sample assistant

* Fix ESLint issues in sample-assistant

* Add ESLint to sample skill

* Fix ESLint issues in sample-skill

* Update dependencies

* Update templates

* Update generator

* [Botskills] Improve error messages (microsoft#1683)

* Improve error messages for more verbosity

* Continue improving error messages

* Finish improving error messages

* Improve error handling for authenticationUtils

* Revert changes to arguments arrays

* Add link to documentation when auth fails

* Allow ITriggers with nullable properties (microsoft#1685)

* [Botskills] Move location to tools folder (microsoft#1666)

* Move botskills cli tool to the tools root folder

* Update doc references

* Update yaml files

* Update package-lock file

* Update build.botskills.ts.ps1

* Update speechenablement.md

* [Botskills] Add re-publish warning (microsoft#1686)

* Add warning to republish VA after refresh

* Fix tests

* add flag to include nuget pkgs so nuspec can pick up packages needed (microsoft#1690)

* add flag to include nuget pkgs so nuspec can pick up packages needed

* force trigger build

* remove redundant space

* [VA] Updated deployment scripts to assign luis subscription key automatically (microsoft#1693)

* add luis sub key

* add azure account

* deploy updates

* deploy fix

* [Botskills] Update documentation (microsoft#1688)

* Update botskills documentation

* Remove style of botskills word

* Fix link reference

* Fix references to botskills documentation

* Fix typos

* Apply suggestions from code review

Co-Authored-By: David Favretto <david.favretto@southworks.com>

* Apply suggestions from code review

* upgrade versions of skills and solutions for templates (microsoft#1695)

* [TypeScript][BotBuilder-Libs] Migrate from TSLint to ESLint (microsoft#1696)

* Add ESLint to botbuilder-solutions

* Add ESLint to botbuilder-skills

* Update dependencies

* Fix ESLint issues in botbuilder-solutions

* Fix ESLint issues in botbuilder-skills

* upgrade skills to latest lib version (microsoft#1698)

* [Calendar] Add config for slot filling attribute skip (microsoft#1647)

* add slot filling default value config

* fix test cases

* add default value config of start date and duration

* add default content and location in common string

* update doc

* Update productivity-calendar.md

* Update productivity-email.md

* Update knownissues.md

* removing template projects from sln as msbuild on devops can't skip certain projects. (microsoft#1703)

* VA Deployment Updates (microsoft#1694)

* write full validation result to log

* handle spaces in path

* fixed publish with different bot name

* added luis region to all commands

* removed extra registration from skill (microsoft#1702)

* Fix broken link to botskills cli (microsoft#1708)

* move backgroundImage into column (microsoft#1711) (microsoft#1712)

They are used in ResponseManager.GetCardResponse as containerItems, so
backgroundImage should be kept in Column.

* [TypeScript][Botskills] Refactor in Mocks folder (microsoft#1706)

* Fix typos for errors

* Refactor mocks folder

* Remove unused dependencies in generator-botbuilder-assistant (microsoft#1707)

* Update README.md

* Update CODEOWNERS (microsoft#1709)

* removed timestamp from Activity events

* added Timezone feature. Fixes microsoft#1678

* removed unnecessary Directline constant

* updates:

1. new API sendTimeZoneEvent
2. Settings UI update
3. fixes bug in Synthesizer
4. bot will listen again when expectingInput is received

* Settings screen cleanup

* fix merge for these files with special chars

* Improved broadcasting to 3rd-party apps

* use geographyV2 and submit action in poi (microsoft#1662)(microsoft#1587) (microsoft#1713)

* only use LUIS at the beginning when address and keyword are provided

* use geographyV2 when address is empty

* use Action.Submit for POI. However, it will always submit the content when clicked

* submit as ConfirmPrompt for single choice

* use SelectPointOfInterestPrompt for multiple routes

* add handle actions step (microsoft#1635)

* use image with route (microsoft#1332) (microsoft#1733)

* update POISharedResponses and some card.json (microsoft#1791) (microsoft#1792)

Bing translated..

* [DO NOT MERGE] Updated ToDo skill deployment scripts (microsoft#1743)

* updated deployment scripts

* Revert "updated deployment scripts"

This reverts commit 012b26b.

* updated to do deployment scripts

* updated arm template

* updated sample cognitivemodels.json

* fixed casing of ToDoLuis to camel case

* updated luis gen to camel casing

* updated arm template and appsettings.json

* fixed capitalization in arm template

* Rename general.lu to General.lu

* Rename todo.lu to ToDo.lu

* Rename general.lu to General.lu

* Rename todo.lu to ToDo.lu

* Rename general.lu to General.lu

* Rename todo.lu to ToDo.lu

* Rename general.lu to General.lu

* Rename todo.lu to ToDo.lu

* Rename general.lu to General.lu

* Rename todo.lu to ToDo.lu

* Rename general.lu to General.lu

* Rename todo.lu to ToDo.lu

* updated to do luisgen file

* Update template.json

* Update template.json

* Update template.json

* fixed tests

* Update CODEOWNERS (microsoft#1800)

* Update Email deployment scripts (microsoft#1744)

* updated deployment scripts

* fixed capitalization

* moved settings out of properties array

* updated arm template

* fixed tests

* updated luis gen file to latest

* Rename email.lu to Email.lu

* Rename general.lu to General.lu

* Rename email.lu to Email.lu

* Rename general.lu to General.lu

* Rename email.lu to Email.lu

* Rename general.lu to General.lu

* Rename email.lu to Email.lu

* Rename general.lu to General.lu

* Rename email.lu to Email.lu

* Rename general.lu to General.lu

* Rename email.lu to Email.lu

* Rename general.lu to General.lu

* Update Email.lu

* Update Email.lu

* Update speechenablement.md

Close microsoft#1810 , microsoft#1811

* Return checklist to PR template (microsoft#1801)

* Update PULL_REQUEST_TEMPLATE.md

* Update PULL_REQUEST_TEMPLATE.md

* Fixed some typos (microsoft#1816)

* Updated Automotive deployment scripts (microsoft#1799)

* updated deployment scripts

* updated captialization

* updated arm script

* updated luisgen files

* Rename settingsLuis.cs to SettingsLuis.cs

* Rename general.lu to General.lu

* Rename settings.lu to Settings.lu

* Updated weather deployment scripts (microsoft#1820)

* update deployment scripts

* updated appsettings properties

* updated appsettings

* Delete CODEOWNERS (microsoft#1821)

Removing CODEOWNERS file as we are transitioning to an auto-assign bot that will add the team as reviewers, but not make people **required** which can interfere with OOF

* Add Australia LUIS reference to docs (microsoft#1798)

* Update assistantandskilldeploymentsteps.md

* Update virtualassistant.md

* Update issue templates (microsoft#1814)

* Update issue templates

* Update bug_report.md

* Update feature_request.md

* Update reservation skill deployment scripts (microsoft#1818)

* updated deployment scripts

* fixed captialization

* removed restaurant sln

* Update template.json

* Rename general.lu to General.lu

* Updated News deployment scripts (microsoft#1815)

* updated news skill deployment scripts

* updated capitalization

* updated arm template

* Rename news.lu to News.lu

* Rename general.lu to General.lu

* poi starts directly for single route (microsoft#1663) (microsoft#1794)

* CancelRouteFailureTest is not valid now
* Translated by Bing..

* Update search skill deployment scripts (microsoft#1819)

* updated deployment scripts

* fixed appsettings properties

* Create auto_assign.yml (microsoft#1822)

* Delete _config.yml

Remove unused Github Pages file

* Add skills folder (microsoft#1825)

* Add files via upload

* Deployment Cleanup for templates (microsoft#1823)

* updated VA deployment scripts

* updated skill template

* Remove hardcoded values in ARM template (microsoft#1813)

* Remove hardcoded values in ARM template
- Default value for parameters "appInsightsLocation"
- Use parameter value for QnAMaker service

* Changed back QnaMaker to westus
lzc850612 pushed a commit that referenced this pull request Jul 31, 2019
@ryanisgrig @darrenj
Add SetSpeakMiddleware to apply an SSML-formatted voice font to bots …
6a412c9 
…Activity.Speak properties (#1462)

* Add SetSpeakMiddleware that will format an activity's speak property to be SSML enabled with locale and voice font.
Add voicefont property to BotSettingsBase.

* Add the locale when instantiating setspeakmiddleware

* change default locale
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@darrenj darrenj darrenj approved these changes

@lauren-mills lauren-mills Awaiting requested review from lauren-mills

@lzc850612 lzc850612 Awaiting requested review from lzc850612

Assignees
No one assigned
Labels
Language: C# This issue is specifically related to C# implementations.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ryanisgrig @darrenj