Skip to content
This repository has been archived by the owner on Jun 30, 2022. It is now read-only.

[Virtual Assistant Template][TypeScript] Take first two letter from locales #1424

Merged
merged 3 commits into from
May 24, 2019

Conversation

Batta32
Copy link
Collaborator

@Batta32 Batta32 commented May 24, 2019

Description

  • Take the first two letters from locales
  • Update generator version to 1.0.4
  • Update libs version to 4.4.6
  • Parity between templates and samples

Fix #1412

Testing Steps

Using the generator-botbuilder-assistant, sample-assistant

  1. Deploy the assistant following these steps
  2. Execute npm install
  3. Execute npm run build
  4. Execute npm run start
  5. Check the bot replies successfully

Checklist

-

@Batta32 Batta32 requested a review from darrenj May 24, 2019 14:49
@Batta32 Batta32 changed the title [Virtual Assistant Template][TypeScript] Take first two letter from locales [DO NOT MERGE][Virtual Assistant Template][TypeScript] Take first two letter from locales May 24, 2019
@Batta32 Batta32 force-pushed the southworks/va/fix-locales branch from 7308d62 to e6b44e4 Compare May 24, 2019 15:27
@Batta32 Batta32 changed the title [DO NOT MERGE][Virtual Assistant Template][TypeScript] Take first two letter from locales [Virtual Assistant Template][TypeScript] Take first two letter from locales May 24, 2019
@lzc850612 lzc850612 merged commit 3e3629e into master May 24, 2019
@Batta32 Batta32 deleted the southworks/va/fix-locales branch May 27, 2019 13:05
lzc850612 pushed a commit that referenced this pull request Jul 31, 2019
…ocales (#1424)

* Take two letter from locale

* Parity between templates and samples

* Update version of projects
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Virtual Assistant doesn't reply on any messages
3 participants