This repository has been archived by the owner on Jun 30, 2022. It is now read-only.
[BotBuilder Skills][TypeScript] Implement tests #1403
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
darrenj
approved these changes
May 22, 2019
lzc850612
pushed a commit
that referenced
this pull request
Jul 31, 2019
* Remove initial structure * Add resources for mocks * Add mockMicrosoftAppCredentials and mockSkillTransports inside mock folder * Implement helpers (baseBot, manifestUtilities, and testbases) * Implement skillDialogInvocationTest * Implement skillDialogSlotFillingTest * Implement manifestTest * Implement skillMiddlewareTest * Update shrinkwrap * Adapt SkillEvent enum * Final changes (remove unnecessary stuffs)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
SkillEventsinstead ofEventsinskillDialogfileskillDialogInvocationTestskillDialogSlotFillingTestmanifestTestskillMiddlewareTestnpm-shrinkwrap.jsonTesting Steps
botframework-solutions\lib\typescript\rush updaterun rebuildbotframework-solutions\lib\typescript\botbuilder-skillsnpm run testand check the following outputChecklist