Skip to content
This repository has been archived by the owner on Jun 30, 2022. It is now read-only.

add support for AAD v1 #1387

Merged
merged 1 commit into from
May 21, 2019
Merged

add support for AAD v1 #1387

merged 1 commit into from
May 21, 2019

Conversation

lzc850612
Copy link
Contributor

Description

We're not supporting AAD v1 and we should as there's customers that are using it.

Architecture

Bug Fixes

Conversational Experience

Maintenance

Language Understanding

Testing Steps

Checklist

  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated the appropriate unit tests
  • I have tested any new/updated dialogs using Speech in the emulator to ensure the Speak property is set to enable a high quality speech-first experience and the appropriate InputHints are set correctly.
  • I have updated related documentation
  • A duplicate issue is filed to track future work.
  • All languages have been updated
  • You have tested deployment with your new models

@darrenj darrenj merged commit b717094 into master May 21, 2019
@darrenj darrenj deleted the tedlee/support-aad-v1 branch May 21, 2019 07:59
@darrenj darrenj mentioned this pull request May 21, 2019
Closed
enzocano added a commit that referenced this pull request May 21, 2019
@enzocano
Migrate changes from #1387 add support for AAD v1
8a25b49
@enzocano enzocano mentioned this pull request May 21, 2019
Merged
darrenj pushed a commit that referenced this pull request May 22, 2019
@enzocano @darrenj
[BotBuilder-Libs][TypeScript] Migrate changes for AADv1 and skillCont…
1bc8cbc 
…ext (#1398)

* Migrate changes from #1387 add support for AAD v1

* Migrate changes from #1389 fix skill middleware handling of SkillContext
lzc850612 added a commit that referenced this pull request Jul 31, 2019
@lzc850612 @darrenj
add support for AAD v1 (#1387)
3317381
lzc850612 pushed a commit that referenced this pull request Jul 31, 2019
@enzocano @darrenj
[BotBuilder-Libs][TypeScript] Migrate changes for AADv1 and skillCont…
714920a 
…ext (#1398)

* Migrate changes from #1387 add support for AAD v1

* Migrate changes from #1389 fix skill middleware handling of SkillContext
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@darrenj darrenj darrenj approved these changes

@lauren-mills lauren-mills Awaiting requested review from lauren-mills

@ryanisgrig ryanisgrig Awaiting requested review from ryanisgrig

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lzc850612 @darrenj @ryanisgrig