Skip to content
This repository has been archived by the owner on Jun 30, 2022. It is now read-only.

[BotBuilder Libs][TypeScript] Implement test main structure #1377

Merged
merged 9 commits into from
May 20, 2019

Conversation

Batta32
Copy link
Collaborator

@Batta32 Batta32 commented May 17, 2019

Description

The following changes were implemented in botbuilder-skills and botbuilder-solutions

  • Implement mocha
  • Implement nyc for code coverage
  • Add test report
  • Create test main structure

Testing Steps

  1. Go to botframework-solutions\lib\typescript\ and open botbuilder-skills or botbuilder-solutions, it's indistinct
  2. Run npm install
  3. Run npm run build
  4. Run npm run test and check that mocha has attempted to run the test
  5. Run npm run coverage and check the output for code coverage

Checklist

  • I have added or updated the appropriate unit tests

@Batta32 Batta32 requested review from lzc850612 and darrenj May 17, 2019 13:32
@Batta32 Batta32 changed the title [BotBuilder Libs][TypeScript] Implement test main structure [DO NOT MERGE][BotBuilder Libs][TypeScript] Implement test main structure May 17, 2019
@Batta32
Copy link
Collaborator Author

Batta32 commented May 17, 2019

@darrenj @lzc850612 please do not merge this PR, we found an issue with the dependencies.
We will let you know when this is ready.

Thanks!

@Batta32 Batta32 changed the title [DO NOT MERGE][BotBuilder Libs][TypeScript] Implement test main structure [BotBuilder Libs][TypeScript] Implement test main structure May 17, 2019
@Batta32
Copy link
Collaborator Author

Batta32 commented May 17, 2019

@darrenj @lzc850612 , now it's ready to be merged!

Thanks 😃

@darrenj darrenj merged commit 180ce03 into master May 20, 2019
@dfavretto dfavretto deleted the southworks/botbuilder-libs/basic-test-implementation branch May 20, 2019 17:04
lzc850612 pushed a commit that referenced this pull request Jul 31, 2019
* Implement mocha

* Implement main test structure

* Implement nyc code coverage

* Implement mocha and nyc

* Add test main structure

* Implement test report

* Update command-line.json file

* Update shrinkwrap.json file

* Update package.json in skills and solutions libs
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants