This repository has been archived by the owner on Jun 30, 2022. It is now read-only.
[4.4] Update VA template to use sdk 4.4 #1214
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
darrenj
approved these changes
May 1, 2019
darrenj
pushed a commit
that referenced
this pull request
May 4, 2019
* added microsoft.bot.builder.skills proj and virtual assistant template proj * Foundational SkillDialog and Adapter from remote invocation sample * SkillController * add locale bots files to copy (#1009) (#1010) * make adapters transient (#1011) * use skillController for all skills * update skillController * updated to use appsettings and support multi locale (#1030) * [4.4 VA Template] Add skill invocation code (#1031) * updated to skills project * added skills config and supporting code * update skill adapter * update startup for skills to add middlewares for skilladapter (#1040) * update startup for skills to add middlewares for skilladapter * update aspnetcore version * remove aspnetcore version * remove default coordinates setting * First pass of a SkillManifest model. (#1041) * First pass of a SkillManifest model. Comments across Skill implementation * Basic manifest deserialization test * build fix * Added SkillMiddleware placeholder in readiness for the slot functionality * [4.4 VA Template] Folder restructure, startup.cs cleanup, MVC change (#1043) * removed files * folder cleanup * startup, controller, bot, adapter cleanup * fixed namespaces * [4.4 VA Template] First pass at deployment scripts (#1045) * added deployment files * cleanup * added original general model back * Tedlee/enable skill auth (#1046) * update startup for skills to add middlewares for skilladapter * update aspnetcore version * remove aspnetcore version * remove default coordinates setting * enable auth for skill invocation * leftout conflict * actually add authentication * change api/skill/messages API to Task instead of IActionResult * [4.4] Updated todo skill to new folder structure + config (#1051) * cleanup * to do skill refactor * updates to todo skill folder structure + new config * updates to VA template * removed old deployment files * fixed merge issues * updated mbbs version * [4.4] Updates POI skill to new folder structure + config (#1054) * updated poi skill folders + config * fixed merge issues * Tedlee/dependency injection change (#1057) * update startup for skills to add middlewares for skilladapter * update aspnetcore version * remove aspnetcore version * remove default coordinates setting * enable auth for skill invocation * leftout conflict * actually add authentication * change api/skill/messages API to Task instead of IActionResult * dependency change on bot controller * change to IServiceProvider for JwtClaimAuthProvider.cs * startup leftover * bot controller leftover * todo bot controller leftover * more leftovers * update solutions package version * [4.4] Email skill folder restructure + config (#1061) * removed old deployment scripts * email skill started * va template cleanup * more todo cleanup * poi cleanup * todo stylecop * email folder restructure and config * updates to calendar skill (#1063) * fixed merge conflicts * [4.4] Update experimental skills folder structure + config (#1065) * updated news skill * updated restaurant skill * [4.4] Automotive Skill folder restructure + config (#1067) * updated auto skill * readme * [4.4]enable oauth (#1070) * enable oauth * latest card changes * make it work * added OAuthConnection (#1071) * Skill Manifest Update Generation * added todo skill oauth (#1072) * added botsettingsbase.cs (#1073) * Refined skill manifest generator Move to BotSettingsBase manifest stubs * added botsettings back * Manifest generation tests changes to enable mocking Added central stylecop rulset and added to projects addressed main warnings * removed class * fix automotive skill build issue * added namespaces * [4.4] Fixes test projects (#1083) * updated va template tests * updated todo skill tests * updates to poi * email skill tests * removed mbbs nuget reference * automotive skill tests * poi skill tests * updated skill lib tests * started calendar skill tests * fixed timezone tests * commented 4 calendar skill tests that broke state * fixed merge conflicts * removed assistant and assistant.tests projects * Tedlee/redo libs (#1084) * remove shared package and make skill reference to solutions package * revert skills.json change * updated to use manifest instead of skillDefinition (#1087) * build fix * add logout handling (#1088) * [4.4] Added va_add_remote_skill.ps1 (#1096) * updated to deployment files * update dispatchluis.cs * Update DispatchLuis.cs * changes that get us closer to nuget packages (#1097) * Tedlee/separate dependency auth (#1094) * separate the initialization of MultiProviderAuthDialog out of SkillDialog * make comments better * make comments even better * Skill support for Slot Filling and Skill/Action wiring for SkillDialog (#1098) * Slot Filling implementation and changes to how we wire up Skills+Actions * tweak to test * PR comment changes Moved to one SkillDialog per Skill and use DialogOptions for the ActionId * addressing warnings * merge issue * moved folders (#1100) * loosen checks on SkillDialog BeginDialog logic (#1101) * Skill Middleware (#1104) * Skill Middleware to retrieve events Tests to validate Skill Middleware Skill Middleware added to all skills Removed old Skill Tests from Solutions project General stylecop warnings fixes * populate skillcontext inside skill * remove fakeskill from solutions.tests * fix bug with maindialog and push logic to identify skill from dispatch intent to helper class in Skills library. (#1110) * [4.4] VA Template VSIX (#1106) * added deployment files to va template * moved deployment * added vsix and sample * commented action check in skillDialog * added redirect url to az ad create command * slots workaround * removed pid prefix from deployment guid * updated defoult outFolder for scripts to cd location * deployment updates * added check for scopes * suppressed output in script * updated skill manifests (#1113) * added build scripts * fix version reference on mvc (#1116) * fix for broken skills package (#1117) * [4.4] Lib changes (#1118) * fix for broken skills package * updates to packages to support parent intents * Update DispatchLuis.cs * [4.4] enable websocket (#1120) * enable http&websocket transport for bot-bot call * leave only skills package change. fix build failures in test * remove skill constants * Addes Nuget.Config to lib folder * Update NuGet.Config * Update Microsoft.Bot.Builder.Skills.csproj * Update NuGet.Config * Update SkillDialog.cs * [4.4]fix existing tests (#1125) * fix existing tests * switch to project reference instead of package for solutions * removed dependency on responseManager argument (#1127) * [4.4] Updated lib tests * Update NuGet.Config * enable websocket for skills by referencing the latest skills package (#1128) * slot matching trace (#1131) * added manifest validation to protect against malformed manifest template files (#1130) * fix calendar skill reference (#1132) * fix calendar skill reference * add botbuilder nuget feed * [4.4] Skill Template (#1124) * va template updates * updated va template vsix * removed src folder * added new skill template * [4.4 VA Template] dependency injection updates (#1133) * dependency injection changes * added comment for adaptive card button * upgrade protocol lib to take in the latest fix (#1136) * fix token response issue where it's not getting to the skill properly if no auth dialog needed (#1137) * add AuthenticationProvider to support ms skills first (#1138) * adding missing skill tracing logs for emulator (#1140) * populate state from skillcontext (#1141) * [4.4] added new intro cards to VA template (#1144) * added new intro cards to va template * fixed gitignore * 4.4 Documentation (#1139) * new deployment steps and doc outline * updated progress * adding skills * updated skill docs * skill docs * add skills to v4 bots * add skill support to bot and skill enabling a bot * more skill docs * additonal add skill commands * link fix * Updated readme * Address final stylecop warnings in Skills/Solutions nuget (#1147) * fix warnings update to enable warnings as errors * updated to new location of websocket packages * update to pass valid dummy app credentials for tests * update to experimental feed * updated package location * [DO NOT MERGE][4.4] Template updates (#1143) * update lg file name * updated to skill manifest * dependency injection updates in skill template * removed oauth default value * updated deployment scripts * updated skill context work * added RunLuisGen to luis_functions * updated add skill script * updated template script * updated vsix * more VA and skill template changes that use the latest skills package changes * [4.4]fix build failure and ignore zip files (#1150) * fix build failure and ignore zip files * remove source reference for skills and solutions package from skills solution * added remove skill script (#1153) * removed qna complete message (#1156) * [Virtual Assistant Template][C#] Fix Test QnA Maker button (#1149) * Fix Test QnA Maker button * Replicate change in template * fix scope issue (#1162) * [4.4] Dispatch updates for actions and slots (#1159) * dispatch updates * updated mainDialog to fix action invocatoin * Added stylecop ruleset reference to lib * updated template * removed ruleset references * address errors on build server (#1163) * Update Directory.Build.props * Stylecop Updates * Update Directory.Build.props * Added directlinespeech channel handling for IsStartActivity method * Update gettingstarted.md * [Virtual Assistant Template][TypeScript] Add Virtual Assistant Template (#1165) * Add main functionality for the generator assistant, add generator package.json * Add tests for the generator assistant * README for the generator * README with the basic steps to run the generator * Refactor for the generator copier * Template test main structure * Template package.json * Template gitignore file * Implement tslint to template * Add basic configuration for the solution * Add deployment resources * Add new cards * Add dialogs and responses * Add locales * Add services folder * Add startup files and adapter * Add cognitiveModels and skills manifest for the template * Add npm registry * Move template resources * Delete unused files * Fix issue with .npmrc * [BotBuilder-Solutions][TypeScript] Migrate BotBuilder-Solutions and BotBuilder-Skills to libs folder (#1166) * Move botbuilder-skills and botbuilder-solutions to lib/typescript/ folder * Update packages version * Fix issue with event debugger * Add local publish script * refactor skills pkg to have clearer dependencies and best testability (#1167) * Documentation updates (#1169) * highlighted websocket requirement * skill overview updates, getting help * update image * updates * [Virtual Assistant Template][TypeScript] Add README for generated assistant, and update the description prompt (#1170) * Add appsetings placeholder * Delete unnecessary README * Update description prompt * Add next steps for the generated assistant * Add starting assistant steps * Update table of contents * [Virtual Assistant Template][TypeScript] Fix ESLint errors (#1171) * Delete unused resources * Fix ESLint errors * Fix test generator * Update VA documentation (#1175) * Add Virtual Assistant Sample (#1174) * remove typing middleware from skills (#1176) * Grammar fix (#1177) * Update gettingstarted.md * Create readme.md * Rename readme.md to contents.md * Rename contents.md to readme.md * Update readme.md * Update readme.md * Update readme.md * Update readme.md * Update readme.md * Update readme.md * Update readme.md * [4.4] Miscellaneous template updates (#1179) * Fix captialization error with luis.cs files * updated to latest packages * updated skill template packages * added languages param to deploy * skill template updates * include remove skill script in template * change general id in skill template * updated deploy script to support multiple languages * fixed skill template tests * added pwsh min version to scripts * stopped breaking if skill exists * added logic to clean storage account name * updated skill template with clean storage account name * removed extra mainDialog singleton * Update dependencies (#1178) * fix build failure (#1180) * New slot matching behaviour (#1182) * multi-locale support for inlineTriggerUtterances (#1183) * Update readme.md * Update readme.md * Update readme.md * Create get-started.md * added latency telemetry for bot protocols (#1184) * [4,4]update everything to latest skills and solutions package (#1186) * update everything to latest skills and solutions package * add solutions package reference explicitly * support dispatch with skill intents (#1187) * [4.4] Misc. Dispatch fixes (#1188) * updated scripts for single intent per skill * updated template * add latency events for websocket using the latest websocket package (#1189) * fix extra luis call (#1192) * [Virtual Assistant Template][TypeScript] Add generator post methods (#1198) * Add post methods for generator logic * Update related documentation * correct casing on Location slot (#1194) * VA and Skill Template adjustments (#1193) * Update debug landing pages to correct names Fix VA template bug whereby no qna matches result in swallowed messages (no response to user) * update with manifest endpoint * update html * Refactored the testharnesses under virtual-assistant to new directory: (#1185) solutions/testharnesses/android solutions/testharnesses/csharp solutions/testharnesses/typescript * Lamil/4.4 skills deployment (#1201) * added deployment files for all skills * updated skill deployment * va template updates * [4.4] VA Template cleanup (#1202) * added deployment files for all skills * updated skill deployment * va template updates * va template dialog cleanup * Docs Updates (#1197) * ET to VA docs, syntax formatting * update ts steps * typescript addskill gettingstarted * docs refactor * addauth * update root readme * comment updates * more updates * new deployment guids (#1204) * [4.4]di for skills (#1203) * DI for skills * remove props file * fix tests * SkillDialog - don't pass dispatch intent (#1205) * fix skilldialog/action issue * update actions on ards * Update readme.md * added update script (#1206) * make skill http adapter optional (#1207) * updated tests (#1208) * [4.4] Fixes skill template build errors (#1209) * small fixes * fixes for bot controller issue * fixed location for deploy models * updated lib to 4.4 rc (#1212) * [4.4]add auth doc, update skills deployment scripts and package version (#1213) * added skill auth documentation, and other stuff * more fixes on deploy_cognitive_models script * updated va to sdk 4.4 (#1214) * update skill template to sdk4.4 (#1216) * [4.4] update skills to use sdk4.4 (#1218) * 4.4 updates * stylecop * [4.4] Experimental weather skill (#1217) * Add base WeatherSkill (experimental) with LUIS model using a manual sample of the prebuilt weather intent and geography entity. Parsing luis result into skill state. * Added service calls for location & 1 day forecast information * Added card response and formatting into daily/six hour forecast. Added settings property for api key. Added note in experimental skills doc. * Refactore ApiKey to apiKey and removed custom deployment info * [4.4]add buildprops for all solutions (#1220) * add build props files for all solutions * correct folder * correct product property * [4.4] Removed add local skill script (#1219) * fixed deploy scripts to use LuisAuthoringRegion * removed add local script * removed old script * [4.4] Virtual Assistant introduction card & returning user logic (#1221) * Updated sample with new intro cards * Updated template with sample changes * skill manifest (#1222) * Update NuGet.Config * Update NuGet.Config * Update NuGet.Config * Update NuGet.Config * Add files via upload * Add files via upload * Update README.md * [Do not merge][4.4] Merged master into 4.4 (#1224) * Added title/body variables to returning user greeting card (#1074) * [Virtual Assistant][TypeScript] Rename Botbuilder libraries (#1080) * Rename botbuilder-skill dependency * Rename botbuilder-solution dependency * Update references to those dependencies * [Calendar] fix some new adaptive card issue (#1069) * change card background structure and add duration in card * remove user photo in general meeting list card * add no participants card * Fixed satellite assembly reference that overwrote neutral culture with first localized culture (#1093) * [VA] Resolve card localization bug that defaults to English (#1095) * Add local solutions ref * Moved cards to card directory. Renamed zh-cn to zh ref for EscalateStrings * Updated italian/chinese responses and embedded resource refs for main dialog responses * Updated projects to latest solutions nuget ref * Update VirtualAssistant.sln * Update VirtualAssistant.sln * Update VirtualAssistant.csproj * Reference SpeechUtility in all Skills that have custom implementation of speak property (#1077) * Added responseutility to solutions with ListToSpeechReadyString methods to enable developers to pass in promptoptions or an activity and get a converted speech ready string. Replaced similar functionality in Automotive and POI Skill. * Updated POI limit size to 3 to better reflect speech friendliness and formatted card options to be name of POI or name & address if there are multiple matching. * Renamed ResponseUtility to SpeechUtility If list is last item said, use "last" rather than enumerate * Renamed ReadType enum to ReadPreference with Enumeration and Chronological * Email skill uses speechutility * Updated CalendarSkil with speechutility * Added first set of speech utility tests * Added notes on unit test * Fixed speech utlility test to pass correct adaptive card obj * added addl speech utility tests * Removed bot.builder.solutions local * Updated all refs to latest solutions myget * close data tag * Fixed solution refs * Update VirtualAssistant.sln * Restore "more" to CommonStrings * Added initial automotive card * update cards * Updated auto tests & and updated refs to latest solutions package * fix bugs (#1103) * [Templates][TypeScript] Ignore completed-doc rule (#1109) * Ignore complete-doc rule for Enterprise Bot Template * Update Enterprise Bot sample * Ignore complete-doc rule for Skill Template * Add productivity skill project references back (#1112) * [Calendar] new flow update (#1111) * add read out rest participants step * update wording * update summary wording * add more participants prompt * add try catch for steps * fix test * [Email] new flow updates (#1107) * fix new flow updates * fix comments * Create CODEOWNERS (#1134) Added codeowners file * [Email]Contact finding flow refactor in Email and add "add more recipients" support (#1123) * refactor half of contact finding * refactor find contact * add support * fix ut * [POI] Various conversational enhancements for demos (#1155) * Renamed categories to classifications for Search API consumption (categories will be deprecated May 1) Filtering search results to allow for Geography results to enable user providing current locations like "Seattle washingtton" or "london UK" * Added classes to consume new Classifications category replacing Categories * categorry friendly name * Updated prompt for current location to hint for a city or address. Filtering the fuzzy search with no coordinates to only return geography/point address results. * Remove extra current location prompt responses * Merged prompts and attachments to single activity for better conversational experience * Fixed Speak variable property on returning user greeting * Consolidated Street/City POI properties to Address to map to FreeformAddress/FormattedAddress from Azure Maps/Foursquare * Adjusted logic of filtering POI results - the skill will filter out POIs with matching addresses and only show the first (as it's the highest ranked) Added EntityType property to SearchResult in case that is useful . If a POI name is missing, it's safe to assume that its just a geographical location so we use the address as name. * Using the Foursquare explore API to return results ordered by distance and search for all properties of a POI, not just the name * Updated unit tests with latest dialog changes * Updated transcript with latest functionality * Create CONTRIBUTING.md * Updated power bi sample with EventTelemtry App Insights query. (#1157) New Overall Usage tab. New LUIS Intents tab. * [POI] Use Foursquare best photo with specified dimensions (#1158) * Foursquare best photo is set to 440x240 dimensions, same as Azure Maps photo. * fix test * Create CODE_OF_CONDUCT.md (#1160) Adding recommended code of conduct per community standards checklist * Added directlinespeech channel to IsStartActivity function to test intro card on speech channel. * Update master branch to latest solutions reference enabling directlinespeech channel on startup (#1164) * Fixed the issue of project not loading as it was referencing a wrong Bot Builder Project. (#1190) * update training utterances (#1195) * Add files via upload Add Bot Framework Solutions header * Update README.md * Add files via upload * Add files via upload * Updated README.md with the correct links (#1215) Few of the links were broken so I managed to fix all of them except for the General.cs * merged auto skill * merged calendar * updated email skill * updated poi skill * updated todo skill * removed old skills files * restored ts files * removed extra ts files * ts files * ts generators * skill template ts * va template fixes * Lamil/4.4 stylecop (#1225) * stylecop fixes in vasample and vatemplate * stylecop fixes for test projs * updated ruleset in props * removed httptransport * updated skill tests * updated build props ruleset * suppressed keyValut warnings in templates * skill test warning fix * renamed va solution * fixed stylecop in skills.sln * [Botskills][TypeScript] Implement Skill CLI Tool (#1085) * Add first spike for Skill CLI Tool * Fix issues * Remove '--prefix' argument * Update dependencies, adding TSLint and Mocha, update scripts * Continue implementing CLI Tool * Fix TSLint warning and add comment * Rename tool, modularize logic in botskills-connect * Add botskills-list logic * Add initial documentation * Fix TSLint warnings and refactor a message * Implement Logger, replace all console.log for using Logger * Add botskills disconnect logic * Add detailed documentation for each command * Add TSLint as prebuild task * Move README file, add links to commands' documentation * Implement remote skill manifest invocation, add new option to distinguish path from url * Implement path.extname, extend logger functionality for success messages * Implement functionality to update dispatch, add documentation, update models * Add handler to execute dispatch * Start refactor of structure, refactor connectSkills * Refactor disconnect, fix logger in connect * Update documentation * Finish updating and fixing latest changes for connecting and disconnecting a skill * Refactor list command, unify skillManifest models * Start implementation for authentication * Add index for exposing tool functionality as library * Add 'cs' and 'ts' argument to commands, customize paths on the assistant languages * Add reply-urls to ensure correct redirect to token's bot * Clean comments, move models to models folder * Add logic to keep existent Reply URLs in the app * Fix few TSLint warnings * Implement dispatch to disconnect command, update models and validations * [4/4] Lamil/4.4 broken build (#1228) * build errors * Fix stylecop and broken tests * updated lib to 4.4 (#1227) * [4.4] Updated VSIX descriptions and added file headers (#1226) * added file headers * updated va template description * added headers to skill template * updated skill tests with headers + stylecop * updated skill template descriptions * updated skill template readme * updated va template readme * update auth diagram (#1223) * Lamil/4.4 sdk updates (#1234) * updated vs to public 4.4 sdk * updated skill temp to public 4.4 sdk * updated skills to public 4.4 sdk * updated to latest ai packages * skills packages updates * updated to latest ai packages * updated skills to AI lib preview1 * updated skill template to AI lib preview1 * updated va to AI lib preview1 * updated vsix publisher * removed extra using statement * Add botskills to rush build flow (#1233) * added dependencies to AI Lib (#1235) * Lamil/update packages (#1237) * removed experimental feed * removed nuget.config * removed template files from slns * fix vsix asset type (#1238) * Fix PkgDef stuff (#1239) * fix vsix asset type * more changes * Fix skill template (#1240) * fix vsix asset type * more changes * skill template fixes * Update source.extension.vsixmanifest * vsix updates (#1243) * [4.4] Updated template icons * [4.4] Updates VSIX assembly info * [4.4] Added icon to VSIX * [4.4] Updated VSIX id * Add script to update version and build all typescript projects (#1244) * [Virtual Assistant Template][TypeScript] Use of 4.3.4 version for botbuilder libraries (#1245) * Update template with new changes on botbuilder-skills * Update sample with new changes on botbuilder-skills * Darrenj/docs0502 (#1242) * new skillarchitecture, flow docs * addskills updates * remove * updates * correction * update to skill docs * [4.4] README with packages and quickstar va tutorial (#1247) * Refresjed READMEs and the Quickstart: Create your first Virtual Assistant tutorial * remove typescript instruction from c# doc * Update README.md * Update readme.md * nuspec file (#1250) * [build] Use different versions for CLI tool and botbuilder-* libraries (#1249) * Use different versions for CLI tool and botbuilder-* libraries * Use CLI version for generator-botbuilder-assistant * Disable package on build (#1251) * nuspec file * project change * Remove other package on build (#1252) * nuspec file * project change * disable package on build * NUspec update (#1253) * nuspec file * project change * disable package on build * update nuspec * Remove --cs and --ts args and refactor validations (#1248) * updated to deployment scripts * Update README.md * Update README.md * Typescript generator deployment updates (#1257) * casing issues * fix * docs (#1259) * [4.4.] Customizing VA & creating skill doc (#1258) * Updated customizing assistant and creating a skill docs * minor edits * renamed advanced to howto and updated files and links (#1261) * [BotBuilder-Skills][TypeScript] Update with latest changes (#1263) * Add dependency and temporal registry * Add new classes * Add auth methods * Implement skillHttpAdapter * Fix issue with skillDialog * Fix TSLint issues * Add WebSocket implementation * Add WebSocket implementation * Fix TSLint issues * Latest changes * Fix npm-shrinkwrap.json * [VA Template][TypeScript] Update deployment scripts (#1262) * Update deployment scripts * TSLint - avoid DispatchLuis.ts * Update build script with the dirty, dirty, hack (#1264) * [Skill Template][TypeScript] Add Skill Template (#1200) * Remove generator skill from Skill-Template folder * Add README referencing to the new location of the Skill Template (subgenerator) * Update related documentacion for the generator * Add deployment folder * Add dialog and responses * Add services folder * Add startup files * Add package.json, tslint.json, tsconfig.json, gitignore and npmrc * Add models and bots folder * Add main logic for the generator skill * Update generator keywords * Updating myget reference * Update botbuilder libraries * Make dynamic solutionName and skill filenames * Fix deployment scripts * Fit and finish Skill Template * update sdk version (#1256) * update to 4.4.3 for botbuilder sdk (#1265) * update to copyright header (#1266) * emphasise deployment steps and skill pwsh back (#1267) * Darrenj/tsdocupdates (#1268) * emphasise deployment steps and skill pwsh back * ts doc updates * update package versions for skills (#1270)
lzc850612
added a commit
that referenced
this pull request
Jul 31, 2019
* added microsoft.bot.builder.skills proj and virtual assistant template proj * Foundational SkillDialog and Adapter from remote invocation sample * SkillController * add locale bots files to copy (#1009) (#1010) * make adapters transient (#1011) * use skillController for all skills * update skillController * updated to use appsettings and support multi locale (#1030) * [4.4 VA Template] Add skill invocation code (#1031) * updated to skills project * added skills config and supporting code * update skill adapter * update startup for skills to add middlewares for skilladapter (#1040) * update startup for skills to add middlewares for skilladapter * update aspnetcore version * remove aspnetcore version * remove default coordinates setting * First pass of a SkillManifest model. (#1041) * First pass of a SkillManifest model. Comments across Skill implementation * Basic manifest deserialization test * build fix * Added SkillMiddleware placeholder in readiness for the slot functionality * [4.4 VA Template] Folder restructure, startup.cs cleanup, MVC change (#1043) * removed files * folder cleanup * startup, controller, bot, adapter cleanup * fixed namespaces * [4.4 VA Template] First pass at deployment scripts (#1045) * added deployment files * cleanup * added original general model back * Tedlee/enable skill auth (#1046) * update startup for skills to add middlewares for skilladapter * update aspnetcore version * remove aspnetcore version * remove default coordinates setting * enable auth for skill invocation * leftout conflict * actually add authentication * change api/skill/messages API to Task instead of IActionResult * [4.4] Updated todo skill to new folder structure + config (#1051) * cleanup * to do skill refactor * updates to todo skill folder structure + new config * updates to VA template * removed old deployment files * fixed merge issues * updated mbbs version * [4.4] Updates POI skill to new folder structure + config (#1054) * updated poi skill folders + config * fixed merge issues * Tedlee/dependency injection change (#1057) * update startup for skills to add middlewares for skilladapter * update aspnetcore version * remove aspnetcore version * remove default coordinates setting * enable auth for skill invocation * leftout conflict * actually add authentication * change api/skill/messages API to Task instead of IActionResult * dependency change on bot controller * change to IServiceProvider for JwtClaimAuthProvider.cs * startup leftover * bot controller leftover * todo bot controller leftover * more leftovers * update solutions package version * [4.4] Email skill folder restructure + config (#1061) * removed old deployment scripts * email skill started * va template cleanup * more todo cleanup * poi cleanup * todo stylecop * email folder restructure and config * updates to calendar skill (#1063) * fixed merge conflicts * [4.4] Update experimental skills folder structure + config (#1065) * updated news skill * updated restaurant skill * [4.4] Automotive Skill folder restructure + config (#1067) * updated auto skill * readme * [4.4]enable oauth (#1070) * enable oauth * latest card changes * make it work * added OAuthConnection (#1071) * Skill Manifest Update Generation * added todo skill oauth (#1072) * added botsettingsbase.cs (#1073) * Refined skill manifest generator Move to BotSettingsBase manifest stubs * added botsettings back * Manifest generation tests changes to enable mocking Added central stylecop rulset and added to projects addressed main warnings * removed class * fix automotive skill build issue * added namespaces * [4.4] Fixes test projects (#1083) * updated va template tests * updated todo skill tests * updates to poi * email skill tests * removed mbbs nuget reference * automotive skill tests * poi skill tests * updated skill lib tests * started calendar skill tests * fixed timezone tests * commented 4 calendar skill tests that broke state * fixed merge conflicts * removed assistant and assistant.tests projects * Tedlee/redo libs (#1084) * remove shared package and make skill reference to solutions package * revert skills.json change * updated to use manifest instead of skillDefinition (#1087) * build fix * add logout handling (#1088) * [4.4] Added va_add_remote_skill.ps1 (#1096) * updated to deployment files * update dispatchluis.cs * Update DispatchLuis.cs * changes that get us closer to nuget packages (#1097) * Tedlee/separate dependency auth (#1094) * separate the initialization of MultiProviderAuthDialog out of SkillDialog * make comments better * make comments even better * Skill support for Slot Filling and Skill/Action wiring for SkillDialog (#1098) * Slot Filling implementation and changes to how we wire up Skills+Actions * tweak to test * PR comment changes Moved to one SkillDialog per Skill and use DialogOptions for the ActionId * addressing warnings * merge issue * moved folders (#1100) * loosen checks on SkillDialog BeginDialog logic (#1101) * Skill Middleware (#1104) * Skill Middleware to retrieve events Tests to validate Skill Middleware Skill Middleware added to all skills Removed old Skill Tests from Solutions project General stylecop warnings fixes * populate skillcontext inside skill * remove fakeskill from solutions.tests * fix bug with maindialog and push logic to identify skill from dispatch intent to helper class in Skills library. (#1110) * [4.4] VA Template VSIX (#1106) * added deployment files to va template * moved deployment * added vsix and sample * commented action check in skillDialog * added redirect url to az ad create command * slots workaround * removed pid prefix from deployment guid * updated defoult outFolder for scripts to cd location * deployment updates * added check for scopes * suppressed output in script * updated skill manifests (#1113) * added build scripts * fix version reference on mvc (#1116) * fix for broken skills package (#1117) * [4.4] Lib changes (#1118) * fix for broken skills package * updates to packages to support parent intents * Update DispatchLuis.cs * [4.4] enable websocket (#1120) * enable http&websocket transport for bot-bot call * leave only skills package change. fix build failures in test * remove skill constants * Addes Nuget.Config to lib folder * Update NuGet.Config * Update Microsoft.Bot.Builder.Skills.csproj * Update NuGet.Config * Update SkillDialog.cs * [4.4]fix existing tests (#1125) * fix existing tests * switch to project reference instead of package for solutions * removed dependency on responseManager argument (#1127) * [4.4] Updated lib tests * Update NuGet.Config * enable websocket for skills by referencing the latest skills package (#1128) * slot matching trace (#1131) * added manifest validation to protect against malformed manifest template files (#1130) * fix calendar skill reference (#1132) * fix calendar skill reference * add botbuilder nuget feed * [4.4] Skill Template (#1124) * va template updates * updated va template vsix * removed src folder * added new skill template * [4.4 VA Template] dependency injection updates (#1133) * dependency injection changes * added comment for adaptive card button * upgrade protocol lib to take in the latest fix (#1136) * fix token response issue where it's not getting to the skill properly if no auth dialog needed (#1137) * add AuthenticationProvider to support ms skills first (#1138) * adding missing skill tracing logs for emulator (#1140) * populate state from skillcontext (#1141) * [4.4] added new intro cards to VA template (#1144) * added new intro cards to va template * fixed gitignore * 4.4 Documentation (#1139) * new deployment steps and doc outline * updated progress * adding skills * updated skill docs * skill docs * add skills to v4 bots * add skill support to bot and skill enabling a bot * more skill docs * additonal add skill commands * link fix * Updated readme * Address final stylecop warnings in Skills/Solutions nuget (#1147) * fix warnings update to enable warnings as errors * updated to new location of websocket packages * update to pass valid dummy app credentials for tests * update to experimental feed * updated package location * [DO NOT MERGE][4.4] Template updates (#1143) * update lg file name * updated to skill manifest * dependency injection updates in skill template * removed oauth default value * updated deployment scripts * updated skill context work * added RunLuisGen to luis_functions * updated add skill script * updated template script * updated vsix * more VA and skill template changes that use the latest skills package changes * [4.4]fix build failure and ignore zip files (#1150) * fix build failure and ignore zip files * remove source reference for skills and solutions package from skills solution * added remove skill script (#1153) * removed qna complete message (#1156) * [Virtual Assistant Template][C#] Fix Test QnA Maker button (#1149) * Fix Test QnA Maker button * Replicate change in template * fix scope issue (#1162) * [4.4] Dispatch updates for actions and slots (#1159) * dispatch updates * updated mainDialog to fix action invocatoin * Added stylecop ruleset reference to lib * updated template * removed ruleset references * address errors on build server (#1163) * Update Directory.Build.props * Stylecop Updates * Update Directory.Build.props * Added directlinespeech channel handling for IsStartActivity method * Update gettingstarted.md * [Virtual Assistant Template][TypeScript] Add Virtual Assistant Template (#1165) * Add main functionality for the generator assistant, add generator package.json * Add tests for the generator assistant * README for the generator * README with the basic steps to run the generator * Refactor for the generator copier * Template test main structure * Template package.json * Template gitignore file * Implement tslint to template * Add basic configuration for the solution * Add deployment resources * Add new cards * Add dialogs and responses * Add locales * Add services folder * Add startup files and adapter * Add cognitiveModels and skills manifest for the template * Add npm registry * Move template resources * Delete unused files * Fix issue with .npmrc * [BotBuilder-Solutions][TypeScript] Migrate BotBuilder-Solutions and BotBuilder-Skills to libs folder (#1166) * Move botbuilder-skills and botbuilder-solutions to lib/typescript/ folder * Update packages version * Fix issue with event debugger * Add local publish script * refactor skills pkg to have clearer dependencies and best testability (#1167) * Documentation updates (#1169) * highlighted websocket requirement * skill overview updates, getting help * update image * updates * [Virtual Assistant Template][TypeScript] Add README for generated assistant, and update the description prompt (#1170) * Add appsetings placeholder * Delete unnecessary README * Update description prompt * Add next steps for the generated assistant * Add starting assistant steps * Update table of contents * [Virtual Assistant Template][TypeScript] Fix ESLint errors (#1171) * Delete unused resources * Fix ESLint errors * Fix test generator * Update VA documentation (#1175) * Add Virtual Assistant Sample (#1174) * remove typing middleware from skills (#1176) * Grammar fix (#1177) * Update gettingstarted.md * Create readme.md * Rename readme.md to contents.md * Rename contents.md to readme.md * Update readme.md * Update readme.md * Update readme.md * Update readme.md * Update readme.md * Update readme.md * Update readme.md * [4.4] Miscellaneous template updates (#1179) * Fix captialization error with luis.cs files * updated to latest packages * updated skill template packages * added languages param to deploy * skill template updates * include remove skill script in template * change general id in skill template * updated deploy script to support multiple languages * fixed skill template tests * added pwsh min version to scripts * stopped breaking if skill exists * added logic to clean storage account name * updated skill template with clean storage account name * removed extra mainDialog singleton * Update dependencies (#1178) * fix build failure (#1180) * New slot matching behaviour (#1182) * multi-locale support for inlineTriggerUtterances (#1183) * Update readme.md * Update readme.md * Update readme.md * Create get-started.md * added latency telemetry for bot protocols (#1184) * [4,4]update everything to latest skills and solutions package (#1186) * update everything to latest skills and solutions package * add solutions package reference explicitly * support dispatch with skill intents (#1187) * [4.4] Misc. Dispatch fixes (#1188) * updated scripts for single intent per skill * updated template * add latency events for websocket using the latest websocket package (#1189) * fix extra luis call (#1192) * [Virtual Assistant Template][TypeScript] Add generator post methods (#1198) * Add post methods for generator logic * Update related documentation * correct casing on Location slot (#1194) * VA and Skill Template adjustments (#1193) * Update debug landing pages to correct names Fix VA template bug whereby no qna matches result in swallowed messages (no response to user) * update with manifest endpoint * update html * Refactored the testharnesses under virtual-assistant to new directory: (#1185) solutions/testharnesses/android solutions/testharnesses/csharp solutions/testharnesses/typescript * Lamil/4.4 skills deployment (#1201) * added deployment files for all skills * updated skill deployment * va template updates * [4.4] VA Template cleanup (#1202) * added deployment files for all skills * updated skill deployment * va template updates * va template dialog cleanup * Docs Updates (#1197) * ET to VA docs, syntax formatting * update ts steps * typescript addskill gettingstarted * docs refactor * addauth * update root readme * comment updates * more updates * new deployment guids (#1204) * [4.4]di for skills (#1203) * DI for skills * remove props file * fix tests * SkillDialog - don't pass dispatch intent (#1205) * fix skilldialog/action issue * update actions on ards * Update readme.md * added update script (#1206) * make skill http adapter optional (#1207) * updated tests (#1208) * [4.4] Fixes skill template build errors (#1209) * small fixes * fixes for bot controller issue * fixed location for deploy models * updated lib to 4.4 rc (#1212) * [4.4]add auth doc, update skills deployment scripts and package version (#1213) * added skill auth documentation, and other stuff * more fixes on deploy_cognitive_models script * updated va to sdk 4.4 (#1214) * update skill template to sdk4.4 (#1216) * [4.4] update skills to use sdk4.4 (#1218) * 4.4 updates * stylecop * [4.4] Experimental weather skill (#1217) * Add base WeatherSkill (experimental) with LUIS model using a manual sample of the prebuilt weather intent and geography entity. Parsing luis result into skill state. * Added service calls for location & 1 day forecast information * Added card response and formatting into daily/six hour forecast. Added settings property for api key. Added note in experimental skills doc. * Refactore ApiKey to apiKey and removed custom deployment info * [4.4]add buildprops for all solutions (#1220) * add build props files for all solutions * correct folder * correct product property * [4.4] Removed add local skill script (#1219) * fixed deploy scripts to use LuisAuthoringRegion * removed add local script * removed old script * [4.4] Virtual Assistant introduction card & returning user logic (#1221) * Updated sample with new intro cards * Updated template with sample changes * skill manifest (#1222) * Update NuGet.Config * Update NuGet.Config * Update NuGet.Config * Update NuGet.Config * Add files via upload * Add files via upload * Update README.md * [Do not merge][4.4] Merged master into 4.4 (#1224) * Added title/body variables to returning user greeting card (#1074) * [Virtual Assistant][TypeScript] Rename Botbuilder libraries (#1080) * Rename botbuilder-skill dependency * Rename botbuilder-solution dependency * Update references to those dependencies * [Calendar] fix some new adaptive card issue (#1069) * change card background structure and add duration in card * remove user photo in general meeting list card * add no participants card * Fixed satellite assembly reference that overwrote neutral culture with first localized culture (#1093) * [VA] Resolve card localization bug that defaults to English (#1095) * Add local solutions ref * Moved cards to card directory. Renamed zh-cn to zh ref for EscalateStrings * Updated italian/chinese responses and embedded resource refs for main dialog responses * Updated projects to latest solutions nuget ref * Update VirtualAssistant.sln * Update VirtualAssistant.sln * Update VirtualAssistant.csproj * Reference SpeechUtility in all Skills that have custom implementation of speak property (#1077) * Added responseutility to solutions with ListToSpeechReadyString methods to enable developers to pass in promptoptions or an activity and get a converted speech ready string. Replaced similar functionality in Automotive and POI Skill. * Updated POI limit size to 3 to better reflect speech friendliness and formatted card options to be name of POI or name & address if there are multiple matching. * Renamed ResponseUtility to SpeechUtility If list is last item said, use "last" rather than enumerate * Renamed ReadType enum to ReadPreference with Enumeration and Chronological * Email skill uses speechutility * Updated CalendarSkil with speechutility * Added first set of speech utility tests * Added notes on unit test * Fixed speech utlility test to pass correct adaptive card obj * added addl speech utility tests * Removed bot.builder.solutions local * Updated all refs to latest solutions myget * close data tag * Fixed solution refs * Update VirtualAssistant.sln * Restore "more" to CommonStrings * Added initial automotive card * update cards * Updated auto tests & and updated refs to latest solutions package * fix bugs (#1103) * [Templates][TypeScript] Ignore completed-doc rule (#1109) * Ignore complete-doc rule for Enterprise Bot Template * Update Enterprise Bot sample * Ignore complete-doc rule for Skill Template * Add productivity skill project references back (#1112) * [Calendar] new flow update (#1111) * add read out rest participants step * update wording * update summary wording * add more participants prompt * add try catch for steps * fix test * [Email] new flow updates (#1107) * fix new flow updates * fix comments * Create CODEOWNERS (#1134) Added codeowners file * [Email]Contact finding flow refactor in Email and add "add more recipients" support (#1123) * refactor half of contact finding * refactor find contact * add support * fix ut * [POI] Various conversational enhancements for demos (#1155) * Renamed categories to classifications for Search API consumption (categories will be deprecated May 1) Filtering search results to allow for Geography results to enable user providing current locations like "Seattle washingtton" or "london UK" * Added classes to consume new Classifications category replacing Categories * categorry friendly name * Updated prompt for current location to hint for a city or address. Filtering the fuzzy search with no coordinates to only return geography/point address results. * Remove extra current location prompt responses * Merged prompts and attachments to single activity for better conversational experience * Fixed Speak variable property on returning user greeting * Consolidated Street/City POI properties to Address to map to FreeformAddress/FormattedAddress from Azure Maps/Foursquare * Adjusted logic of filtering POI results - the skill will filter out POIs with matching addresses and only show the first (as it's the highest ranked) Added EntityType property to SearchResult in case that is useful . If a POI name is missing, it's safe to assume that its just a geographical location so we use the address as name. * Using the Foursquare explore API to return results ordered by distance and search for all properties of a POI, not just the name * Updated unit tests with latest dialog changes * Updated transcript with latest functionality * Create CONTRIBUTING.md * Updated power bi sample with EventTelemtry App Insights query. (#1157) New Overall Usage tab. New LUIS Intents tab. * [POI] Use Foursquare best photo with specified dimensions (#1158) * Foursquare best photo is set to 440x240 dimensions, same as Azure Maps photo. * fix test * Create CODE_OF_CONDUCT.md (#1160) Adding recommended code of conduct per community standards checklist * Added directlinespeech channel to IsStartActivity function to test intro card on speech channel. * Update master branch to latest solutions reference enabling directlinespeech channel on startup (#1164) * Fixed the issue of project not loading as it was referencing a wrong Bot Builder Project. (#1190) * update training utterances (#1195) * Add files via upload Add Bot Framework Solutions header * Update README.md * Add files via upload * Add files via upload * Updated README.md with the correct links (#1215) Few of the links were broken so I managed to fix all of them except for the General.cs * merged auto skill * merged calendar * updated email skill * updated poi skill * updated todo skill * removed old skills files * restored ts files * removed extra ts files * ts files * ts generators * skill template ts * va template fixes * Lamil/4.4 stylecop (#1225) * stylecop fixes in vasample and vatemplate * stylecop fixes for test projs * updated ruleset in props * removed httptransport * updated skill tests * updated build props ruleset * suppressed keyValut warnings in templates * skill test warning fix * renamed va solution * fixed stylecop in skills.sln * [Botskills][TypeScript] Implement Skill CLI Tool (#1085) * Add first spike for Skill CLI Tool * Fix issues * Remove '--prefix' argument * Update dependencies, adding TSLint and Mocha, update scripts * Continue implementing CLI Tool * Fix TSLint warning and add comment * Rename tool, modularize logic in botskills-connect * Add botskills-list logic * Add initial documentation * Fix TSLint warnings and refactor a message * Implement Logger, replace all console.log for using Logger * Add botskills disconnect logic * Add detailed documentation for each command * Add TSLint as prebuild task * Move README file, add links to commands' documentation * Implement remote skill manifest invocation, add new option to distinguish path from url * Implement path.extname, extend logger functionality for success messages * Implement functionality to update dispatch, add documentation, update models * Add handler to execute dispatch * Start refactor of structure, refactor connectSkills * Refactor disconnect, fix logger in connect * Update documentation * Finish updating and fixing latest changes for connecting and disconnecting a skill * Refactor list command, unify skillManifest models * Start implementation for authentication * Add index for exposing tool functionality as library * Add 'cs' and 'ts' argument to commands, customize paths on the assistant languages * Add reply-urls to ensure correct redirect to token's bot * Clean comments, move models to models folder * Add logic to keep existent Reply URLs in the app * Fix few TSLint warnings * Implement dispatch to disconnect command, update models and validations * [4/4] Lamil/4.4 broken build (#1228) * build errors * Fix stylecop and broken tests * updated lib to 4.4 (#1227) * [4.4] Updated VSIX descriptions and added file headers (#1226) * added file headers * updated va template description * added headers to skill template * updated skill tests with headers + stylecop * updated skill template descriptions * updated skill template readme * updated va template readme * update auth diagram (#1223) * Lamil/4.4 sdk updates (#1234) * updated vs to public 4.4 sdk * updated skill temp to public 4.4 sdk * updated skills to public 4.4 sdk * updated to latest ai packages * skills packages updates * updated to latest ai packages * updated skills to AI lib preview1 * updated skill template to AI lib preview1 * updated va to AI lib preview1 * updated vsix publisher * removed extra using statement * Add botskills to rush build flow (#1233) * added dependencies to AI Lib (#1235) * Lamil/update packages (#1237) * removed experimental feed * removed nuget.config * removed template files from slns * fix vsix asset type (#1238) * Fix PkgDef stuff (#1239) * fix vsix asset type * more changes * Fix skill template (#1240) * fix vsix asset type * more changes * skill template fixes * Update source.extension.vsixmanifest * vsix updates (#1243) * [4.4] Updated template icons * [4.4] Updates VSIX assembly info * [4.4] Added icon to VSIX * [4.4] Updated VSIX id * Add script to update version and build all typescript projects (#1244) * [Virtual Assistant Template][TypeScript] Use of 4.3.4 version for botbuilder libraries (#1245) * Update template with new changes on botbuilder-skills * Update sample with new changes on botbuilder-skills * Darrenj/docs0502 (#1242) * new skillarchitecture, flow docs * addskills updates * remove * updates * correction * update to skill docs * [4.4] README with packages and quickstar va tutorial (#1247) * Refresjed READMEs and the Quickstart: Create your first Virtual Assistant tutorial * remove typescript instruction from c# doc * Update README.md * Update readme.md * nuspec file (#1250) * [build] Use different versions for CLI tool and botbuilder-* libraries (#1249) * Use different versions for CLI tool and botbuilder-* libraries * Use CLI version for generator-botbuilder-assistant * Disable package on build (#1251) * nuspec file * project change * Remove other package on build (#1252) * nuspec file * project change * disable package on build * NUspec update (#1253) * nuspec file * project change * disable package on build * update nuspec * Remove --cs and --ts args and refactor validations (#1248) * updated to deployment scripts * Update README.md * Update README.md * Typescript generator deployment updates (#1257) * casing issues * fix * docs (#1259) * [4.4.] Customizing VA & creating skill doc (#1258) * Updated customizing assistant and creating a skill docs * minor edits * renamed advanced to howto and updated files and links (#1261) * [BotBuilder-Skills][TypeScript] Update with latest changes (#1263) * Add dependency and temporal registry * Add new classes * Add auth methods * Implement skillHttpAdapter * Fix issue with skillDialog * Fix TSLint issues * Add WebSocket implementation * Add WebSocket implementation * Fix TSLint issues * Latest changes * Fix npm-shrinkwrap.json * [VA Template][TypeScript] Update deployment scripts (#1262) * Update deployment scripts * TSLint - avoid DispatchLuis.ts * Update build script with the dirty, dirty, hack (#1264) * [Skill Template][TypeScript] Add Skill Template (#1200) * Remove generator skill from Skill-Template folder * Add README referencing to the new location of the Skill Template (subgenerator) * Update related documentacion for the generator * Add deployment folder * Add dialog and responses * Add services folder * Add startup files * Add package.json, tslint.json, tsconfig.json, gitignore and npmrc * Add models and bots folder * Add main logic for the generator skill * Update generator keywords * Updating myget reference * Update botbuilder libraries * Make dynamic solutionName and skill filenames * Fix deployment scripts * Fit and finish Skill Template * update sdk version (#1256) * update to 4.4.3 for botbuilder sdk (#1265) * update to copyright header (#1266) * emphasise deployment steps and skill pwsh back (#1267) * Darrenj/tsdocupdates (#1268) * emphasise deployment steps and skill pwsh back * ts doc updates * update package versions for skills (#1270)
This was referenced Aug 19, 2022
This was referenced Aug 19, 2022
This was referenced Aug 20, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.