Skip to content
This repository has been archived by the owner on Jun 30, 2022. It is now read-only.

[4.4]fix skillcontroller #1207

Merged
merged 2 commits into from
May 1, 2019
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -27,18 +27,17 @@ public abstract class SkillController : ControllerBase
private readonly JsonSerializer _jsonSerializer = JsonSerializer.Create(Serialization.Settings);

public SkillController(
IBotFrameworkHttpAdapter botFrameworkHttpAdapter,
SkillHttpAdapter skillHttpAdapter,
SkillWebSocketAdapter skillWebSocketAdapter,
IBot bot,
BotSettingsBase botSettings)
{
_botFrameworkHttpAdapter = botFrameworkHttpAdapter ?? throw new ArgumentNullException(nameof(IBotFrameworkHttpAdapter));
_skillHttpAdapter = skillHttpAdapter;
_skillWebSocketAdapter = skillWebSocketAdapter;

_bot = bot ?? throw new ArgumentNullException(nameof(IBot));
_botSettings = botSettings ?? throw new ArgumentNullException(nameof(botSettings));
BotSettingsBase botSettings,
IBotFrameworkHttpAdapter botFrameworkHttpAdapter,
SkillWebSocketAdapter skillWebSocketAdapter,
SkillHttpAdapter skillHttpAdapter = null)
{
_bot = bot ?? throw new ArgumentNullException(nameof(IBot));
_botSettings = botSettings ?? throw new ArgumentNullException(nameof(botSettings));
_botFrameworkHttpAdapter = botFrameworkHttpAdapter ?? throw new ArgumentNullException(nameof(IBotFrameworkHttpAdapter));
_skillWebSocketAdapter = skillWebSocketAdapter;
_skillHttpAdapter = skillHttpAdapter;
}

// Each skill provides a template manifest file which we use to fill in the dynamic elements.
Expand Down