Skip to content
This repository has been archived by the owner on Jun 30, 2022. It is now read-only.

Adaptive Cards integration #2261

Closed
5 tasks done
ryanisgrig opened this issue Aug 30, 2019 · 1 comment
Closed
5 tasks done

Adaptive Cards integration #2261

ryanisgrig opened this issue Aug 30, 2019 · 1 comment
Assignees
@chon219
Labels
P0 Must Fix. Release-blocker Type: Bug Something isn't working
Milestone
Vibranium 0.6 Rel...

Comments

@ryanisgrig
Copy link
Collaborator

ryanisgrig commented Aug 30, 2019 •
edited
Loading

  • A user should be able to interact with the clickable containers/columns on Adaptive Cards
    Currently only a root-level select action is enabled
  • Default card appearance should be transparent and use the background of the bot bubble color
    Right now it is always white, no matter the app:cardBackgroundColor set on item_adaptive_card.xml
  • Replace the hostconfig.json with empty {} to use default values
  • Investigate and potentially replace the HorizontalScrollView/LinearLayout implementation that allows for carousel Adaptive Cards with a RecyclerView (https://www.android-examples.com/android-horizontal-recyclerview-cardview/), not sure if this is causing an issue with the current rendering.
  • Adaptive Cards should be rendered in separate bubbles from their related text. This will let us scale the card view independent of related messages. See the BF Emulator for an example of how this looks
    image
@ryanisgrig ryanisgrig added this to the Vibranium milestone Aug 30, 2019
@ryanisgrig ryanisgrig added Type: Bug Something isn't working P0 Must Fix. Release-blocker Status: Backlog This will go in the product backlog labels Aug 30, 2019
@chon219 chon219 self-assigned this Sep 2, 2019
@ryanisgrig ryanisgrig added Status: In Progress This work item in underway. and removed Status: Backlog This will go in the product backlog labels Sep 4, 2019
chon219 added a commit that referenced this issue Sep 6, 2019
@chon219
[Android] fixed #2261 adaptive cards rendering issues
dacb663
This was referenced Sep 6, 2019
Closed
Merged
@ryanisgrig ryanisgrig modified the milestones: Vibranium, Vibranium 0.6 Release Sep 10, 2019
chon219 added a commit that referenced this issue Sep 12, 2019
@chon219
Latest Android Updates (#2313)
e55cc94 
* [Android] fixed #2198 conversation history is lost when switching to other apps

* [Android] fixed #2251 Conversation history is lost when screen being rotated

* [Android] replace speech sdk with the one from official maven store

* [Android] use empty hostconfig.json

* [Android] fixed SVG rendering issue

* [Android] fixed #2261 adaptive cards rendering issues

* [Android] new app icon

* resolved merging conflicts

* [Android] revert back to use official adaptive cards sdk
@chon219
Copy link
Member

chon219 commented Sep 12, 2019

Opened another issue #2356
Closing this one.

@chon219 chon219 closed this as completed Sep 12, 2019
@ryanisgrig ryanisgrig removed the Status: In Progress This work item in underway. label Sep 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@chon219 chon219

Labels
P0 Must Fix. Release-blocker Type: Bug Something isn't working
Projects
None yet
Milestone
Vibranium 0.6 Release
Development

No branches or pull requests
2 participants
@chon219 @ryanisgrig