Skip to content
This repository has been archived by the owner on Jun 30, 2022. It is now read-only.

Implement SVG handling for adaptive Cards #1584

Closed
abiemann opened this issue Jun 17, 2019 · 4 comments
Closed

Implement SVG handling for adaptive Cards #1584

abiemann opened this issue Jun 17, 2019 · 4 comments
Assignees
Labels
Status: Committed This has been confirmed for the next release.

Comments

@abiemann
Copy link
Contributor

port the SVG-related code from Connected Car
see commit 9b1abbe2a0c5d108d5004f73742978014fce13ad

this work depends on Adaptive Card Library release > 1.2

@abiemann abiemann added the Status: Backlog This will go in the product backlog label Jun 17, 2019
@abiemann abiemann self-assigned this Jun 17, 2019
@ryanisgrig ryanisgrig added the Status: Blocked Current progress is blocked label Jul 8, 2019
@ryanisgrig
Copy link
Collaborator

Blocked by Adaptive Cards 1.2 dependency

@Dewain27
Copy link
Contributor

blocked by #1803

@Dewain27 Dewain27 added this to the Vibranium milestone Jul 22, 2019
@ryanisgrig
Copy link
Collaborator

Investigate the 1.2.1 release
https://search.maven.org/search?q=a:adaptivecards-android

@Dewain27 Dewain27 modified the milestones: Vibranium, Vibranium 0.6 Release Aug 12, 2019
@abiemann
Copy link
Contributor Author

I've sent Alberto Medina Gutierrez the following email on 8/13 and CC'd Ryan and Chris:

Dear Alberto,

I've recently discovered the latest Adaptive Card library release 1.2.1 and I wanted to try it out to see if it support SVG's properly.
After updating the project to include the new library, I have found that SVG's are still not rendering in this version of the library - please see the attached images:

EXPECTED RESULT
adaptive_card_designer_vector_image_shown
I've taken the JSON from the Activity and copied it into the designer. The designer shows the SVG (white pointer) in the top-left.

ACTUAL RESULT
AdaptiveCard_1_2_1_rendered
this image shows the rendered result by the Adaptive Cards library 1.2.1

Is there anything I need to do to get the SVG to render properly ?

Regards,
Alexander

Now waiting to hear back

@Dewain27 Dewain27 added Status: Committed This has been confirmed for the next release. Status: In Progress This work item in underway. and removed Status: Backlog This will go in the product backlog Status: Committed This has been confirmed for the next release. Status: In Progress This work item in underway. labels Aug 19, 2019
@abiemann abiemann removed the Status: Blocked Current progress is blocked label Aug 20, 2019
abiemann added a commit to abiemann/botframework-solutions that referenced this issue Aug 20, 2019
@abiemann abiemann mentioned this issue Aug 22, 2019
2 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Status: Committed This has been confirmed for the next release.
Projects
None yet
Development

No branches or pull requests

3 participants