Nigao/newtemplate #323
Merged
Nigao/newtemplate #323
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(1) fix the cancel.lu bug (2) add datetime.lu (2) stringSetdatetime.dialog.lg
…ramework-cli into nigao/newtemplate
…ramework-cli into nigao/newtemplate
chrimc62
added a commit
that referenced
this pull request
Nov 15, 2019
* Intermediate check-in before inverting template/prop loops. * Working generator with incomplete templates. * Basic .lu files working. * Update to generate single .lu file. * Fix cli issues. * Fix CLI issues with template resources. * Clean up lint warnings. * Fix lint errors. * Generate composite .lu * Add dialog and multi-language support. * shortcut to debug * Add per-locale .lg file. * Update debug config to use temp directory. Generate multilingual .lg file. * Update to include schema prefix on names. * Fix bugs in .lg genertion. * try help * help and cancel * Copy schema to output directory. * help and cancel version 1 * separate help.lu * several fixes * remove help enum * reset launch.json * remove empty line * Add the ability to copy library dialog files. * Add ability to specify schema and multiple templates. * Rename resources. Support multiple templates. Add *PROPN** pattern. * Fix bug in striingify call. * Generate schema.main.dialog and update config. * Update templates to newest format. * Update templates to match names. * add .dialogs for several basic rules * Update templates to use $ and add begindialog as a hack to work around ada ptive issue. * add .dialogs for several basic rules * fix comments * merge from origin * small changes * Add formCopy cmd file. * Adjust for bug in templates. * fix path * Version 1 of contact.form.dialog * Same info is modeled for both Home and Work. * List of state abbreviations and their spelled-out names are specified in the separate state.en-us.lu, and used in the $mappings specifications. * Latitude and Longitude should be auto-filled if the corresponding address are filled. * Validation patterns are specified for zip codes and phone numbers. * Fixed contact.form.dialog and added activity.form.dialog * contact.form.dialog - Fixed spelling - Use phonenumber prebuilt entity type * activity.form.dialog: the second scenario from Darren "An employee working for a customer wants to add a quick update to a customer record after a call. This update will then be available for other people working with that customer to see". * Added opportunity.form.dialog For Darren's scenario "An employee working with a customer has had a meeting and needs to create a new opportunity." * change names * Revert "change names" This reverts commit 64ffaff. * change names * basic work done for ask, set and help * cancel confirmation * cancel confirmation done, unexpected property set confirmation in progress * improve unexpected property test * Version 1 of contact.form.dialog * Same info is modeled for both Home and Work. * List of state abbreviations and their spelled-out names are specified in the separate state.en-us.lu, and used in the $mappings specifications. * Latitude and Longitude should be auto-filled if the corresponding address are filled. * Validation patterns are specified for zip codes and phone numbers. * Fixed contact.form.dialog and added activity.form.dialog * contact.form.dialog - Fixed spelling - Use phonenumber prebuilt entity type * activity.form.dialog: the second scenario from Darren "An employee working for a customer wants to add a quick update to a customer record after a call. This update will then be available for other people working with that customer to see". * Added opportunity.form.dialog For Darren's scenario "An employee working with a customer has had a meeting and needs to create a new opportunity." * rename state.lu * prebuilt lu templates * remove choose entity we only have chooseProperty and clarifyEntity * Switch to event expected. * Update templates for latest runtime and add ask for multiple properties. * Add **NAMES/**NAME** and generate property names. * fix unexpected property confirmation usage * change unexpected property action from ask to sendactivity * all done confirmation * Update names to support chooseProperty. * Check-in bread value hack. * Fix template bug around clarify. * Update templates to use names and start numbers. * complete the new forms * contextual help * activity schema working fine * add meta info to opportunity schema * opportunity semi-working cannot use phonenumber; properties not in required also got asked; in stringset, default value is not expression, cannot get the value for @email * three schemas working sandwich, activity, opportunity * contact schema working Adding welcome message in beginDialog, Add help message for non-enum properties, All three CDS schemas working * Sync changes for demo. * Before adding mapping templates * Getting close to E2e. * Largely working with some template debugging. * Update the readme. * Update to latest expression and lg packages. Support app schema. * Update standard schema. * Finish merge. * Show metaschema. * Fix readme typo. * several changes (#299) * several changes (1) remove unused old files; (2) change incorrect file names; (3) add string ask templates; (4) remove meta properties from schemas; (5) fix an error in calculating optional properties * fix help property bug * Add string templates. * a few changes (#318) (1) fix the cancel.lu bug (2) add datetime.lu (2) stringSetdatetime.dialog.lg * Add template for not understood. * Connect to bf cli. * Add basic role support. * Nigao/newtemplate (#321) * a few changes (1) fix the cancel.lu bug (2) add datetime.lu (2) stringSetdatetime.dialog.lg * autohelp for new templates * Update to use @{} everywhere and remove auto-help since it required post-ask action. * Nigao/newtemplate (#323) * a few changes (1) fix the cancel.lu bug (2) add datetime.lu (2) stringSetdatetime.dialog.lg * autohelp for new templates * add $requires, and datetime entity sets * add all stringSet for prebuilt entities explicitly * change prebuilt-entity.lu.lg files * Switch to using a triggerIntent instead of none for entities. Cleanup filename expressions. * Fix bug in status. * Switch from dialog:form to dialog:generate * Add top-level documentation. * Update tests to use dialog:generate. * Rename tests to generator. * Fixing linting errors * Generate confirmation card. * Fix reference regex ot not match structured lg.
ninggao
pushed a commit
that referenced
this pull request
Nov 18, 2019
* Intermediate check-in before inverting template/prop loops. * Working generator with incomplete templates. * Basic .lu files working. * Update to generate single .lu file. * Fix cli issues. * Fix CLI issues with template resources. * Clean up lint warnings. * Fix lint errors. * Generate composite .lu * Add dialog and multi-language support. * shortcut to debug * Add per-locale .lg file. * Update debug config to use temp directory. Generate multilingual .lg file. * Update to include schema prefix on names. * Fix bugs in .lg genertion. * try help * help and cancel * Copy schema to output directory. * help and cancel version 1 * separate help.lu * several fixes * remove help enum * reset launch.json * remove empty line * Add the ability to copy library dialog files. * Add ability to specify schema and multiple templates. * Rename resources. Support multiple templates. Add *PROPN** pattern. * Fix bug in striingify call. * Generate schema.main.dialog and update config. * Update templates to newest format. * Update templates to match names. * add .dialogs for several basic rules * Update templates to use $ and add begindialog as a hack to work around ada ptive issue. * add .dialogs for several basic rules * fix comments * merge from origin * small changes * Add formCopy cmd file. * Adjust for bug in templates. * fix path * Version 1 of contact.form.dialog * Same info is modeled for both Home and Work. * List of state abbreviations and their spelled-out names are specified in the separate state.en-us.lu, and used in the $mappings specifications. * Latitude and Longitude should be auto-filled if the corresponding address are filled. * Validation patterns are specified for zip codes and phone numbers. * Fixed contact.form.dialog and added activity.form.dialog * contact.form.dialog - Fixed spelling - Use phonenumber prebuilt entity type * activity.form.dialog: the second scenario from Darren "An employee working for a customer wants to add a quick update to a customer record after a call. This update will then be available for other people working with that customer to see". * Added opportunity.form.dialog For Darren's scenario "An employee working with a customer has had a meeting and needs to create a new opportunity." * change names * Revert "change names" This reverts commit 64ffaff. * change names * basic work done for ask, set and help * cancel confirmation * cancel confirmation done, unexpected property set confirmation in progress * improve unexpected property test * Version 1 of contact.form.dialog * Same info is modeled for both Home and Work. * List of state abbreviations and their spelled-out names are specified in the separate state.en-us.lu, and used in the $mappings specifications. * Latitude and Longitude should be auto-filled if the corresponding address are filled. * Validation patterns are specified for zip codes and phone numbers. * Fixed contact.form.dialog and added activity.form.dialog * contact.form.dialog - Fixed spelling - Use phonenumber prebuilt entity type * activity.form.dialog: the second scenario from Darren "An employee working for a customer wants to add a quick update to a customer record after a call. This update will then be available for other people working with that customer to see". * Added opportunity.form.dialog For Darren's scenario "An employee working with a customer has had a meeting and needs to create a new opportunity." * rename state.lu * prebuilt lu templates * remove choose entity we only have chooseProperty and clarifyEntity * Switch to event expected. * Update templates for latest runtime and add ask for multiple properties. * Add **NAMES/**NAME** and generate property names. * fix unexpected property confirmation usage * change unexpected property action from ask to sendactivity * all done confirmation * Update names to support chooseProperty. * Check-in bread value hack. * Fix template bug around clarify. * Update templates to use names and start numbers. * complete the new forms * contextual help * activity schema working fine * add meta info to opportunity schema * opportunity semi-working cannot use phonenumber; properties not in required also got asked; in stringset, default value is not expression, cannot get the value for @email * three schemas working sandwich, activity, opportunity * contact schema working Adding welcome message in beginDialog, Add help message for non-enum properties, All three CDS schemas working * Sync changes for demo. * Before adding mapping templates * Getting close to E2e. * Largely working with some template debugging. * Update the readme. * Update to latest expression and lg packages. Support app schema. * Update standard schema. * Finish merge. * Show metaschema. * Fix readme typo. * several changes (#299) * several changes (1) remove unused old files; (2) change incorrect file names; (3) add string ask templates; (4) remove meta properties from schemas; (5) fix an error in calculating optional properties * fix help property bug * Add string templates. * a few changes (#318) (1) fix the cancel.lu bug (2) add datetime.lu (2) stringSetdatetime.dialog.lg * Add template for not understood. * Connect to bf cli. * Add basic role support. * Nigao/newtemplate (#321) * a few changes (1) fix the cancel.lu bug (2) add datetime.lu (2) stringSetdatetime.dialog.lg * autohelp for new templates * Update to use @{} everywhere and remove auto-help since it required post-ask action. * Nigao/newtemplate (#323) * a few changes (1) fix the cancel.lu bug (2) add datetime.lu (2) stringSetdatetime.dialog.lg * autohelp for new templates * add $requires, and datetime entity sets * add all stringSet for prebuilt entities explicitly * change prebuilt-entity.lu.lg files * Switch to using a triggerIntent instead of none for entities. Cleanup filename expressions. * Fix bug in status. * Switch from dialog:form to dialog:generate * Add top-level documentation. * Update tests to use dialog:generate. * Rename tests to generator. * Fixing linting errors * Generate confirmation card. * Fix reference regex ot not match structured lg.
chrimc62
added a commit
that referenced
this pull request
Nov 22, 2019
* Intermediate check-in before inverting template/prop loops. * Working generator with incomplete templates. * Basic .lu files working. * Update to generate single .lu file. * Fix cli issues. * Fix CLI issues with template resources. * Clean up lint warnings. * Fix lint errors. * Generate composite .lu * Add dialog and multi-language support. * shortcut to debug * Add per-locale .lg file. * Update debug config to use temp directory. Generate multilingual .lg file. * Update to include schema prefix on names. * Fix bugs in .lg genertion. * try help * help and cancel * Copy schema to output directory. * help and cancel version 1 * separate help.lu * several fixes * remove help enum * reset launch.json * remove empty line * Add the ability to copy library dialog files. * Add ability to specify schema and multiple templates. * Rename resources. Support multiple templates. Add *PROPN** pattern. * Fix bug in striingify call. * Generate schema.main.dialog and update config. * Update templates to newest format. * Update templates to match names. * add .dialogs for several basic rules * Update templates to use $ and add begindialog as a hack to work around ada ptive issue. * add .dialogs for several basic rules * fix comments * merge from origin * small changes * Add formCopy cmd file. * Adjust for bug in templates. * fix path * Version 1 of contact.form.dialog * Same info is modeled for both Home and Work. * List of state abbreviations and their spelled-out names are specified in the separate state.en-us.lu, and used in the $mappings specifications. * Latitude and Longitude should be auto-filled if the corresponding address are filled. * Validation patterns are specified for zip codes and phone numbers. * Fixed contact.form.dialog and added activity.form.dialog * contact.form.dialog - Fixed spelling - Use phonenumber prebuilt entity type * activity.form.dialog: the second scenario from Darren "An employee working for a customer wants to add a quick update to a customer record after a call. This update will then be available for other people working with that customer to see". * Added opportunity.form.dialog For Darren's scenario "An employee working with a customer has had a meeting and needs to create a new opportunity." * change names * Revert "change names" This reverts commit 64ffaff. * change names * basic work done for ask, set and help * cancel confirmation * cancel confirmation done, unexpected property set confirmation in progress * improve unexpected property test * Version 1 of contact.form.dialog * Same info is modeled for both Home and Work. * List of state abbreviations and their spelled-out names are specified in the separate state.en-us.lu, and used in the $mappings specifications. * Latitude and Longitude should be auto-filled if the corresponding address are filled. * Validation patterns are specified for zip codes and phone numbers. * Fixed contact.form.dialog and added activity.form.dialog * contact.form.dialog - Fixed spelling - Use phonenumber prebuilt entity type * activity.form.dialog: the second scenario from Darren "An employee working for a customer wants to add a quick update to a customer record after a call. This update will then be available for other people working with that customer to see". * Added opportunity.form.dialog For Darren's scenario "An employee working with a customer has had a meeting and needs to create a new opportunity." * rename state.lu * prebuilt lu templates * remove choose entity we only have chooseProperty and clarifyEntity * Switch to event expected. * Update templates for latest runtime and add ask for multiple properties. * Add **NAMES/**NAME** and generate property names. * fix unexpected property confirmation usage * change unexpected property action from ask to sendactivity * all done confirmation * Update names to support chooseProperty. * Check-in bread value hack. * Fix template bug around clarify. * Update templates to use names and start numbers. * complete the new forms * contextual help * activity schema working fine * add meta info to opportunity schema * opportunity semi-working cannot use phonenumber; properties not in required also got asked; in stringset, default value is not expression, cannot get the value for @email * three schemas working sandwich, activity, opportunity * contact schema working Adding welcome message in beginDialog, Add help message for non-enum properties, All three CDS schemas working * Sync changes for demo. * Before adding mapping templates * Getting close to E2e. * Largely working with some template debugging. * Update the readme. * Update to latest expression and lg packages. Support app schema. * Update standard schema. * Finish merge. * Show metaschema. * Fix readme typo. * several changes (#299) * several changes (1) remove unused old files; (2) change incorrect file names; (3) add string ask templates; (4) remove meta properties from schemas; (5) fix an error in calculating optional properties * fix help property bug * Add string templates. * a few changes (#318) (1) fix the cancel.lu bug (2) add datetime.lu (2) stringSetdatetime.dialog.lg * Add template for not understood. * Connect to bf cli. * Add basic role support. * Nigao/newtemplate (#321) * a few changes (1) fix the cancel.lu bug (2) add datetime.lu (2) stringSetdatetime.dialog.lg * autohelp for new templates * Update to use @{} everywhere and remove auto-help since it required post-ask action. * Nigao/newtemplate (#323) * a few changes (1) fix the cancel.lu bug (2) add datetime.lu (2) stringSetdatetime.dialog.lg * autohelp for new templates * add $requires, and datetime entity sets * add all stringSet for prebuilt entities explicitly * change prebuilt-entity.lu.lg files * Switch to using a triggerIntent instead of none for entities. Cleanup filename expressions. * Fix bug in status. * Switch from dialog:form to dialog:generate * Add top-level documentation. * Update tests to use dialog:generate. * Rename tests to generator. * Fixing linting errors * Generate confirmation card. * Fix reference regex ot not match structured lg. * Minor bug fixes. * Update to allow multi-lingual fallback.
chrimc62
added a commit
that referenced
this pull request
Dec 2, 2019
* Intermediate check-in before inverting template/prop loops. * Working generator with incomplete templates. * Basic .lu files working. * Update to generate single .lu file. * Fix cli issues. * Fix CLI issues with template resources. * Clean up lint warnings. * Fix lint errors. * Generate composite .lu * Add dialog and multi-language support. * shortcut to debug * Add per-locale .lg file. * Update debug config to use temp directory. Generate multilingual .lg file. * Update to include schema prefix on names. * Fix bugs in .lg genertion. * try help * help and cancel * Copy schema to output directory. * help and cancel version 1 * separate help.lu * several fixes * remove help enum * reset launch.json * remove empty line * Add the ability to copy library dialog files. * Add ability to specify schema and multiple templates. * Rename resources. Support multiple templates. Add *PROPN** pattern. * Fix bug in striingify call. * Generate schema.main.dialog and update config. * Update templates to newest format. * Update templates to match names. * add .dialogs for several basic rules * Update templates to use $ and add begindialog as a hack to work around ada ptive issue. * add .dialogs for several basic rules * fix comments * merge from origin * small changes * Add formCopy cmd file. * Adjust for bug in templates. * fix path * Version 1 of contact.form.dialog * Same info is modeled for both Home and Work. * List of state abbreviations and their spelled-out names are specified in the separate state.en-us.lu, and used in the $mappings specifications. * Latitude and Longitude should be auto-filled if the corresponding address are filled. * Validation patterns are specified for zip codes and phone numbers. * Fixed contact.form.dialog and added activity.form.dialog * contact.form.dialog - Fixed spelling - Use phonenumber prebuilt entity type * activity.form.dialog: the second scenario from Darren "An employee working for a customer wants to add a quick update to a customer record after a call. This update will then be available for other people working with that customer to see". * Added opportunity.form.dialog For Darren's scenario "An employee working with a customer has had a meeting and needs to create a new opportunity." * change names * Revert "change names" This reverts commit 64ffaff. * change names * basic work done for ask, set and help * cancel confirmation * cancel confirmation done, unexpected property set confirmation in progress * improve unexpected property test * Version 1 of contact.form.dialog * Same info is modeled for both Home and Work. * List of state abbreviations and their spelled-out names are specified in the separate state.en-us.lu, and used in the $mappings specifications. * Latitude and Longitude should be auto-filled if the corresponding address are filled. * Validation patterns are specified for zip codes and phone numbers. * Fixed contact.form.dialog and added activity.form.dialog * contact.form.dialog - Fixed spelling - Use phonenumber prebuilt entity type * activity.form.dialog: the second scenario from Darren "An employee working for a customer wants to add a quick update to a customer record after a call. This update will then be available for other people working with that customer to see". * Added opportunity.form.dialog For Darren's scenario "An employee working with a customer has had a meeting and needs to create a new opportunity." * rename state.lu * prebuilt lu templates * remove choose entity we only have chooseProperty and clarifyEntity * Switch to event expected. * Update templates for latest runtime and add ask for multiple properties. * Add **NAMES/**NAME** and generate property names. * fix unexpected property confirmation usage * change unexpected property action from ask to sendactivity * all done confirmation * Update names to support chooseProperty. * Check-in bread value hack. * Fix template bug around clarify. * Update templates to use names and start numbers. * complete the new forms * contextual help * activity schema working fine * add meta info to opportunity schema * opportunity semi-working cannot use phonenumber; properties not in required also got asked; in stringset, default value is not expression, cannot get the value for @email * three schemas working sandwich, activity, opportunity * contact schema working Adding welcome message in beginDialog, Add help message for non-enum properties, All three CDS schemas working * Sync changes for demo. * Before adding mapping templates * Getting close to E2e. * Largely working with some template debugging. * Update the readme. * Update to latest expression and lg packages. Support app schema. * Update standard schema. * Finish merge. * Show metaschema. * Fix readme typo. * several changes (#299) * several changes (1) remove unused old files; (2) change incorrect file names; (3) add string ask templates; (4) remove meta properties from schemas; (5) fix an error in calculating optional properties * fix help property bug * Add string templates. * a few changes (#318) (1) fix the cancel.lu bug (2) add datetime.lu (2) stringSetdatetime.dialog.lg * Add template for not understood. * Connect to bf cli. * Add basic role support. * Nigao/newtemplate (#321) * a few changes (1) fix the cancel.lu bug (2) add datetime.lu (2) stringSetdatetime.dialog.lg * autohelp for new templates * Update to use @{} everywhere and remove auto-help since it required post-ask action. * Nigao/newtemplate (#323) * a few changes (1) fix the cancel.lu bug (2) add datetime.lu (2) stringSetdatetime.dialog.lg * autohelp for new templates * add $requires, and datetime entity sets * add all stringSet for prebuilt entities explicitly * change prebuilt-entity.lu.lg files * Switch to using a triggerIntent instead of none for entities. Cleanup filename expressions. * Fix bug in status. * Switch from dialog:form to dialog:generate * Add top-level documentation. * Update tests to use dialog:generate. * Rename tests to generator. * Fixing linting errors * Generate confirmation card. * Fix reference regex ot not match structured lg. * Minor bug fixes. * Update to allow multi-lingual fallback. * Change from $type to $kind. Change unionType to union. Add documentation. * Move from $type to $kind. * Enable schema tests. * Switch to $kind and add dynamic .schema. * Update string to new help pattern. * Merge with master and support $kind. * Address review comments.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.