Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix ambiguous duplicate bug #1269

Merged
merged 3 commits into from
Jul 14, 2021
Merged

fix ambiguous duplicate bug #1269

merged 3 commits into from
Jul 14, 2021

Conversation

hcyang
Copy link
Contributor

@hcyang hcyang commented Jul 13, 2021

remove ambiguous entries if they are in the ground-truth labels

@hcyang hcyang requested a review from munozemilio as a code owner July 13, 2021 05:30
@hcyang hcyang requested review from tsuwandy and daveta July 13, 2021 05:30
tsuwandy
tsuwandy approved these changes Jul 13, 2021
View reviewed changes
Copy link
Contributor

@tsuwandy tsuwandy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add a test?

@munozemilio
Copy link
Member

@hcyang Ill approve and let you merge so you can address @joshgummersall comment

joshgummersall
joshgummersall approved these changes Jul 14, 2021
View reviewed changes
Copy link
Contributor

@joshgummersall joshgummersall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@hcyang hcyang merged commit ead1751 into main Jul 14, 2021
@munozemilio munozemilio deleted the hunyang/OC_BFCLI_BotframeworkOrchestratorCliAmbiguousTopDedup branch August 23, 2021 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshgummersall joshgummersall joshgummersall approved these changes

@daveta daveta daveta approved these changes

@tsuwandy tsuwandy tsuwandy approved these changes

@munozemilio munozemilio munozemilio approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@hcyang @munozemilio @joshgummersall @daveta @tsuwandy