-
Notifications
You must be signed in to change notification settings - Fork 128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cherry pick changes from main #1194
Conversation
#1182) * replace node fetch and luis client to axios to enable proxy in luis and qnamaker build * fix tests
* Switch to axios to support proxy server when merging. Normalize sorting to reduce variation. * modify https proxy setting * refactor * fix lint * fix lint Co-authored-by: Chris McConnell <chrimc> Co-authored-by: cosmicshuai <shuai_uf@outlook.com>
Getting chatdown build errors.. @feich-ms does this look familiar? |
I ever ran into this when I rush build locally, but haven't seen this in online CI validation. I can repro this error after I run rush update and then rush build. I think this may be caused by the upgrade of typescript version, fix should be easy https://stackoverflow.com/questions/65354965/error-ts2794-expected-1-arguments-but-got-0-did-you-forget-to-include-void |
This is referencing a package with security problems. |
Fixes #1193