Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tokenizerVersion parameter to bf luis:convert #550

Closed
marawanshalaby opened this issue Feb 7, 2020 · 2 comments · Fixed by #558
Closed

Add tokenizerVersion parameter to bf luis:convert #550

marawanshalaby opened this issue Feb 7, 2020 · 2 comments · Fixed by #558
Assignees
@vishwacsena
Labels
Bot Services Required for internal Azure reporting. Do not delete. Do not change color. customer-reported Issue is created by anyone that is not a collaborator in the repository. lu non luis api commands R8 Release 8 - March 16th, 2020

Comments

@marawanshalaby
Copy link

We are training german models and would like to specify the tokenizerVersion to be injected into the json file created by bf luis:convert. Currently it's only possible to specify this parameter manually in the json file because neither the ludown nor the bf-cli tools support adding it automatically to the json file they generate from the raw .lu file.

Related ticket about the documentation for this feauture in the luis json file: MicrosoftDocs/azure-docs#47575
@marawanshalaby marawanshalaby mentioned this issue Feb 7, 2020
Closed
@daveta daveta added Bot Services Required for internal Azure reporting. Do not delete. Do not change color. customer-reported Issue is created by anyone that is not a collaborator in the repository. enhancement labels Feb 7, 2020
@daveta
Copy link
Contributor

daveta commented Feb 7, 2020

@scheyal : Can you please triage this?

@clearab clearab assigned vishwacsena and unassigned scheyal Feb 10, 2020
@clearab
Copy link

clearab commented Feb 10, 2020

@vishwacsena Can you take a look at this please?

@vishwacsena vishwacsena added lu non luis api commands R8 Release 8 - March 16th, 2020 labels Feb 10, 2020
@vishwacsena vishwacsena mentioned this issue Feb 11, 2020
Merged
vishwacsena pushed a commit that referenced this issue Feb 11, 2020
@feich-ms
Fixes #550, #255 (#558)
a590ff8 
* Fix

* fixing tests.

* fix default locale issue

Co-authored-by: Fei Chen <43032123+feich-ms@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vishwacsena vishwacsena

Labels
Bot Services Required for internal Azure reporting. Do not delete. Do not change color. customer-reported Issue is created by anyone that is not a collaborator in the repository. lu non luis api commands R8 Release 8 - March 16th, 2020
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixes #550, #255 microsoft/botframework-cli
5 participants
@clearab @daveta @scheyal @vishwacsena @marawanshalaby