syncLabelResolverEx should return after addBatch (#1266)

* Update build.ts Return after addBatch * Update create.test.ts
microsoft · Jul 8, 2021 · f16ca8f · f16ca8f
1 parent cf471cf
commit f16ca8f
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 0 deletions.
diff --git a/packages/orchestratorlib/src/build.ts b/packages/orchestratorlib/src/build.ts
@@ -161,6 +161,7 @@ export class OrchestratorBuild {
       Utility.debuggingLog('OrchestratorBuild.syncLabelResolverEx(), ready to call LabelResolver.addBatch()');
       LabelResolver.addBatch(target);
       Utility.debuggingLog('OrchestratorBuild.syncLabelResolverEx(), after calling LabelResolver.addBatch()');
+      return;
     }
     // ---- NOTE ---- delete example intent label if it is not in target.
     subject.utteranceLabelsMap.forEach((labels: Set<string>, utterance: string) => {

diff --git a/packages/orchestratorlib/test/create.test.ts b/packages/orchestratorlib/test/create.test.ts
@@ -74,6 +74,7 @@ describe('OrchestratorCreateTests', () => {
     assert.ok(snapshotContent.indexOf('HomeAutomation') > 0);
     assert.ok(snapshotContent.indexOf('Weather') > 0);
 
+    // add another lu file to input and make sure new intent is added (snapshot updated incrementally)
     fs.ensureDirSync(inputPath2);
     fs.copySync(path.resolve(inputPath), inputPath2);
     fs.copySync(path.resolve('./test/fixtures/Gaming.lu'), path.join(inputPath2, 'Gaming.lu'));
@@ -91,6 +92,22 @@ describe('OrchestratorCreateTests', () => {
     assert.ok(snapshotContent2.indexOf('HomeAutomation') > 0);
     assert.ok(snapshotContent2.indexOf('Weather') > 0);
     assert.ok(snapshotContent2.indexOf('Gaming') > 0);
+
+    // start clean and make sure file size is the same as previous run (snapshot created via addBatch)
+    Utility.deleteFile(snapshotPath);
+    await OrchestratorCreate.runAsync(
+      baseModelPath,
+      '',
+      inputPath2,
+      inputPath,
+      true);
+
+    assert.ok(Utility.exists(snapshotPath));
+    const snapshotContent3: string = OrchestratorHelper.readFile(snapshotPath);
+    assert.ok(snapshotContent3.length === snapshotContent2.length);
+    assert.ok(snapshotContent2.indexOf('HomeAutomation') > 0);
+    assert.ok(snapshotContent2.indexOf('Weather') > 0);
+    assert.ok(snapshotContent2.indexOf('Gaming') > 0);
   });
 
   it('Create Snapshot - LU file with reference to other LU file', async function (): Promise<void> {