Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove ms-rest-azure package #4521

Merged
merged 3 commits into from
Aug 18, 2023

Conversation

ceciliaavila
Copy link
Collaborator

#minor

Description

This PR removes ms-rest-azure to avoid using request due to its security vulnerability.

Specific Changes

  • Replaced UserTokenCredentials and ApplicationTokenCredentials by UsernamePasswordCredential and ClientSecretCredential in suite-base.
  • Installed ms-rest-azure-env to use Environment from this package instead of ms-rest-azure.
  • Added BaseResource and CloudError models in tools resources.
  • Added getPackageJsonInfo and addUserAgentInfo methods into ResourceManagementClient class.
  • Replaced the generateUuid method of ms-rest-azure with the uuid generator.

Testing

The following image shows the botframework-connector tests, which use bb tools, running successfully.
image

@ceciliaavila ceciliaavila requested a review from a team as a code owner August 18, 2023 13:02
@coveralls
Copy link

coveralls commented Aug 18, 2023

Pull Request Test Coverage Report for Build 5902968213

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 84.852%

Totals Coverage Status
Change from base Build 5892509380: 0.0%
Covered Lines: 20134
Relevant Lines: 22485

💛 - Coveralls

@tracyboehrer tracyboehrer merged commit 59e5d96 into main Aug 18, 2023
13 checks passed
@tracyboehrer tracyboehrer deleted the southworks/update/remove-ms-rest-azure branch August 18, 2023 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants